Code Monkey home page Code Monkey logo

mailersend-java's People

Contributors

dagnelies avatar dependabot[bot] avatar fosron avatar johnkelesidis avatar nachots-codefuente avatar nklmilojevic avatar robgordon89 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

mailersend-java's Issues

Suggest to add token as .env variable instead of explicit declaration

To better enforce security on our SDKs and avoid incidents, please avoid suggesting our users set explicit declaration of the API/SMTP token in the code and instead suggest setting the API key as an environment variable.

  • Remove all mentions of the token added to any endpoint "ms.setToken("Your API token");"
  • Suggest users to add the token as a .env variable. Name the variable MAILERSEND_API_KEY.
  • Make it optional.

See Slack convo

Add the priority parameter to the inbound route endpoints

We have a new parameter called "inbound_priority" on our Inbound Routes. This parameter allows our users to create multiple inbound routes per inbound subdomain. Each one of the routes will be processed in a descending order. Values can be between 0 and 100. 0 has more importance than 100.

Create the Email verification endpoints

  • Get all email verification lists
  • Get an email verification list
  • Create an email verification list
  • Verify an email list
  • Get email verification list results

variables are not being filled

Fix bug when sending email with template, variables are not being filled

The fix is quite simple, after line 292 in the Email.java file add the code:

this.templateVariables.add(var);

Camelcase methods should start with lowercase

By convention in Java methods start with lowercase. They are documented as such in the readme, but wrong in the code (1.0.0).

For instance AddBccshould be addBcc, also many others...


    public void AddRecipient(Recipient recipient) {
        this.recipients.add(recipient);
    }

    public void AddRecipients(Recipient[] recipients) {
        this.recipients.addAll(Arrays.asList(recipients));
    }

    public void AddCc(String name, String email) {
        Recipient recipient = new Recipient(name, email);
        this.cc.add(recipient);
    }

    public void AddCc(Recipient recipient) {
        this.cc.add(recipient);
    }

    public void AddBcc(String name, String email) {
        Recipient recipient = new Recipient(name, email);
        this.bcc.add(recipient);
    }

    public void AddBcc(Recipient recipient) {
        this.bcc.add(recipient);
    }

    public void AddReplyTo(Recipient replyTo) {
        this.replyTo = replyTo;
    }

    public void AddReplyTo(String name, String email) {
        this.replyTo = new Recipient(name, email);
    }

Add missing parameters to Domains endpoints

We added two parameters for our domains: ignore duplicated recipients and add a precedence bulk header. Both of these parameters have to be added to our related Domains endpoints.

  • Add the ignore_duplicated_recipients and the precedence_bulk parameters to the Get a list of domains endpoint.
  • Add the ignore_duplicated_recipients and the precedence_bulk parameters to the Get a single domain endpoint.
  • Add the ignore_duplicated_recipients and the precedence_bulk parameters to the Add a domain endpoint.
  • Add the ignore_duplicated_recipients and the precedence_bulk parameters to the Update domain settings endpoint.

Update the list of all webhook events

Please update the list of all webhook events in the documentation or any place where they are mentioned:
SOFT_BOUNCED = "activity.soft_bounced",
HARD_BOUNCED = "activity.hard_bounced",
OPENED = "activity.opened",
OPENED_UNIQUE = "activity.opened_unique",
CLICKED = "activity.clicked",
CLICKED_UNIQUE = "activity.clicked_unique",
UNSUBSCRIBED = "activity.unsubscribed",
SPAM_COMPLIANT = "activity.spam_complaint",
SURVEY_OPENED = "activity.survey_opened",
SURVEY_SUBMITTED = "activity.survey_submitted",
IDENTITY_VERIFIED = "sender_identity.verified",
MAINTENANCE_START = "maintenance.start",
MAINTENANCE_END = "maintenance.end",

Inbound routes

  • Get a list of inbound routes
  • Get an inbound route
  • Create an inbound route
  • Update an inbound route
  • Delete an inbound route

Scheduled messages

  • Schedule an email
  • Get a list of scheduled messages
  • Get a scheduled message
  • Delete a scheduled message

version 1.0.0

Hello, I would like to ask why the 1.1.1 version I imported does not exist import com.mailersend.sdk.Email
image
image

Variables are not being filled

Fix bug when sending email with template, variables are not being filled

The fix is quite simple, after line 341 in the Email.java file add the code:

this.templateVariables.add(var);

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.