mailerlite / mailerlite-ruby Goto Github PK
View Code? Open in Web Editor NEWLicense: MIT License
License: MIT License
mailerlite-ruby: 1.0.2
rails: 6.1.5
ruby: 2.7.6
I'm having difficulty following the README docs. For starters, the docs namespace every call with Mailerlite
, but I don't even have Mailerlite
defined; for me it is MailerLite
.
Next, the first "List all subscribers" call results in the following error:
> subscribers = MailerLite::Subscribers.new
> response = subscribers.list(filter: { status: 'active' })
Traceback (most recent call last):
1: from (irb):21
NoMethodError (undefined method `list' for #<MailerLite::Subscribers:0x00007fe2f9e40ca8>)
And getting a single subscriber results in this error:
> subscribers.get('[email protected]')
Traceback (most recent call last):
2: from (irb):22
1: from (irb):23:in `rescue in irb_binding'
NameError (uninitialized constant MailerLite::VERSION)
This method is expecting a page parameter, but the API is using cursor pagination (See https://github.com/mailerlite/mailerlite/pull/10128)
Also our docs: https://developers.mailerlite.com/docs/subscribers.html#list-all-subscribers
We should update method to expect with a cursor instead
This could break existing implementations. Maybe we need a new major version
There is a typo in the README
To List all groups, it should be .get
, instead of .list
.
This groups.list(limit:10, page:1, filter:{'name': 'My'}, sort:'name')
doesn't work. But groups.get(limit:10, page:1, filter:{'name': 'My'}, sort:'name')
works
We've issued 3 PRs that haven't been looked at in over a month:
I wrote in to support and according to them the repository is unmaintained:
Currently our team does not actively those repositories and we don't do it upon request. If you can please try to explain the issues you are facing here and we could investigate it.
One of the reasons we chose to use mailerlite is the Ruby bindings. If this unmaintained, I'd expect the repository to be archived, or to have a large warning in the README.
Posting this also as a PSA to other companies considering using Mailerlite. Support seems to have made it clear that there's no ETA they can share on these PRs being looked at.
This method is expecting a page parameter, but the API is using cursor pagination.
API doc: https://developers.mailerlite.com/docs/groups.html#get-subscribers-belonging-to-a-group
Maybe consider to update method to expect with a cursor instead?
Automations:
Batching:
Timezones:
Campaign languages:
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.