mailerlite / mailerlite-ruby Goto Github PK

mailerlite-ruby: 1.0.2
rails: 6.1.5
ruby: 2.7.6

I'm having difficulty following the README docs. For starters, the docs namespace every call with Mailerlite, but I don't even have Mailerlite defined; for me it is MailerLite.

Next, the first "List all subscribers" call results in the following error:

> subscribers = MailerLite::Subscribers.new
> response = subscribers.list(filter: { status: 'active' })
Traceback (most recent call last):
        1: from (irb):21
NoMethodError (undefined method `list' for #<MailerLite::Subscribers:0x00007fe2f9e40ca8>)

And getting a single subscriber results in this error:

> subscribers.get('[email protected]')
Traceback (most recent call last):
        2: from (irb):22
        1: from (irb):23:in `rescue in irb_binding'
NameError (uninitialized constant MailerLite::VERSION)

This method is expecting a page parameter, but the API is using cursor pagination (See https://github.com/mailerlite/mailerlite/pull/10128)

Also our docs: https://developers.mailerlite.com/docs/subscribers.html#list-all-subscribers

We should update method to expect with a cursor instead

This could break existing implementations. Maybe we need a new major version

• List webhooks
• Get a webhook
• Create a webhook
• Update a webhook
• Delete a webhook

There is a typo in the README

To List all groups, it should be .get, instead of .list.

This groups.list(limit:10, page:1, filter:{'name': 'My'}, sort:'name') doesn't work. But groups.get(limit:10, page:1, filter:{'name': 'My'}, sort:'name') works

• List campaigns (by status and by type)
• Create a campaign
• Update a campaign
• Send, schedule or cancel campaign
• Delete a campaign

• Get all subscribers
• Create/update subscriber
• Fetch a subscriber
• Fetch total subscribers count
• Delete a subscriber

• Get list of groups
• Create a group
• Get subscribers belonging to a group
• Assign subscriber to a group
• Unassign subscriber from a group
• Update a group (name, etc.)
• Delete a group

We've issued 3 PRs that haven't been looked at in over a month:

• #18
• #17
• #16

I wrote in to support and according to them the repository is unmaintained:

Currently our team does not actively those repositories and we don't do it upon request. If you can please try to explain the issues you are facing here and we could investigate it.

One of the reasons we chose to use mailerlite is the Ruby bindings. If this unmaintained, I'd expect the repository to be archived, or to have a large warning in the README.

Posting this also as a PSA to other companies considering using Mailerlite. Support seems to have made it clear that there's no ETA they can share on these PRs being looked at.

• Get list of segments
• Get subscribers belonging to a segment
• Update a segment (name, etc.)
• Delete a segment

This method is expecting a page parameter, but the API is using cursor pagination.

API doc: https://developers.mailerlite.com/docs/groups.html#get-subscribers-belonging-to-a-group

Maybe consider to update method to expect with a cursor instead?

• List forms
• Update a form (name, etc.)
• Delete a form

• List fields
• Create a field
• Update a field (name, etc.)
• Delete a field

Automations:

• List all automations
• Get an automation
• Get the subscriber activity for an automation

Batching:

• Make multiple requests in a single call

Timezones:

• Get all available timezones

Campaign languages:

• Get a list of all campaign languages available

• Get a list of sent campaigns
• Get stats for a sent campaign
• Get a subscribers of sent campaign
• Get a list of forms by type
• Get a stats of a form by type
• Get subscribers of a form by type
• Get a list of automations
• Get a stats for a specific automation
• Get a list of subscribers of a specific automation by type (completed, failed, etc.)