mahjouba91 / multiple-roles Goto Github PK

Bonjour @Mahjouba91

Je vois que le plugin a été rejeté par WP pour des raisons de sécurités.

Un update à venir ?

Hello,

Just to inform you that when installing the plugin on my WordPress (v.4.7) I had an error exception.

Call to undefined function debug()
on multiple-roles\multiple-roles.php l.37

// For new user form (in Backoffice)
// In multisite, user_register hook is too early so wp_mu_activate_user add user role after
if ( is_multisite() ) {
//	add_filter( 'signup_user_meta',      array( $checklist, 'mu_add_roles_in_signup' ), 10, 4 ); // Waiting https://core.trac.wordpress.org/ticket/39223
	$bool = remove_action( 'wpmu_activate_user', 'add_new_user_to_blog', 10, 3 );
	debug( $bool );
	add_action( 'wpmu_activate_user',    array( $checklist, 'mu_add_roles_after_activation' ), 10, 3 );
} else {
	add_action( 'user_register',         array( $checklist, 'process_checklist' ) );
}

Removing the line debug( $bool ); fix the issue.

Thanks,

Guillaume

In multiple places you're checking that the new roles array is not empty before the changes are applied, usually with the following...

if ( empty( $roles ) ) {
	return false;
}

• MDMR_Model::update_roles() line 70
• MDMR_Checklist_Controller:: process_checklist() line 73

This means that we're unable to remove all roles for a particular user, and if we do un-check all of the checkboxes, no changes are made to the user's roles.

Hi Florian,
Is there any chance an update to this great little plugin can be released here (https://wordpress.org/plugins/multiple-roles/) to stop the Wordfence alerts?
May be also modify readme.txt to include PHP version

=== Multiple Roles ===
…
Requires PHP: 7.2
…

many thanks

I'm trying to use a front end form (Gravity Forms) to assign User Roles (multiple) to a new User Registration. I'm using a plugin called User Role Editor to create the User Roles and this plugin to allow for multiple roles per user. I'm using mu_add_roles_in_signup_meta within Gravity forms to try to assign the user roles for the user registration but it's not working. Any suggestions how I might be able to get this to work?

Hello,

There is a problem with bbPress WordPress plugin (https://bbpress.org/) once your plugin is activated. Indeed, when you add a new WordPress role to the user, the bbPress role vanishes and it's impossible to set it again.

Wordpress uses the promote_users cap to establish whether a user can change a user's role, not edit_users.

We have a Client role set up to provide clients with most user related admin capabilities, with the exception of the promote_users cap. This prevents them from creating any new administrator users, or accidentally promoting a regular user to an administrator etc.

With this plugin installed, users with the Client role are able to assign/revoke roles when they shouldn't be allowed to, because the plugin checks for the edit_users instead of promote_users (in MDMR_Model::can_update_roles())

The profile_update action can be triggered in processes where the plugin's roles checklist has not been output, resulting in the user's roles being lost.

Check for existence of the checklist in MDMR_Checklist_Controller::process_checklist() before running MDMR_Model::update_roles().