Custom Region Layouts - V2.28.0 breaks functionality about magicmirror HOT 10 OPEN

see
https://forum.magicmirror.builders/topic/18852/magicmirror-regions

from magicmirror.

yes, the mentioned PR causes your problems.

AFAIR this was implemented to prevent crashes so we have less support.

@rejas @sdetweil from my side we could add an additional parameter in config.js to allow custom positions so that these (hopefully experienced) users don't have to fix this by changing our code.

from magicmirror.

@khassel yes prevent crashes but could be an optional property as u suggest. I also suggested code to do discovery, but could be trouble depending, on above

from magicmirror.

My vote would be to scan the index file for the regions when it does the check. It seems like this ability is already built-in somewhat to the codebase since it was able to use the custom regions before.

However, I always have to remember to replace the index file with my custom after an update, so having the alternative means to add these in via config or other means would also be good. Maybe a way to add a custom section similar to how you can do a custom CSS that gets injected into the index file automagically. That way if an update doesn't wipe out core manual updates.

from magicmirror.

before we we didn't validate the regions. but if it was wrong, there was a fatal error.. and MM didn't come up
we found a case with no module: and fixed that, and decided to validate the position names too.. this is what caught you..

I did write a sample bit of JS to extract the names from the index.html file.. and ad d them to the list to validate against.
if I can find it again..

from magicmirror.

const fs = require('fs')
const indexFile =   'index.html'

let lines = fs.readFileSync(indexFile).toString().split('\n')
let regionRegex = /"region ([^"]*)/i

lines.forEach(l =>{
        let results=regionRegex.exec(l)
        if(results && results.length>1){
           console.log("region='"+results[1].replace(' ','_')+"'")
        }
})

from magicmirror.

my above PR brings back the situation of v2.27.0, so this would solve this issue but still no solution for the index.html file.

We often had discussions about custom regions, but that was never implemented, e.g. #3231.

If we implement such a solution, it should be robust and not result in increased support.

from magicmirror.

well, your pr suspends checking. does not check new region names too.

from magicmirror.

as I said, brings back the situation of v2.27.0, not more

from magicmirror.

I thought you would make the property for an array of position names, to add/replace the default ones vs a flag to not check

from magicmirror.