Comments (5)
sdetweil
commented on August 24, 2024
1
I agree with your assessment. if you have a specific event list they should be not be combined with the general list.
from magicmirror.
rejas
commented on August 24, 2024
1
I agree also. Do you want to create a PR for that yourself with some help?
from magicmirror.
WallysWellies
commented on August 24, 2024
1
I would be happy to give it a go! Let me do some testing and reading up on how to GitHub and I’ll get back to you in the next couple of days.
Cheers for the encouragement :)
from magicmirror.
WallysWellies
commented on August 24, 2024
Forum link: https://forum.magicmirror.builders/topic/18793/default-compliments-module-special-days
from magicmirror.
WallysWellies
commented on August 24, 2024
I have done what I think I should have - forked, edited, and submitted a pull request referencing this issue. Please let me know if I have done something wrong.
I have another PR ready to go that updates the documentation with the proposed change but I'll hold fire on that until I know if I am doing this right.
from magicmirror.
Related Issues (20)
- PR 2881 extended calendar to receive notifications from other modules, but code in wrong place
- [weather] openmeteo precipitationProbability not shown in forecast
- newsfeed enclosured picture feature HOT 6
- [weather] openmeteo hourly does not work into next day
- [weather] provider openmeteo showing nightly icons in forecast when current time is "nightly"
- Electron >= v30.x uses Node v20
- OpenMeteo weather provider uses "apparent temperature" in forecast data instead of actual temperatures HOT 2
- Repeating calendar event shifted by 1 day when RRule is processed HOT 3
- Option to turn on/off monitor under certain conditions HOT 1
- [testing] local e2e-testing in docker container doesn't work anymore
- [updatenotification] use of this module creates pm2 daemon process(es) HOT 3
- fix e2e testcase startApplication() helper to accept run date/time like the electron helper with the same name does HOT 2
- [core] cleanup questions HOT 4
- H
- H HOT 1
- Multiple Instances of Node Helper running for a single module HOT 4
- [WARN] No /home/*user*/MagicMirror/js/../modules/MMM-Jast/MMM-Jast.js found for module: MMM-Jast HOT 2
- Custom Region Layouts - V2.28.0 breaks functionality HOT 10
- fix logging of systeminformation for raspberry pi HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magicmirror.