maddingue / sys-syslog Goto Github PK

Hey Sébastien,

This month I got Sys::Syslog as my CPAN Pull Request Challenge. You can read more about it here: http://blogs.perl.org/users/neilb/2014/12/take-the-2015-cpan-pull-request-challenge.html

I've taken a look at Sys::Syslog on rt.cpan.org and seen there are a number of open issues, but I think some of them can be closed as-is and others I'm not sure how to help on.

Github? - Can be closed, Sys::Syslog is clearly on github already ;-)

trailing new line with perror - This one has a patch, but no test. I tried writing a test for it but couldn't reproduce the problem the original poster is referring to.

Handle getprotobyn{ame,umber} not being available - Lots of discussion. Some patches. Maybe already applied?

Syslog Bug? - FreeBSD 9.2, Perl 5.16, messages coming through at the wrong level.

closelog(): wrong handling of syslog flags - "quite serious bug in closelog()"

Conditionalize the use of setlocale/LC_TIME - closely related to Handle getprotobyn{ame,umber} not being available

Use fallback/syslog.h if I_SYSLOG is not defined - Applied already, so I think this ticket should be closed.

[regression] facility from openlog() is not used - Applied already, ticket should be closed.

Description for Event ID 157 cannot be found on Windows 7 - Windows bug, and it seems none of us have access to a windows machine!

Invalid usage of function POSIX::_exit - Fix applied, ticket should be closed.

Typo in POD - Typo fixed, ticket should be closed.

test t/facilities-routing.t fails - Fix applied, ticket should be closed.

escape escapes - Lots of good discussion here. Looks like the discussion moved from rt to P5P in 2009... did this get solved?

escape codes - Last comment from 2008 says "I can't tell whether it just works or if nobody realised there is a problem." Still true?

Use of encoding - Looks like nothing happened here?

Code works with Solaris 8, but not with Solaris 10 - I think this got solved in 2008?

If there's anything I can do to help let me know :-)

I'm going to send you at least one small innocent pull request this evening to fulfil the CPAN PR Challenge requirements, but I'd much rather make a meaningful contribution.

Thanks,

Alex