We must verify that the miners who are listed in the answer when validator reveal, have a recorded commit and that they reveal it.

entry delay -> 10 minutes
exit delay -> 10 minutes

When the validator reveal their proposal, verify that the miners are already registered

to access a miner (in get_register_miner) you need to iterate over the miners vector, is that the best way to do it? or should I use a hashmap?

but consider how to get all miners in the future, perhaps using events? or does near has better data structures or do we need to use a different approach to store all miners plus to access them easily...

From create-near-app

When the validator reveal their proposal, verify that the AccountId Vector is a group of unique values,i.e, an address must not be repeated

the contract use some logs to validate some values, change this logs to an event logs using the event.rs file

  log!(
                "Attempted to register an already registered miner: {}",
                new_miner_id
            );

Validators are allow to choose the first 10 best miners. Implement the methods to obtain the top ten of every validator, and then obtain the first 10 places

Include github workflow file that build and run the tests of the project

Maybe this can help https://github.com/near/near-workspaces-rs/blob/main/.github/workflows/test.yml

Remove zombie code in the whole code base

When some account wants to request a governance decision is necessary to validate if this account is registered in the protocol

To improve the readme file:

• fix links
• better description
• better instructions
• etc

The variables should be 2 minutes

COMMIT_MINER_DURATION
REVEAL_MINER_DURATION
COMMIT_VALIDATOR_DURATION
REVEAL_VALIDATOR_DURATION

This will require to check how time is handled in near

Reorganice the code to separate the test in the test module. For example:

• test_events.rs
• test_lib.rs
• test_something.rs

Rename the files according to the near coonvention to ilustrate the files

• I clean the code, removing ghost code and innecesary comments.
• In the commit by miner method I add the return value using an enum to keep consistency
• Add some test related to the commit by minner method