Code Monkey home page Code Monkey logo

maas-tsp-api's People

Contributors

brylie avatar feijk avatar laurisvan avatar nanuuki avatar pippuri avatar theillzilla avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

maas-tsp-api's Issues

Upgrade to Swagger UI 3.x

We currently include Swagger UI 2.x directly in this repository. The latest version of Swagger UI, as of this writing, is 3.4 (released on 2017-10-21).

Task

  • Upgrade this project to use Swagger UI 3.x
  • If possible, the Swagger UI dependency should be installed from NPM, rather than including the Swagger UI sourcecode directly

Ensure mode type definition has allowed values

In the OpenAPI Designer UI, the 'mode' type definition seems to have some allowed values listed. However, the allowed values are not being displayed.

Task

  • Determine why the allowed values are not displaying.
  • If necessary, update the 'mode' definition allowed values so they display correctly

Add a description to the Place definition 'latitude' property

The Place definition, 'latitude' property currently lacks a description.

Task

  • Add a description to the Place definition 'latitude' property

Consideration

Consider whether the latitude property should have its own definition, so it may be referenced in other definitions.

Add Contributors guide

Since we want to encourage outside participation in the development of this API definition, we should have clear guidelines for contributing. This is typically provided in written form via a file such as CONTRIBUTING(.md).

Task

  • Add CONTRIBUTING.md file
  • Include basic guidelines for contributing
    • creating new issues/feature requests
    • making changes (PR process)
    • code of conduct?

Resources

Add 'description' to Leg definition 'route' property

The Leg definition, 'route' property currently lacks a description.

Task

  • Add a description to the Leg definition 'route' property.

Consideration

Determine whether it might be better to define the 'route' as its own data type, so that it may be re-used in other type definitions.

UI difference on Android and IOS

Text difference IOS: "Your real name is needed for identification purposes when making bookings or issuing tickets"
Android (app version 1.5.241): also not allowing date of birth entry
android

Link to provider terms

After installing the production Android app and activating the Whim Urban 30 plan for Helsinki, the user is asked to enter data into the HSL website. However, this externally hosted form provides no details about how the data is collected. It is unclear whether the Whim terms apply. I suggest adding a link above the button to the provider policy. Screenshot attached.

Screenshot_20191119-203058

Add a description to the Place definition 'longitude' property

The Place definition, 'longitude' property currently lacks a description.

Task

  • Add a description to the Place definition 'longitude' property

Consideration

Consider whether the longitude property should have its own definition, so it may be referenced in other definitions.

SwaggerUi is not defined

When trying to load the root route, I am seeing the following error in console:

Uncaught ReferenceError: SwaggerUi is not defined
    at HTMLDocument.<anonymous> ((index):45)
    at f (jquery-1.8.0.min.js:1)
    at Object.fireWith [as resolveWith] (jquery-1.8.0.min.js:1)
    at Function.ready (jquery-1.8.0.min.js:1)
    at HTMLDocument.pe (jquery-1.8.0.min.js:1)

This is strange, however, since SwaggerUI seems to load properly:

screenshot from 2017-10-27 10-25-54

Upgrade spec to OpenAPI v3

Currently, the specification is written in Swagger (OpenAPI v2) format. Upgrade the specification to use OpenAPI v3 format.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.