The parse-sendgrid-mailer from m1gu3l

parse-sendgrid-mailer's People

Contributors

Stargazers

Watchers

parse-sendgrid-mailer's Issues

TypeError: Cannot read property 'length' of undefined

Hi, was very excited when I found this library as I need to send PDF attachments, but when I do this simple example:

mailer
    .mail()
    .property('from', '[email protected]')
    .property('to', '[email protected]')
    .property('subject', 'Report')
    .property('text', 'Lorem ipsum dolor sit amet')
    .send()

I get the following error, when the code reaches send().

Result: TypeError: Cannot read property 'length' of undefined
    at Function.Buffer.concat (buffer.js:667:20)
    at SendGridEmail.send (lib/sendgrid-mailer.js:66:22)
    at e.<anonymous> (reportStaticMails.js:24:14)
    at e.i (Parse.js:14:27703)
    at e.a.value (Parse.js:14:27063)
    at e.<anonymous> (Parse.js:14:27774)
    at e.i (Parse.js:14:27703)
    at Parse.js:14:28316
    at l (Parse.js:14:28120)
    at e.a.value (Parse.js:14:28301)

Both my Cloud Code and Javascript SDK is fully up to date

Discovery1: Think it was a scope issue with this will create a pull request in a few hours.

SendGridEmail.prototype.send = function() {
    var _this = this;
    this._buffers.push( new Buffer('--' + boundary + '--') );

    return Parse.Cloud.httpRequest({
        url: 'https://api.sendgrid.com/api/mail.send.json',
        method: 'POST',
        headers: {
            'Content-Type': 'multipart/form-data; boundary=' + boundary
        },
        body: Buffer.concat(_this._buffers)
    });
}

Discovery2: To attach a pdf, I had to do:

var Buffer = require('buffer').Buffer;

mailer.mail().attach('report.pdf', 'application/pdf', new Buffer(fileBuffer))

No clue if that can be avoided, otherwise it might be worth updating the README.

Final note: I would gladly buy you a beer now that I am able to send PDF's, this wrapper is also cleaner to use than sendgrid-parse in my opinion. So kudos for good work! 👍 :)

Recommend Projects