Comments (6)
Thanks for the info, good to know!
from pyais.
Hey,
thank you for the tip.
I think that you are right and these ints should rather be strings. But I am concerned that changing this would break backwards compatibility. Maybe we should add an option to decide whether one wants a string or an integer?
I am open for discussion.
Greetings
from pyais.
Adding decoding to a string as an option sounds like a good idea to me.
from pyais.
I implemented this feature. From version 1.3.0
on MMSI's are not stored as integers, but as strings with leading zeros. See also #9
from pyais.
It looks to me like this issue (or something similar) is still present in the latest release (v2.7.0). I noticed it and came here to see if it had been reported before.
I wrote a simple script to verify:
import pyais
from pyais.messages import MessageType1
print(f"pyais version: {pyais.__version__}")
# Create message with dummy data and mmsi w/ leading zero as string
msg = MessageType1(msg_type=1, repeat=0, mmsi='012345678', status=0, turn=0.0, speed=0.0, accuracy=False, lon=100, lat=200, course=0, heading=15, second=10, maneuver=0, spare_1=b'\x00', raim=False, radio=18980)
print(f"Message created: {msg}\n")
payload = msg.encode()
# Form AIVDM sentence from encoded payload with dummy data for remaining fields
aivdmStr = "!AIVDM,1,1,,A," + payload[0] + ',' + str(payload[1]) + '*XX'
print(f"Sentence to decode: {aivdmStr}\n")
decoded = pyais.decode(aivdmStr)
print(f"Decoded message: {decoded}\n\nDecoded MMSI: {decoded.mmsi}, Type: {type(decoded.mmsi)}")
When I run this, I get the following output:
pyais version: 2.7.0
Message created: MessageType1(msg_type=1, repeat=0, mmsi='012345678', status=<NavigationStatus.UnderWayUsingEngine: 0>, turn=0.0, speed=0.0, accuracy=False, lon=100, lat=200, course=0, heading=15, second=10, maneuver=0, spare_1=b'\x00', raim=False, radio=18980)
Sentence to decode: !AIVDM,1,1,,A,10;iQCP00079hp1jL>0000ND04`T,0*XX
Decoded message: MessageType1(msg_type=1, repeat=0, mmsi=12345678, status=<NavigationStatus.UnderWayUsingEngine: 0>, turn=0.0, speed=0.0, accuracy=False, lon=100.0, lat=-23.696213, course=0.0, heading=15, second=10, maneuver=<ManeuverIndicator.NotAvailable: 0>, spare_1=b'\x00', raim=False, radio=18980)
Decoded MMSI: 12345678, Type: <class 'int'>
As can be seen in the output, when I originally create the MessageType1 object, the mmsi is stored as a string, but then when I decode it later, as seen in the last line of the output, the MMSI gets decoded as an int and loses its leading zero.
from pyais.
Hey @sethwellsNZ,
This is intentional. We had some back-and-forth regarding the treatment of leading zeros, and ultimately, I decided to store the MMSI as an integer rather than a string. I made this decision because, according to gpsd.gitlab.io — the de facto reference for this implementation — its data type is an unsigned integer. Additionally, this behavior is consistent with many popular applications. For example, MarineTraffic, which is likely one of the largest platforms in this regard, also doesn't show leading zeros. The same goes for Aggsoft, another high-quality AIS decoder.
If you require leading zeros, I recommend using zfill()
.
from pyais.
Related Issues (20)
- Stream from serial/COM port HOT 2
- lat lon converters float accuracy HOT 2
- AtoN codes do not match R0126 (A-126) Table 3 or M.1371-5 TABLE 74 HOT 1
- Provide decoding of communication status field in types 1, 2, 3, 4, 9, 11, 18 HOT 5
- pyais fails to decode type 5 messages HOT 6
- Message Type 26 Logic may be incorrect HOT 2
- MessageType24PartA : incorrect length? HOT 6
- EpfdType Enum Missing InternalGNSS = 15 HOT 2
- Navigational statuses 9, 10, 13 and Ship type 29 HOT 3
- NoneFilter broken HOT 1
- Get Country Code HOT 5
- TCPConnection stops receiving messages HOT 4
- Determination of the communication status field HOT 5
- Encoded NRZI data HOT 1
- Timestamp for message type 1 and others HOT 1
- spare_1 field in MessageType19 converted as bytes HOT 1
- how to apply a filter to a single message HOT 5
- Decode raw payload data HOT 5
- Stream NMEA message with metadata HOT 5
- import SO_REUSEPORT in streams.py fails on Windows HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyais.