Determination of the communication status field about pyais HOT 5 CLOSED

@prefixFelix

I think your root cause analysis is not quite correct.

However, as the com state is only 19 bits long, a bit from the previous data fields is checked here and not one from the com state. In the case of a type 1, 2 or 3 message, it would be checked whether the RAIM flag is set. Since 1 is the default value, pyais returns in almost all cases that it is a SOTDMA com state.

Pyais indeed checks the 20th bit, but there is no overflow because the radio field is an integer (the bit array is not accessed). Thus, is_sotdma is always true for messages of type 1, 2, and 3, as the radio field is always smaller than 0x7ffff (2^19 - 1) for these messages (the radio attribute is forced into 19 bits during decoding).

Your proposed solution is correct nonetheless. 👍

from pyais.

Would you like to take a look at my proposed fix?

-> #137

from pyais.

You're right, I misinterpreted the initial situation.

Your pull request looks logical and correct to me. Thanks for the quick fix.

from pyais.

Nice! I will merge tomorrow and create a new release

from pyais.

The fix is available in version v2.6.5.

from pyais.