The logifix from lyxell

Possible deep rewrite: https://sonarqube.ow2.org/project/issues?id=fr.inria.gforge.spoon%3Aspoon-core&issues=AXBwJ6KLd67NGAIs__yK&open=AXBwJ6KLd67NGAIs__yK

The set of available rules should be reported in CLI

Currently the CLI does not report the set of rules for which fixes exists.

Consider S4143 - Map values should not be replaced unconditionally

https://rules.sonarsource.com/java/RSPEC-4143

Consider S1141 - Try-catch blocks should not be nested

See rewrite result of handler/src/test/java/io/netty/handler/ssl/PemEncodedTest.java in netty/netty

Add more methods to rule for string literal comparison

See https://pmd.github.io/latest/pmd_rules_java_bestpractices.html#literalsfirstincomparisons

Implement automatic indentation

Rule 3824 now works but it needs automatic indentation. This need to be done as a post-processing step outside Datalog as it is not feasible to do it in Datalog.

Consider S1158 - Primitive wrappers should not be instantiated only for "toString" or "compareTo" calls

https://rules.sonarsource.com/java/RSPEC-1158

Consider rule 3626

https://rules.sonarsource.com/java/RSPEC-3626

PMD: https://pmd.github.io/latest/pmd_rules_java_codestyle.html#unnecessaryreturn

Change remote for Soufflé

Soufflé now uses CMake, remote should be updated to use official Soufflé repository

Add logic to recognize immutable classes

https://rules.sonarsource.com/java/type/Bug/RSPEC-2201

Consider S1126 - Return of boolean expressions should not be wrapped into an if-then-else statement

https://rules.sonarsource.com/java/RSPEC-1126

Consider S1450 - Private fields only used as local variables in methods should become local variables

https://rules.sonarsource.com/java/RSPEC-1450

Consider S2639 - Inappropriate regular expressions should not be used

https://rules.sonarsource.com/java/RSPEC-2639

Consider S1643 - Strings should not be concatenated using '+' in a loop

https://rules.sonarsource.com/java/RSPEC-1643

https://sonarqube.ow2.org/project/issues?id=fr.inria.gforge.spoon%3Aspoon-core&issues=AW1cCBplbu-R5OS5-LCy&open=AW1cCBplbu-R5OS5-LCy

Improve highlighting in diffs

It would be nice with better diff highlighting, as seen in e.g. comby https://www.youtube.com/watch?v=JMZLBB_BFNg (03:20)

This could probably be achieved with tokenization and a check between upper and lower lines, no need to involve the AST.

Consider rule 2203

https://rules.sonarsource.com/java/RSPEC-2203

Allow multiple rewrite suggestions

Good example of where it is needed:

https://rules.sonarsource.com/java/type/Bug/RSPEC-1317

Consider S1764 - Identical expressions should not be used on both sides of a binary operator

Consider S3039 - String calls should not go beyond their bounds

https://rules.sonarsource.com/java/RSPEC-3039

Consider rule S1168 - Empty arrays and collections should be returned instead of null

https://rules.sonarsource.com/java/RSPEC-1168

PMD: https://pmd.github.io/latest/pmd_rules_java_errorprone.html#returnemptyarrayratherthannull

Consider S1450 - Private fields only used as local variables in methods should become local variables

https://rules.sonarsource.com/java/RSPEC-1450

Consider rule S4838

https://sonarqube.ow2.org/coding_rules?open=java%3AS4838&rule_key=java%3AS4838

Possible deep rewrite in https://sonarqube.ow2.org/project/issues?id=fr.inria.gforge.spoon%3Aspoon-core&issues=AWtJlSVAbu-R5OS58r2i&open=AWtJlSVAbu-R5OS58r2i

Consider S4087 - close() calls should not be redundant

https://rules.sonarsource.com/java/RSPEC-4087

Add more real world tests for rule 2095

Other

Consider custom cleanup rules

The output of some rewrite rules may sometimes be prettified further.

Examples:

!!x => x
!(x == y) => x != y
System.out.println("") => System.out.println()

Consider rule for unhoisting bang into or-statement

in apache/dubbo dubbo-metadata/dubbo-metadata-processor/src/main/java/org/apache/dubbo/metadata/annotation/processing/util/MemberUtils.java

@@ -42,7 +42,7 @@ import static org.apache.dubbo.metadata.annotation.processing.util.TypeUtils.ofT
 public interface MemberUtils {

     static boolean matches(Element member, ElementKind kind) {
-        return member == null || kind == null ? false : kind.equals(member.getKind());
+        return !(member == null || kind == null) && kind.equals(member.getKind());
     }

     static boolean isPublicNonStatic(Element member) {

could be written

@@ -42,7 +42,7 @@ import static org.apache.dubbo.metadata.annotation.processing.util.TypeUtils.ofT
 public interface MemberUtils {

     static boolean matches(Element member, ElementKind kind) {
-        return member == null || kind == null ? false : kind.equals(member.getKind());
+        return member != null && kind != null && kind.equals(member.getKind());
     }

     static boolean isPublicNonStatic(Element member) {

Consider S2689 - Files opened in append mode should not be used with ObjectOutputStream

https://rules.sonarsource.com/java/type/Bug/RSPEC-2689

Merge inside same branch

Rewrites in the same branch are currently merged together with everything else.
This should be changed so that rewrites in the same branch are merged together, before presented to the user.

Example:

class Test {
    void test() {
        String message = "";
        try {
            String buf = message;
        } catch (Exception e) {
            System.out.println("ok!");
        }
    }
}

lyxell / logifix Goto Github PK

logifix's People

Contributors

Stargazers

Watchers

logifix's Issues

Recommend Projects

Recommend Topics

Recommend Org