lyricwulf / embers Goto Github PK

--- LW: Fixed by using async read

Describe the solution you'd like
getting texture from camera and using that info to crop out the piano using edge detection -- think of Atin's videos

Describe the bug
text seems to be copied from the "background" buttons.

Expected behavior
It to show the correct text.

Screenshots

Describe the bug
After opening the file select screen, clicking outside of it no longer closes it as it did in previous versions.

when you click ESC on the screen, the animation doesn't happen.

after you hit ESC on the screen, ESC looses all functionality and you have to restart the game or play a midi/free play for it to work again

Screenshots
https://i.gyazo.com/024be281473bbb4cac1b4fa08903bbd9.mp4
https://i.gyazo.com/b266be04d8913945cf4e9330dabcbc0b.mp4

Describe the bug
Clicking the return to free play button doesn't work

To Reproduce
Steps to reproduce the behavior:

1. Go to select a midi
2. play a midi file
3. click on return to default/free play mode
4. See error

Expected behavior
This should clear whats selected and return to free play mode and work.

Describe the bug
The keys no longer animate

Screenshots
https://i.gyazo.com/4df0718339ccb14e6945e7cff4896318.mp4

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

No way to select no midi/midi input mode after you select a midi

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to file select menu
2. Click on text that you need to edit earlier in the file path
3. make an edit
4. See issue

Expected behavior
i would not expect it to go to the end of the file path after making one correction

Screenshots
https://i.gyazo.com/05f5c04b4997cc3306494e3f2e89b203.mp4

Additional context
https://i.gyazo.com/a8bee89058de9e3e10b904bb3373a4cd.mp4

Describe the bug
since the animated keys were introduced, the preview on the file select screen doesn't reflect the "key pressed down" state. Don't know if you want it to but it would properly reflect what it will look like in the playback.

Screenshots
If applicable, add screenshots to help explain your problem.

Describe the bug
black keys have some weird shadow above them on the background in 3d mode

Expected behavior
this 'shadow' shouldn't be there

Screenshots
If applicable, add screenshots to help explain your problem.

--- LW: Probably only does this when window is not focused. Video is already set to loop, it is probably out of my control. Please test.
--- Nat: awaiting current build

Describe the bug
When on the file select screen, if you click and hold your curser on the back button and move it off, then your next click is to select a file, both the back button and the ESC key lose all functionality until you start playing a song, and it instantly closes the file select window upon doing this.

https://i.gyazo.com/85c1cb03a1f5f09b795f863b3b2403b6.mp4

To Reproduce
Steps to reproduce the behavior:

1. Go to file select screen
2. Click and hold on Embers and then move your cursor off
3. Click to select a file

Expected behavior
Nothing to stop working and the closing animation for the file select window to function as intended

Describe the bug
The controls listed on the file select screen haven't been updated to reflect the new "keybaord typing" layout, but the current controls no longer work (except ESC. that works).

Expected behavior
The controls to be updated in the list, and functional

Screenshots
If applicable, add screenshots to help explain your problem.

Describe the bug
when you have the file select menu open and move your cursor over the options in the background, it still shines.

To Reproduce
Steps to reproduce the behavior:

1. Go to file select screen
2. Click on background or midi to select a file
3. Scroll down to move mouse cursor over the faded menu in the background
4. See error

Expected behavior
this to not happen

Screenshots
https://i.gyazo.com/9b6d8e1c83bb9c71f52b2c0aaabde091.mp4

might be intentional as those are not released yet, wasn't sure

Is your feature request related to a problem? Please describe.
no

Describe the solution you'd like
It would be cool if the software could save the previously selected folder i was in from the last time i started the program to something like a 'savegame' file. Down the line, with a creator version, this would probably be rather important.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to file select screen
2. select a background
3. click reset to default background
4. See error

Expected behavior
It should switch to default background

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
when you have the file select menu open and move your cursor over the options in the background, it still lags.

To Reproduce
Steps to reproduce the behavior:

1. Go to file select screen
2. Click on background or midi to select a file
3. Scroll down to move mouse cursor over the faded menu in the background
4. See error

Expected behavior
this to not happen

Screenshots
https://i.gyazo.com/9b6d8e1c83bb9c71f52b2c0aaabde091.mp4

Describe the bug
clips and blips in the audio stream during playback, as well as visual lags which slow and speed up the tempo of the audio

To Reproduce
Steps to reproduce the behavior:

1. Listen to a midi in version .4.0
2. listen to the same midi in version .4.1

Expected behavior
The audio should be clear with no faults as well as the visuals.

Screenshots
.4.0: https://drive.google.com/open?id=1NFbPMLNwbqAy61LTPOei8WzvKfPre7t_ (there are a few glitches still here, but compare this to .4.1 and you'll see and hear the difference)
.4.1: https://drive.google.com/open?id=1v-w3DpQoHfGh9sk4JV4pq9eQha2mDmU5

Additional context
unsure exactly what's going on myself, but to the end user, the issue is with the audio, so that's how i'm reporting it

Describe the solution you'd like
To only have to click 'TAB' once instead of 3 times to get to this point, and to be able to click 'ENTER' and it select the file

Additional context
https://gyazo.com/4c0e84ffb6909fdfbfc4d7051d505b4d

Describe the bug
after you select a background and go into midi playback/input mode, then exit and go back to the file select screen, your midi and background are still selected, however the background image categorization has returned to 'default' instead of either re-searching it or displaying the previous results

To Reproduce
Steps to reproduce the behavior:

1. play a song/midi input with a background
2. esc out of it
3. go to file select screen
4. See issue

Expected behavior
either re-searching it or displaying the previous results

Screenshots
https://i.gyazo.com/8789880386cad96f22498853555deb87.mp4

menu screens now lag visually and use a high amount of CPU utilization

Describe the bug
no handler for no response from image categorization

To Reproduce
Steps to reproduce the behavior:
Not every image does this, but i have one that makes it do this.

Expected behavior
something should appear here

Screenshots
If applicable, add screenshots to help explain your problem.

Expected behavior
it should create a note that goes up, as if you were using a midi instrument

Screenshots
https://i.gyazo.com/72c2b10032e77a4825a5c87b495136af.mp4

Describe the bug
The button doesn't work and says the wrong thing

Expected behavior
this should not say default background, but something to do with the default brightness setting and the button should work

Screenshots
If applicable, add screenshots to help explain your problem.

I could be wrong but something here seems different than the rest, either font or theme wise

Describe the bug
clicking the keyboard does not do anything

Expected behavior
it should play the note

this is the brightest setting.

this is the default setting

Describe the bug
Midi playback happens too early and occurs during the title sequence.

(it also might start out of sync, but that could be the midi i chose in the video)

Expected behavior
There should be some delay after the title of the track

Screenshots
https://drive.google.com/open?id=1V0rDLVAAMc-RP0cQXOTUWJ0x4nS_pGTT

Describe the bug
if you type a : in the file path, it will auto make a :/ but then won't allow you to backspace it but highlighting both characters and backspacing works

Expected behavior
i was not expecting the :/ to appear. if it's intentional, that's fine, but it prevented me from backspacing it.

Screenshots
https://i.gyazo.com/417a8633480bc9b151af6eeaed360bf6.mp4

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

--- LW: Fixed using pseudo-orthographic camera

Describe the bug
the notes that are to fall down for a midi file are no longer appearing. The audio for the midis is also not correct. it sounds as if the pedal works sometimes and not others. This wasn't an issue prior to this update. Even without any notes, the GPU utilization is now significantly higher.

To Reproduce
Steps to reproduce the behavior:
Play a midi file

Screenshots
https://drive.google.com/open?id=1hLTTh1HPPNbxk8diZDOsq_jDhciKdRAb