lyonsquark / obsidian-daf-yomi Goto Github PK

Update for tractate Ketubot

The tractate table goes to Nazir. Need to add some more tractates and make guesses on names. Also need to figure out the chapters.

I try to make Megillah 17, but the file appears and then disappears without any error. Very strange! Note that Megillah 17 is a new perek.

My Jewish Learning hasn't published yet, so that one may still not work. See separate issue.

Instead of just a list of links, seprate the links with H2 headers. So the notes can be easily associated with the links.

Done

Adjust URLs for Moed Katan

The Living Greengrass blog link need the date of the daf. I'm getting the wrong dates and so the link doesn't work.

This happens because of

That alters the original object, so that subsequent calls to the dateForDafForLGG function return the wrong answer.

The solution is to do

let dafDate = daf.startDate.clone().add(inPage-1, 'days');

The clone() will copy the object so the subsequent add will not alter the original.

Hi.
I am generating daf yomi notes in the form "Home/Judaism/Nazir/21". Things work fine for a bit, then suddenly the entire Home/Judaism folder gets deleted from Cloud Sync. I'm able to restore the notes, but they disappear again. Any suggestions on what I should do to avoid this?
Thanks
-Amanda

MJL has finally started posting their commentary. The URL component I have is wrong. It should be
rosh-hashanah-

dafyomi.org has an image from the Vilnus Talmud. Not the best quality, but should add it to the list of resources. The URL's are easy...

https://www.dafyomi.org/index.php?masechta=nedarim&daf=84a

Should be using normalizePath when dealing with files in the vault. See https://marcus.se.net/obsidian-plugin-docs/publishing/submission-guidelines for usage.

The Living Greengrass page has the date in the URL (this is unfortunate). Sometimes, the blog post comes out a day late, so it will have a date that does not exactly correspond to the daf date. Maybe figure out a way to try the URL and it get a 404, then advance the date. Of course this won't work if the blog isn't posted yet, but it may work for dafs in the past. Kinda tricky.

The plugin seems to have nagging date problems. This finally came to a head today when I noticed that searching for a daf by the date resulted in the page before the correct page. Must look into this now.

On the Obsidian forum, EdElgar asked that the Hadran commentary be added.

See https://github.com/obsidianmd/obsidian-sample-plugin and make updates accordingly. For example, I think that rollup is no longer used by newer plugins.

Perhaps add a template like thing...

e.g. /Home/Judaism/Daf Yomi/{tractate}/{perek}/{page}

I'll likely do /Home/Judaism/Daf Yomi/{tractate}

See https://marcus.se.net/obsidian-plugin-docs/publishing/release-your-plugin-with-github-actions

Use a dropdown list when choosing the tractate instead of entering by hand

Done

Perhaps have an option to download some or all of the resources to Obsidian for offline reading. This may involve the requestUrl facility and htmlToMarkdown.

Instead of the config in this plugin, use app.vault.getConfig("attachmentFolderPath"). See discord

Prepare for tractate Taanit.

• Add code
• Update documentation

Make the updates for Tractate Nazir

The main.ts function is getting big. Best to refactor into smaller files. Furthermore, the plugin options code is big and has a lot of repetition. Perhaps switch to the Svelte framework.

Done

When the new page is created, open it.