lyndir / omicron Goto Github PK

The method listObservableTiles in basemodule, checks each tile if it is within the viewrange. The performance can be significantly increased simply listing the tiles within a fixed range as follows:

visible = [ ]
for each -N ≤ Δu ≤ N:
    for each max(-N, -Δu-N) ≤ Δy ≤ min(N, -Δu+N)
        Δv = -Δu-Δy
        visible.append(origin + (Δu, Δv) )

Where N is the view range.

Adapted from http://www.redblobgames.com/grids/hexagons/#range

Calling the function GameObject.onModuleElse which is also called from GameObjectController.canObserve is very slow. This function checks 3x if the GameObject tile is observable (so the same check).

Since this an expensive assert could you rework the locations where this assert check is done, as to avoid duplicate work?

Movement returned by MobilityModule#movement always fails because the returned path starts at a tile containing the unit that will move. This causes the path validation to always fail because this tile is not accessible.