luqasz / mcm Goto Github PK

Possible solutions:

class CmdPath(namedtuple('CmdPath', ('absolute', 'type', 'keys', 'modord'))):

        def __hash__(self):
            return hash(self.absolute)

http://benno.id.au/blog/2014/11/30/a-better-namedtuple

Add ability to configure multiple devices at the same time.

Since there are lots of command paths, it will be good to test for duplicates.

attributes such as:
for witch version of software specified rule will apply.
what to do with rules that are not present in config file but are on mikrotik (propositions: disable existing, remove existing, do nothing)
what to do with newly added rules. (mark them as disabled or enabled ?)

add synchronization of files on mikrotik. eg.
hotspot files, images html etc.

Some command paths accept additional print/getall arguments. /interface/wireless accepts advanced=true. This is required to print all possible key,value pairs via api.

CmdPathRow object has a __str__ method witch gives a nice print ready string. It lacks however mappings:

• from False to no
• from True to yes

manage packages and software on mikrotik. define what is suppoused to be installed on specified mikrotik and what is not.

Mikrotik has various menu level types:

• unordered with unique key value (/queue/simple value of 'name')
• unordered with duplicates (/ip/firewall/address-list)
• ordered without unique key value (/ip/firewall/filter, /routing/filter)
• single (/system/ntp/client)
• may depend on packages (dhcp-server,dhcp-client depends on dhcp package)

Properties:

• some have default entries (best would be to disable them if possible)
• some entries are not removable (with default flag, but not necesary)
• some menus have dynamic entries. those will not be managed
• various modification order (ADD,DELETE,SET)
• attribute values may change in routeros releases (/user/group policy=api only in versions 5.x and above)
• some attribute values may be split in order to ease comparison (/user/group policy= split by ',')
• some may need aditional arguments to 'print' (/interface/wireless needs advanced=true to get all attributes)

To check:

• entries that are not default and can not be removed. (/user/group ?)
• entries that are default and can not be disabled (/routing/bfd/interface interface=all)

Provide a dry-run option per program execution (not host). This will only display what may be done (add,set,del), without any modification on a remote device.

Available in verbose mode only.

some entries in mikrotik are predefined and can not be deleted or modified.

eg.
/userg/group
/ppp/profile

something to inform user about changes made on mikrotik by mcm.

if mikrotik sends an error message etc put it in console.

API (and telnet/ssh) only accepts ASCII characters. Program should break configuration run when receiving/sending non ASCII characters.

Provide validation of number of rows for all command path types.

# /system/ntp/client
type = 'single'
rule_number == 1

# /ip/address
type = 'unique'
rule_number >= 0

# /ip/firewall/filter
type = 'ordered'
rule_number  >= 0

Only available in verbose mode.

Before program runs, validate strategy for command paths.

• single may only have exact
• unique may have one of exact,ensure
• ordered may only have one of exact,ensure

This will prevent errors when user provided wrong strategy.

this is specific in mikrotik.
if you specify enabled=true/yes it will work. for comparision use true/false not yes/no. yes/no couses mcm to set for example enabled=yes even when there already is enabled=true

in short true if not the same as yes