Code Monkey home page Code Monkey logo

getdown's People

Contributors

lumue avatar

Stargazers

avatar

Watchers

avatar

Forkers

leo9843 bellmit

getdown's Issues

location resolving for streamcloud urls frequently fails on first try

Log shows this Stacktrace on Exception:

java.util.NoSuchElementException: No value present
    at java.util.Optional.get(Optional.java:135)
    at io.github.lumue.getdown.hosts.streamcloud.StreamcloudPageScraper.scrapePageContentForDownloadUrl(StreamcloudPageScraper.java:35)
    at io.github.lumue.getdown.hosts.streamcloud.StreamcloudContentLocationResolver.resolve(StreamcloudContentLocationResolver.java:39)
    at io.github.lumue.getdown.core.download.job.DownloadJob$AbstractDownloadJob.lambda$resolve$4(DownloadJob.java:298)
    at io.github.lumue.getdown.core.common.util.ObservableTemplate.doObserved(ObservableTemplate.java:35)
    at io.github.lumue.getdown.core.download.job.DownloadJob$AbstractDownloadJob.resolve(DownloadJob.java:286)
    at io.github.lumue.getdown.core.download.job.HttpDownloadJob.run(HttpDownloadJob.java:40)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)

and this is the call which throws the Exception:

Element mediaPlayerScriptElement = mediaPlayerScriptElements.stream()
                .filter(scriptElement ->scriptElement.toString().contains("jwplayer(\"mediaplayer\").setup"))
                .findFirst().get();

NPE when no ContentLocation could be resolved

a proper error state should be set for download. some resolvers should maybe retry?

java.lang.NullPointerException: null
    at java.util.Objects.requireNonNull(Objects.java:203)
    at java.util.Optional.<init>(Optional.java:96)
    at java.util.Optional.of(Optional.java:108)
    at io.github.lumue.getdown.core.download.job.DownloadJob$AbstractDownloadJob.setContentLocation(DownloadJob.java:337)
    at io.github.lumue.getdown.core.download.job.DownloadJob$AbstractDownloadJob.lambda$resolve$4(DownloadJob.java:312)
    at io.github.lumue.getdown.core.download.job.DownloadJob$AbstractDownloadJob$$Lambda$18/998142575.doObserved(Unknown Source)
    at io.github.lumue.getdown.core.common.util.ObservableTemplate.doObserved(ObservableTemplate.java:35)
    at io.github.lumue.getdown.core.download.job.DownloadJob$AbstractDownloadJob.resolve(DownloadJob.java:286)
    at io.github.lumue.getdown.core.download.job.HttpDownloadJob.run(HttpDownloadJob.java:41)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)

npe when trying to resolve url for a second streamcloud download

this occurs if one tries to execute more than on streamcloud download. no matter if parallel or consecutive.

log:

2015-06-20 19:41:13.257 DEBUG 22425 --- [nio-8001-exec-7] i.g.l.g.a.s.w.DownloadJsonRpcController  : download job for http://streamcloud.eu/w7l5g5enduu9/The.Big.Bang.Theory.S08E10.720p.HDTV.X264-DIMENSION.mkv.html added and started
2015-06-20 19:41:13.257 DEBUG 22425 --- [pool-2-thread-2] i.g.l.g.c.d.job.AsyncDownloadJobRunner   : starting download for url http://streamcloud.eu/w7l5g5enduu9/The.Big.Bang.Theory.S08E10.720p.HDTV.X264-DIMENSION.mkv.html
2015-06-20 19:41:13.258 DEBUG 22425 --- [pool-2-thread-2] i.g.l.g.c.download.job.HttpDownloadJob   : start download for url http://streamcloud.eu/w7l5g5enduu9/The.Big.Bang.Theory.S08E10.720p.HDTV.X264-DIMENSION.mkv.html
2015-06-20 19:41:13.264 DEBUG 22425 --- [pool-2-thread-2] i.g.l.g.c.download.job.HttpDownloadJob   : creating ContentLocation for http://streamcloud.eu/w7l5g5enduu9/The.Big.Bang.Theory.S08E10.720p.HDTV.X264-DIMENSION.mkv.html
2015-06-20 19:41:13.264 DEBUG 22425 --- [pool-2-thread-2] .g.c.d.r.ContentLocationResolverRegistry : looking up ContentLocationResolver for streamcloud.eu
2015-06-20 19:41:13.264 DEBUG 22425 --- [pool-2-thread-2] .g.c.d.r.ContentLocationResolverRegistry : returning ContentLocationResolver io.github.lumue.getdown.hosts.streamcloud.StreamcloudContentLocationResolver for streamcloud.eu
2015-06-20 19:41:13.264 DEBUG 22425 --- [pool-2-thread-2] g.h.s.StreamcloudContentLocationResolver : load page at http://streamcloud.eu/w7l5g5enduu9/The.Big.Bang.Theory.S08E10.720p.HDTV.X264-DIMENSION.mkv.html to retrieve session cookie
2015-06-20 19:41:13.264 DEBUG 22425 --- [pool-2-thread-2] g.h.s.StreamcloudContentLocationResolver : 
Sending 'GET' request to URL : http://streamcloud.eu/w7l5g5enduu9/The.Big.Bang.Theory.S08E10.720p.HDTV.X264-DIMENSION.mkv.html
2015-06-20 19:41:18.593 ERROR 22425 --- [pool-2-thread-2] i.g.l.g.c.download.job.HttpDownloadJob   : Error running Job io.github.lumue.getdown.core.download.job.HttpDownloadJob@9573f29c :

java.lang.NullPointerException: no session cookie found in response headers
    at java.util.Objects.requireNonNull(Objects.java:228)
    at io.github.lumue.getdown.hosts.streamcloud.StreamcloudContentLocationResolver.createStreamcloudSessionId(StreamcloudContentLocationResolver.java:105)
    at io.github.lumue.getdown.hosts.streamcloud.StreamcloudContentLocationResolver.resolve(StreamcloudContentLocationResolver.java:78)
    at io.github.lumue.getdown.core.download.job.HttpDownloadJob.createContentLocation(HttpDownloadJob.java:89)
    at io.github.lumue.getdown.core.download.job.HttpDownloadJob.run(HttpDownloadJob.java:42)
    at io.github.lumue.getdown.core.download.job.AsyncDownloadJobRunner$1.run(AsyncDownloadJobRunner.java:45)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)

finished download not properly displayed in ui

when a download finishes, the ui still displays the job with the last download state before the finish event. after a browser reload, the correct state is displayed.
it seems the download finished event does not propagate all the way up to the webclient

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.