So in the case of IE9 for example. If you're using a super simple routing approach like, for example that in: https://github.com/HenrikJoreteg/feather-app

There's a potential issue with getLocalPathname in that it will return a path, despite not actually being able to do a pushState which is what it will attempt to do if there's a matching path.

This made me wonder if perhaps there shouldn't be an option (or maybe even be the default) that if history.pushState doesn't exist, it just always returns null. This would cause internal links to do a full page refresh, which would be slower, but still produce the right result. I don't know if this really matters, however because if pushState fails, the app would still update the view just not update the URL which may be a better fallback???

Do what you will with this, but it was just a thought I figured may be worth raising.

Using zuul and down to IE8

Version 1.7.8 of electron just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As electron is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Sorry to be that guy, feel free to tell me to bug off.

I think this code:

handleClick: function (e) {
        var pathname = links.pathname(e);

        if (pathname) {
            e.preventDefault();
            app.navigate(pathname);
        }
    }

would be a lot more readable if it was:

handleClick: function (e) {
        var pathname = links.getLocalPathname(e);

        if (pathname) {
            e.preventDefault();
            app.navigate(pathname);
        }
    }

The first looks like it will just get the pathname from anything, rather than only returning a pathname if it's local.

I'd suggest re-naming or aliasing these two:

pathname => getLocalPathname
active => isActive (to match isLocal)

If i name the required module localLinks it's better localLinks.pathname() makes more sense. But I think it'd be clearer with the alias.

since local links will be used to determine if click should be handled as if local or not, might be worth checking this too somehow.

Either use a saucelabs badge or just a section saying what browsers are tested.

Version 3.0.1 of tape-run was just published.

This version is covered by your current version range and after updating it in your project the build failed.

tape-run is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Version 1.7.10 of electron was just published.

This version is covered by your current version range and after updating it in your project the build failed.

electron is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I'm using this with React and my responsive/mobile menu doesn't collapse after clicking a page link. It makes sense, since it seems the site refresh restarts the menu back to a collapsed state. I really love the feel this has on desktop, but should I not use this for mobile views?

If there is a way to take care of this through a handler, my apologies; I'm pretty green with coding.