This plugin is a hidden gem. I'd love to continue using it with newer versions of ESLint...

Any chance of an upgrade?

Destructuring is a warning in all parameters.

{
  "rules": {
    "destructuring/in-params": ["warn", { "max-params": 0 }]
  }
}

This doesn't show a warning:

const createConnectMiddleware = <TArgs extends readonly unknown[]>(
  id: string,
  factory: (...args: TArgs) => (req: IncomingMessage, res: ServerResponse, next: (error?: unknown) => void) => void,
  { timeoutSeconds = 3 }: MiddlewareConnectOptions = {},
): MiddlewareFactory<TArgs> => {
  ...
}

This does show a warning:

const createConnectMiddleware = <TArgs extends readonly unknown[]>(
  id: string,
  factory: (...args: TArgs) => (req: IncomingMessage, res: ServerResponse, next: (error?: unknown) => void) => void,
  { timeoutSeconds = 3 }: MiddlewareConnectOptions,
): MiddlewareFactory<TArgs> => {
  ...
}

Difference:

{ timeoutSeconds = 3 }: MiddlewareConnectOptions = {},
{ timeoutSeconds = 3 }: MiddlewareConnectOptions

Lots of info on this rule request here:

• eslint/eslint#7973
• eslint/eslint#7973 (comment)

Quite a few people looking to see this in a plugin. Let me know what you think!

The guide says:

The following patterns are not considered warnings:

/*eslint destructuring/in-params: ["error", { "max-params" : 1}]*/

function t1({a}) {}
function t2(a, b) {
  const {c} = a;
  const {d} = b;
}
const t3 = ({a}) => a;

But this is also valid:

function t3({ a, b, c, d, e}) {}

I would expect to be able to set the maximum number of destructured variables, so that one is forced to rewrite t3 as follows:

function t3(params) {
   const { a, b, c, d, e} = params;
}

This is a common issue with functional React components, where someone starts with a few parameters destructured in the function signature:

const MyReactComponent: FC<MyReactComponentProps> = ({ aProp, orTwo }) => {
   ...
}

Then over time, as different people keep adding features to that component, they put and more props into the function signature that becomes a multi-line monstrosity eventually, without bothering to move the destructuring to a function body.

It would be very handy to have a rule that allows up to a certain number of variables in the destructuting block.

Is there already a way to do it?

Hey Luke!

Are you still supporting the plugin? We're thinking of banning destructuring in class methods I thought of creating a PR rather than creating a new plugin. Please tell me what do you think?

Best,
Dima