lukaszwatroba / v-button Goto Github PK

npm install currently does not work as there is no index.js to export the module.

Though in codepen demo works, in my case the firefox 41.0.1 and IE 11 dont calculate the body scroll correctly returning 0 instead of 1000+
This doesn't happen in Chrome.
I fixed this for me changing the line to :

left = posX - rect.left - ripple.offsetWidth / 2 - window.pageXOffset;
top = posY - rect.top - ripple.offsetHeight / 2 - window.pageYOffset;

Hi I love your package so much.

Can you make option to disabled the button is isBusy?. Because even if its loading user still can press the button multiple times.

Hey man,

Any reason to lock angular version to 1.3 ? I'm using angular 1.4.2

Hi @LukaszWatroba,
I really like your directive. However it has a limit when we use dynamic values for the vBusyLabel attribute and idleLabelHtml. For instance, I use angluar-translate and my code using v-button directive will look like this :

<button class="btn" v-busy="auth.isBusy" v-busy-label="{{'auth.states.signin.signing_in' | translate}}"><span translate>auth.states.signin.signin_button</span></button>

In this case, when I change the translation locale, busyLabelHtml is never updated.
Also, when the button is done being busy, idleLabelHtml returns what was in labelElement.html() (based on code below) which is in this case equal to auth.states.signin.signin_button and not the wanted translated text.

labelElement = angular.element(tElement.find('span'));

...

idleLabelHtml = labelElement.html(),

I already wrote a fix and I will be glad to submit a PR :)

Hi!

I have a problem when using the element inside a directive. In this case, the label "v-busy-label" is not shown, the -element is empty. Outside of the directive everything is working fine.

What could be the problem here?