luk707 / imprest Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 0.0 1.15 MB

React component library

Home Page: https://imprest.dev/

License: MIT License

TypeScript 100.00%

imprest's Introduction

Hi there 👋

My name's Luke. I'm a senior front end engineer currently working @tradingview using React ⚛!

I consider myself a generalist, familliar with many languages including JS, TS, Golang, Python; and I'm currently learning C/C++ & Rust 🦀.

📍 London, GB
🔭 I’m currently working on building a react style reconciller in C++ ⚛
🌱 I’m currently learning C/C++ & Rust
💬 Ask me about anything 😁
📫 How to reach me: @_lukeharris
😄 Pronouns: He / Him
⚡ Fun fact: I love to make music in my spare time and I'm building a modular synthesizer 🎹

Here are some noteworthy projects of mine I encourage you to take a look at:

luk707/games

I'm using this project to tap back into graphics programming (which is how I taught myself to code when I was 13 🐥), and, to continue learning C++ and Bazel.

luk707/rehype-truncate

This project is a plugin for rehype which allows you to truncate strings of HTML whilst preserving the structure. It's useful to generate rich excerpts for blogs & documentation and has more than a few dependents now 📈.

luk707/envup

Envup is a project I worked on a few years ago to solve working with environment variables as a team. It reads from a env.json file in the present working directory, and prompts the user to populate their .env files. This is version controllable too!

luk707/ScientificCalculator

This little project helped me learn more about how lexer's and parser's work. The only input is a string of the mathematical expression, this program tokenises the string, and executes the expression while respecting the order of operations!

luk707/Practice-Project

This was a project submitted to a hackathon I built in a team of four. I built tools to load and render 3D models from blender using WebGL with no external libraries other than Angular for the user interface while my team members built on top of this to make a clone of the mobile game Stack.

imprest's People

Contributors

Stargazers

Watchers

imprest's Issues

Create a CardGrid component

Describe the solution you'd like
A new molecule level component titled CardGrid.

<CardGrid
    feature={<FeatureArticleCard {...} />}
>
    <ArticleCard {...} />
    <ArticleCard {...} />
    <ArticleCard {...} />
</CardGrid>

Additional context
For the light theme, the CardGrid should look something like this:

Fix typo of createComponment util function

Should be named createComponent

Add test coverage across the project

Is your feature request related to a problem? Please describe.
There are a few methods in the project I’m not entirely confident in their implementation, specifically for edge cases.

Describe the solution you'd like
Adding test coverage, with Jest or Ava would eliminate these worries, and also help improve the overall quality of the codebase.

Additional context
Solution must be TypeScript compatible, and ideally support a common reporting interface so that coverage badges can be added to the README. This may also be an ideal opportunity to take a look at Drone CI.

Build command should emit typings

Is your feature request related to a problem? Please describe.
No typings files are emitted as an effect of running the build script. When installing Imprest inside of another typescript project there is subsequently no typing information available.

Describe the solution you'd like
The typescript CLI has a flag called --emitDeclarationOnly. This should be run as part of the build script to generate typings artefacts alongside the transpiled files inside of the lib directory.

Describe alternatives you've considered
Something more integrated with the babel command would have been nice but this does not exist.

Create an Input component

Describe the solution you'd like
A new component titled Input that applies styles to the host input component. It should contain styled for the focused state & disabled state too.

Additional context
For the light theme, the input should look something like this:

CodeBlock line numbers should not be implemented using a before pseudo element.

The use of a before pseudo element means that a unique class is generated for every line of code. This could be simplified by simply rendering an actual DOM element that is not user selectable.

_{Sent with GitHawk}

Typography level components to be made

Some low level components should be created to ensure typographic consistency is held throughout a project of given themes. These should probably not be a 1:1 mapping with the HTML elements, but instead a high level language to convey the presentation for text, with a prop that allows the host component to be specified.

<>
  <Heading el="h2">Hello world</Heading>
  <Subheading el="h3">Typography is cool!</Subheading>
</>

Create a Card component

Describe the solution you'd like
A new component titled Card that applies styles to the host div component. It should extend the default div props with all of the box style props to allow the user to make use of it's spacing shorthands.

Additional context
For the light theme, this is how a Card should look