Windows build fails with return type inference failure. about luisacompute HOT 4 CLOSED

I just realized u64.h lives under the src\utils\ subdirectory of the main renderer, not the compute sub-project, so it might be namespace leakage like the other issue I filed a few weeks ago after all. You might want to move this bug over there if possible.

from luisacompute.

Hi @NeedsMoar

I'm not sure if this is a compiler bug or if it's because I have some ill-formed use of the C++ language (TBH, it's too hard to learn all the C++ syntax and rules). Anyways, explicitly specifying the return type as luisa::compute::Bool should be the most straightforward fix and I'll merge it into the LuisaRender repo. Many thanks for your investigation!

Allows it to build, but just changing the return to bool doesn't; it then starts thinking the "rhs" parameter is in error, saying that no suitable conversion from bool to luisa::Compute::Var exists. These operators should all be returning bool so something weird is happening.

The plain bool type is expected not to work because the operations on shader variables (i.e., the Var<T> or Expr<T> objects) cannot be converted back to the native C++ values of type bool.

Also, we'll eventually remove the u64.h util header. Earlier it was for emulated 64-bit integer computation with two 32-bit integers but now we have extended LuisaCompute's type system with direct support for 64-bit integers. So the emulation is no longer necessary.

from luisacompute.

I have removed the outdated U64 implementation from LuisaRender.

from luisacompute.

Thought I closed this, but the initial hotfix was working so I will now.

from luisacompute.