Code Monkey home page Code Monkey logo

afb_instant_articles's People

Contributors

abdusfauzi avatar apermo avatar fabianpimminger avatar fvmartin avatar jacksonlessa avatar jenswiese80 avatar luehrsen avatar samburgers avatar tobaco avatar vheinrich avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

afb_instant_articles's Issues

Frage: Direct sold ads

Ich würde gerne meine eigenen Anzeigen in den instant articles anzeigen

plant ihr direct sold ads auch zu integrieren?

alles liebe

johanens

Post Content garbled up, encoding error?

First of all, thank you very much for this easy-to-use plugin.
The only drawback is that, my post content, rendered in the feed generated by the plugin, is garbled up like this è¿�æ�¥ï¼�广西æ�³å·�é£�é , you can view it here>> http://goo.gl/K3IJF1

Anything in between < p > & < / p > has this error. But, my original wordpress feed is alright, my original wp feed here>> http://goo.gl/uY9cTO

Your advice/fix is very much appreciated! Thank you in advance!

Question: Editing core plugin on format_content

Hi, I'm not an expert in php or wordpress, so i'll try to explain myself as clear as possible.
While using your plugin we (my team and me) have found certain things doesn't work, like the Regex in pictures, the regex ask for a <p> but many paragraph items has <p class="" >, so, we change for <p.*?> which works well, but theres also <a rel=\"attachment, in our case we don't have rel in any <a element, so we changed for <a href=\"attachment, but our problems are bigger.
We tried to format certain things such as many tag closing errors like <p><em><a><img></em></a></p>.
This kind of sintax returns multiple errors on FB feed where are taken as empty html elements or sintax errors, everything are displayed but text.
Some things we've done worked but the most (executing functions defined by user) doesn't.
Are you planning a new release or update?
Greetings.

VG Wort Zählpixel

Leider wir der VG Wort Zählpixel nicht mit ausgespielt. Das ist aber eine eher knifflige Sache.

Issues When Publishing On Facebook

What did you expect to happen? Wanted feed to be approved by Facebook

What happened instead? Got the following feedback:

Please remove the low resolution images found in the Instant Articles.

How can we reproduce this behavior?

Can you provide a link to a page which shows this issue?

Technical info

  • WordPress version:
  • allfacebook Instant Articles version:

HTML in <li>

Thats an error, not only a warning. Facebook doesnt like mixed plain and HTML inside


  • allfacebook_de_settings

  • Test-Integration

    I think it is probably a good idea to integrate some testing for this plugin.

    Does anyone have experience in setting up tests with travis-ci.com?

    Textdomain is missing

    Language Files are prepared, but translation does not show up.

    From what I see, the load_plugin_textdomain() Function is missing. Tried to fix it, but didnt work.

    Technical info

    • WordPress version: 4.5.2
    • allfacebook Instant Articles version: 0.7.0

    Should we restructure this repo?

    Shouldn't we change the structure of this repo to make it more accessible and easy to use? I believe that the /build /trunk /tags structure is to be compatible with the Wordpress Plugin Directory SVN?

    Maybe swith to a workflow like this or this?

    The duplicate code in the git repo isn't really nice to use and there are already a few inconsistencies in the repo where the associated update in the trunk isn't commited.

    What do you think?

    Tabellen

    What did you expect to happen?

    Vernünftige Darstellung von Tabellen

    What happened instead?

    Es werden nur teilweise Inhalte angezeigt, obwohl Facebook die Tabelle komplett übernimmt

    How can we reproduce this behavior?

    Artikel mit Tabelle

    Can you provide a link to a page which shows this issue?
    Ich habe das Problem mit einem eigenen Filter gelöst, daher gibt es keinen Link von mir mit dem Problem. Gelöst wurde das Problem durch:
    $content = str_replace('<table>', '<figure class="op-interactive"><iframe><table border="1">', $content); $content = str_replace('</table>', '</table></iframe></figure>', $content);

    Technical info

    • WordPress version: 4.53
    • allfacebook Instant Articles version: 0.7.3

    Question: Regarding the kicker and subtitle.

    Facebook refused my submission and came back with the following Please move the text found in the kicker element to the subtitle. The kicker element should be used to categorize the Instant Article:"

    Any ideas on how I can resolve this please?

    Technical info

    • WordPress version: 4.5.3
    • allfacebook Instant Articles version: 0.8.2

    Feature Request: YouTube Link play support

    Hello, First of all, thank you very much for creating this plugin. I tried using official plugin first but it has many issues including no images/GIFs under the content was visible. Your plugin solved all those issues in very simple yet effective manner.

    Now the issue, The youtube link inserted under post content ( not embedded as on WordPress site , If we simply paste a YouTube link, it becomes playable by default ) is not working. It displays as bare text, even not a hyperlink. Please add support for YouTube video linking.
    I also use "Lazy Video Loader" plugin for youtube videos. Do you think these scripts will work on Facebook Instant Articles page?

    Thank you.

    Feature request - IA Styles

    The Facebook backend allows to create new styles for IA formating. However, if not specified the "default" Style is used.
    Would be cool to have a general- or article based setting what style should be used.

    No Links in Credits

    What did you expect to happen?

    Clickable Link in credits

    What happened instead?

    Link not clickable

    How can we reproduce this behavior?

    enter a link in credits

    Can you provide a link to a page which shows this issue?

    Technical info

    • WordPress version:
    • allfacebook Instant Articles version: 0.8.0

    The wp_kses_post should allow an ''

    Version number does not conform to semantic versioning (X.Y.Z), npm install not working

    Hi guys,

    npm install isn't working in the latest versions of the code base because of four components/integers in the version number.

    Output:

    npm WARN Invalid version: "0.5.6.2"
    npm WARN afb_instant_articles No description
    npm WARN afb_instant_articles No repository field.
    npm WARN afb_instant_articles No README data
    npm WARN afb_instant_articles No license field.
    

    After changing the version number to 0.5.7 npm install works. So I would suggest that this project should use semantic versioning.

    DOMDocument Warning

    Provide an error/warning and prevent the filters from initializing, when DOMDocument is missing.

    Image and Video Handling are facing issues.

    Loving this plugin, you guys have built an amazing tool for Facebook Instant. I am noticing a little issue though. Some of the images and videos are not transferring over to the instant version.

    If you look at this post:

    http://www.cgmagonline.com/reviews/wonder-woman-earth-one-graphic-novel-comic-review-dc-universe/

    the images that are aligned left and right are not working

    and on this post:
    http://www.cgmagonline.com/2016/04/29/cgm-plays-ruiner-pc-devolver-digital/

    it is not pulling in the video.

    I am open to ideas on how I need to adjust my theme to fix it, or if I need to add something to ensure it pulls all that in.

    Thanks for any help!

    Organize the help tabs

    I would love to organize the plugin help in the official WordPress way as seen here:

    bildschirmfoto 2016-07-28 um 15 18 00

    For that I need some help of actually organizing the help text and content. The implementation is a matter of minutes.

    @jenswiese80?

    Fatal error on Activation

    Hi

    Saw great reviews on the projects and thought I would give it a go and got this when trying to activate

    Fatal error: Can't use function return value in write context in D:\Spotted in Ely Website\wp-content\plugins\allfacebook-instant-articles\inc\lhafb_ia.filters.php on line 232

    As far as I can tell, line 232 reads: if(!isset($childNode->wholeText) || empty(trim($childNode->wholeText,chr(0xC2).chr(0xA0))) ){

    Add new option: Include/Exclude by default

    Wondering if possible to add a setting to choose whether to Include OR Exclude posts in the feed by default. I imagine this could just dictate if the meta box on post-edit is checked or unchecked by default.

    many thanks!

    custom post types support

    Hi guys,

    I just decide to use your plugin in prod because from some points of view is better than the one from pagefrog (discontinued anyway).

    Their plugin offered me options to add in Instant Article feed the custom post types too.

    Are there any chances to have this option on your plugin too? How can I enable it?

    Also will be handy to display plugin version on its dedicated page in admin dashboard.

    thanks!

    Technical info

    • WordPress version: 4.6
    • allfacebook Instant Articles version: 0.8.2

    Post with multi embeds / images get's messy

    Hi!

    Doing another test round today I noted a specific post of my blog that got really messy inside the Instant Articles / RSS

    The post specifically have a text part and then a video from Youtube then 3 animated gifs in a row, each one in a paragraph as it's the way Wordpress write the HTML.

    This is the post: http://jogazera.com.br/inside-chega-hoje-ao-xbox-one/

    But when looking into the Instant Article / RSS, the code is really messy and only one of the animated gifs is properlly converted / showing, everything else and the video are just lost as the plugin is not wrapping up all the embeds inside a <figure class="op-interactive"><iframe> element.

    Here is the generated code on the RSS:

    <p><a href="http://jogazera.com.br/conheca-inside-proximo-jogo-dos-criadores-de-limbo/">Clique aqui</a> e saiba mais sobre o jogo, ou confira o trailer abaixo:</p>
    <figure class="op-interactive"><iframe></iframe></figure><img class="aligncenter" src="http://playdead.com/css/img/inside/gifs/gif1.gif" width="800" height="410">
    <p><img class="aligncenter" src="http://playdead.com/css/img/inside/gifs/gif2.gif" width="800" height="410"></p>
    <img class="aligncenter" src="http://playdead.com/css/img/inside/gifs/gif5.gif" width="800" height="410">
    </span>
    

    And the original RSS: http://jogazera.com.br/?feed=instant_articles

    Hope it helps you get this fixed.

    Thanks!

    Technical info

    • WordPress version:4.5.3-pt_BR
    • allfacebook Instant Articles version: 0.7.3

    The plugin not include the subtitle in the feed

    What did you expect to happen?

    That the subtitles are included in the feed

    What happened instead?

    Not included

    How can we reproduce this behavior?

    Install Subtitle 360 plugin to include subtitles in the posts.
    I customize the plugin to change to H2 the subtitle.
    Check the IA feed.

    Can you provide a link to a page which shows this issue?

    Technical info

    • WordPress version: 4.6.1
    • allfacebook Instant Articles version: 0.8.2

    Duplicate "op-ad-default" class in Audience Network

    Hello guys, we are using this amazing plugin in a couple of sites but after the recent update we started to receive warning in production articles

    screen shot 2016-09-21 at 8 12 51 pm

    It seems that the css class "op-ad-default" is applying to all Audience Network Placements and facebook is complaining about it. While the manual fix is trivial (removing the extra classes) it would be nice for the plugin to generate articles conforming this guideline (only one with default class)

    Also I noticed that someone is getting the same message in the wordpress support plugin forum

    https://wordpress.org/support/topic/problem-with-the-ads-all-of-them-have-op-ad-default-in-the-class/

    Anyway I can help?

    Technical info

    • WordPress version: 4.6.1
    • allfacebook Instant Articles version: 0.8.3

    Instagram embeds not wrapped in op-social tags

    Hi, check out this post

    https://picnic.ly/2016/05/cool-accessories-igshop/

    It has a bunch of images that are not Instagram embeds and then a bunch of Instagram embeds. The non-IG images show up in the Instant Article, but the Instagram posts just don't show up.

    I put the code from the WordPress editor here

    http://pastebin.com/35DfUWWR

    The converted Instant Article HTML with errors from the Facebook backend is here

    http://pastebin.com/9fUPaCTC

    Here's a screenshot showing some of the above HTML, this might be easier to read though as it has FB's syntax coloring going for it

    http://imgur.com/2CnYmE9

    Thanks!

    Technical info

    • WordPress version: 4.5.2
    • allfacebook Instant Articles version:

    The plugin include shortcodes results in the feed...

    What did you expect to happen?

    That the shortcodes are not include in feed.

    What happened instead?

    The shortcodes are include in feed.

    How can we reproduce this behavior?

    I use Insert Pages plugin shortcode to include related inline news
    in the post.

    Can you provide a link to a page which shows this issue?

    Technical info

    • WordPress version: 4.6.1
    • allfacebook Instant Articles version: 0.8.2

    Doesn't transform FB embeds correctly

    What did you expect to happen?

    Transform correctly FB embeds from the post into op-interactive.

    What happened instead?

    Ended up with the embed's code within <iframe class="oembed">. So I added manually facebook.com url into embeds.php in the plugin directory within $provider_name so I at least got it correctly within

    tag but instead of fb-post I get oembed for fb-page or something, see here:

    <figure class="op-interactive"><iframe>
    <div class="oembed oembed-rich oembed-facebook-com oembed-rich-facebook-com">
    <div id="fb-root"></div>
    <script>(function(d, s, id) {  var js, fjs = d.getElementsByTagName(s)[0];  if (d.getElementById(id)) return;  js = d.createElement(s); js.id = id;  js.src = "//connect.facebook.net/en_US/sdk.js#xfbml=1&version=v2.3";  fjs.parentNode.insertBefore(js, fjs);}(document, 'script', 'facebook-jssdk'));</script><div class="fb-page" data-href="https://www.facebook.com/WordPresscom/posts/10154113693553980/" data-small-header="" data-adapt-container-width="1" data-hide-cover="" data-show-facepile="1" data-show-posts="1" data-width="640" data-height="640">
    <blockquote cite="https://www.facebook.com/WordPresscom/posts/10154113693553980/" class="fb-xfbml-parse-ignore"><a href="https://www.facebook.com/WordPresscom/posts/10154113693553980/">WordPress.com</a></blockquote>
    </div>
    </div>
    </iframe></figure>
    

    How can we reproduce this behavior?

    Try generating IA while having FB embeds in the post.

    Can you provide a link to a page which shows this issue?

    Not at this point.

    Technical info

    • WordPress version: 4.5.4
    • allfacebook Instant Articles version: 0.8.1

    klickbare pics

    hallo jens

    ist es möglich bilder in den instant articles "klickbar" zu machen?

    oder gibt es nur die möglich darunter einen link zu machen

    Content Caching?

    I'm having an issue with posts where the author embedded many (> 20) social media oembeds. Then feed generation is taking over one minute (even with a very performant server). I guess wordpress is requesting the embeds from the 3rd party service every time the feed is generated?

    The problem is: Facebook has a timeout in place after 60 seconds and the ingestion of the feed stops. (see: Bug)

    What do you think about caching the article content via wordpress transients (as done in the "official" Automattic plugin )?

    Anzeigen

    Wann glaubt ihr, dass die Anzeigen funktionieren werden, würde gerne meine eignen anzeigen einbauen

    danke alles liebe

    johannes

    Tag <a> being stripped out completelly with the text

    Hi

    I'm testing this plugin with my WP site and I noted that one of my recent post had 3 links inside the text completely stripped out when converted to Instant article (the link AND the text was removed on the RSS)

    So I checked the HTML code on the original post, here is the html:

    <p>No intuito de trazer sempre coisas legais para quem nos acompanha, fechamos uma parceria entre o <a href="http://jogazera.com.br/">Jogazera</a> e a <strong><a href="http://www.nuuvem.com/" onclick="__gaTracker('send', 'event', 'outbound-article', 'http://www.nuuvem.com/', 'Nuuvem');">Nuuvem</a></strong>&nbsp;para você ganhar&nbsp;<strong>10% de desconto em qualquer jogo</strong>&nbsp;no site!</p>

    At first i tought it was caused by the "onclick" attribute one of the links have but the other one that doesn't have it was also stripped out of the RSS.

    Can you provide a link to a page which shows this issue?

    Here is the original post: http://jogazera.com.br/ganhe-10-de-desconto-em-qualquer-jogo-na-nuuvem/

    Looking into other articles I noted that sometimes the a href get stripped and sometimes doesn't, even on the same article.
    Heres another one: http://jogazera.com.br/resident-evil-7-sera-em-primeira-pessoa-e-nao-tera-quick-time-events/

    On this one, the first 2 links (red) are not presented on the RSS, but the last one (VG247) is.

    Here is my RSS: http://jogazera.com.br/?feed=instant_articles

    Technical info

    • WordPress version:4.5.3-pt_br
    • allfacebook Instant Articles version: 0.7.2

    I hope this report helps to look and fix this issue.

    Thanks

    Intention behind apply_filter("the_content", ..) for cover image caption, image captions and credits?

    What's the intention behind applying the the_content filter to the cover image caption and the credits in the footer?

    I'm asking because I've ran into a problem with a plugin which adds content after each blogpost via the the_content function. And when using afb_instant_articles this content also gets added to each cover image caption, each image caption and the credits section. As far as I know, quite a few plugins are using "the_content" filter to add text and content to the bottom of blog posts e.g. [the_content()](https://developer.wordpress.org/reference/functions/the_content/). That's what this filter is about.

    If this is for properly escaping the output, we should use wp_kses_post()?

    Recommend Projects

    • React photo React

      A declarative, efficient, and flexible JavaScript library for building user interfaces.

    • Vue.js photo Vue.js

      🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

    • Typescript photo Typescript

      TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

    • TensorFlow photo TensorFlow

      An Open Source Machine Learning Framework for Everyone

    • Django photo Django

      The Web framework for perfectionists with deadlines.

    • D3 photo D3

      Bring data to life with SVG, Canvas and HTML. 📊📈🎉

    Recommend Topics

    • javascript

      JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

    • web

      Some thing interesting about web. New door for the world.

    • server

      A server is a program made to process requests and deliver data to clients.

    • Machine learning

      Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

    • Game

      Some thing interesting about game, make everyone happy.

    Recommend Org

    • Facebook photo Facebook

      We are working to build community through open source technology. NB: members must have two-factor auth.

    • Microsoft photo Microsoft

      Open source projects and samples from Microsoft.

    • Google photo Google

      Google ❤️ Open Source for everyone.

    • D3 photo D3

      Data-Driven Documents codes.