Code Monkey home page Code Monkey logo

html2lucky's People

Contributors

dependabot[bot] avatar edwardloveall avatar paulcsmith avatar yjukaku avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar

Forkers

robbyoconnor thoran

html2lucky's Issues

Proper img format

Hello, and thanks for your work on this project.

I have a found a bug when using this site. Here are the details:

The minimal amount of HTML input that triggers the bug

<img src="logo.png">

What I expected to be output when inputting the minimal HTML above

img src: "logo.png"

What is actually output by the site

img "" src: "logo.png"

I will wait patiently as you work on this free project in your precious spare time. Thank you again!

ERR_BLOCKED_BY_XSS_AUDITOR

Hi @yjukaku ,this is a nice tool! 👍

I found an issue when I was trying to use it:

screenshot_20180406_131152

Seems my browser is blocking the execution of some scripts 😅

Comma following para tags

It seems like single line paragraph tags always put a comma following the para. Here is a reproducable sample:

<p>Hello</p>
<p>
    Hello world
    hi there
</p>

outputs

para, "Hello"
para do
  text " Hello world hi there "
end

Dockerfile optimizations

This exists as a means to discuss #14

Largely things remain semantically the same, but just better practice.

  1. Move stuff that won't change to the top
  2. Remove packages that exist in the base image already

Use tag for SPA type tags

Hello, and thanks for your work on this project.

I have a found a bug when using this site. Here are the details:

The minimal amount of HTML input that triggers the bug

<h3 class="sort-label">
      <font-awesome-icon icon="sort"></font-awesome-icon>
      Sort Options
</h3>

What I expected to be output when inputting the minimal HTML above

h3 class: "sort-lable" do
  tag("font-awesome-icon", icon: "sort")
  text "Sort Options"
end

What is actually output by the site

h3 class: "sort-label" do
    font-awesome-icon "" icon: "sort"
    text " Sort Options "
end

I will wait patiently as you work on this free project in your precious spare time. Thank you again!

Leading space before an inner tag should be ignored.

Hello, and thanks for your work on this project.

I have a found a bug when using this site. Here are the details:

The minimal amount of HTML input that triggers the bug

<div> <a>Hello</a> </div>

What I expected to be output when inputting the minimal HTML above

div do
  a "Hello"
end

What is actually output by the site

div do
  text " "
  a "Hello"
  text " "
end

I will wait patiently as you work on this free project in your precious spare time. Thank you again!

<p> tags don't render correctly

Hello, and thanks for your work on this project.

I have a found a bug when using this site. Here are the details:

The minimal amount of HTML input that triggers the bug

<p>test</p>

What I expected to be output when inputting the minimal HTML above

para, "test"

What is actually output by the site

para "test"

I will wait patiently as you work on this free project in your precious spare time. Thank you again!

Don't use text for double line break

Hello, and thanks for your work on this project.

I have a found a bug when using this site. Here are the details:

The minimal amount of HTML input that triggers the bug

<h1>Hi</h1>

<h2>Lucky</h2>

What I expected to be output when inputting the minimal HTML above

h1 "Hi"
h2 "Lucky"

What is actually output by the site

h1 "Hi"
text " "
h2 "Lucky"

I will wait patiently as you work on this free project in your precious spare time. Thank you again!

Get it deployable to Heroku

Right now, it's not deployable because Heroku complains that it's not compiling. Figure this out and get it up on Heroku!

remote: 
remote: -----> Node.js app detected
remote: 
remote: -----> Creating runtime environment
remote:        
remote:        NPM_CONFIG_LOGLEVEL=error
remote:        NPM_CONFIG_PRODUCTION=true
remote:        NODE_VERBOSE=false
remote:        NODE_ENV=production
remote:        NODE_MODULES_CACHE=true
remote: 
remote: -----> Installing binaries
remote:        engines.node (package.json):  unspecified
remote:        engines.npm (package.json):   unspecified (use default)
remote:        engines.yarn (package.json):  unspecified (use default)
remote:        
remote:        Resolving node version 8.x...
remote:        Downloading and installing node 8.9.4...
remote:        Using default npm version: 5.6.0
remote:        Resolving yarn version 1.x...
remote:        Downloading and installing yarn (1.4.0)...
remote:        Installed yarn 1.4.0
remote: 
remote: -----> Restoring cache
remote:        Skipping cache restore (not-found)
remote: 
remote: -----> Building dependencies
remote:        Installing node modules (yarn.lock)
remote:        yarn install v1.4.0
remote:        [1/4] Resolving packages...
remote:        [2/4] Fetching packages...
remote:        info [email protected]: The platform "linux" is incompatible with this module.
remote:        info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
remote:        [3/4] Linking dependencies...
remote:        warning " > [email protected]" has unmet peer dependency "caniuse-lite@^1.0.30000697".
remote:        [4/4] Building fresh packages...
remote:        Done in 29.22s.
remote:        Running heroku-postbuild (yarn)
remote:        yarn run v1.4.0
remote:        $ bin/compile_assets build --production
remote:        $ /tmp/build_828a625f7d0d4eacb02bcc7df3ec3d49/node_modules/.bin/brunch build --production
remote:        02:49:56 - info: compiled 6 files into 2 files in 2.3 sec
remote:        Done in 2.96s.
remote: 
remote: -----> Caching build
remote:        Clearing previous node cache
remote:        Saving 2 cacheDirectories (default):
remote:        - node_modules
remote:        - bower_components (nothing to cache)
remote: 
remote: -----> Build succeeded!
remote:  !     Unmet dependencies don't fail yarn install but may cause runtime issues
remote:        https://github.com/npm/npm/issues/7494
remote: 
remote: -----> Crystal app detected
remote: -----> Installing Crystal (0.24.1 due to .crystal-version file) from  to /tmp/build_828a625f7d0d4eacb02bcc7df3ec3d49/.heroku/crystal... curl: no URL specified!
remote: curl: try 'curl --help' or 'curl --manual' for more information
remote: 
remote: gzip: stdin: unexpected end of file
remote: tar: Child returned status 1
remote: tar: Error is not recoverable: exiting now
remote:  !     Push rejected, failed to compile Crystal app.
remote: 
remote:  !     Push failed
remote: Verifying deploy...
remote: 
remote: !	Push rejected to html2lucky.
remote: 
To https://git.heroku.com/html2lucky.git
 ! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'https://git.heroku.com/html2lucky.git'

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.