Code Monkey home page Code Monkey logo

php-ixr's People

Contributors

amsross avatar edalzell avatar lsmonki avatar mfn avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

php-ixr's Issues

Packagist

This is more of a question than an issue...

Why don't you submit this to packagist?

Deprecated constructor

I get this error in php7

[2016-05-14 21:44:44] dev.ERROR: ErrorException: Methods with the same name as their class will not be constructors in a future version of PHP; IXR_Value has a deprecated constructor in /Users/erin/Sites/dl/statamic/vendor/lsmonki/php-ixr/IXR_Library.php:48

CA certificate without client certificate

I want to use IXR_ClientSSL for sending XML-RPC requests to another server over HTTPS without using a client certificate. This is currently not possible, because IXR_ClientSSL::query() both requires a client and a CA certificate. If no client certificate is set (IXR_ClientSSL::setCertificate()), then setting the CA certificate is skipped, which results in a connection error "unable to get local issuer certificate".

I just want to set the CA certificate to verify the server without using a client certificiate, so I think the lines:

if ($this->_caFile === false) {
    // Don't verify their certificate, as we don't have a CA to verify against
    curl_setopt($curl, CURLOPT_SSL_VERIFYHOST, 0);
} else {
    // Verify against a CA
     curl_setopt($curl, CURLOPT_CAINFO, $this->_caFile);
}

should be independent from the block "if (!($this->_certFile === false)) {"

Is this correct?

Edit: I think the following line should be added in addition to CURLOPT_SSL_VERIFYHOST to disable server certificate checks if no CA certificate is given:

curl_setopt($curl, CURLOPT_SSL_VERIFYPEER, 0);

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.