lowlighter / gracidea Goto Github PK

Summary

Following #64 water tiles were removed for now, but needs to be enabled again

Impacted components

📀 app: client

Impacted regions

No response

Community guidelines

• I am not duplicating an existing issue, pull request or discussion
• I have read contribution guidelines
• I agree to follow the Code of Conduct

Describe the changes you'd like

The following integrity checks should be added on map.json to ensure that convention are correctly applied.

Tiles

• Check that sea tile is never used
• Check tiles are on correct layers
• Check that only the first frame of animated tiles is used

Areas

• Check that both name and type are set to polygonal areas
• Check that polygonal areas are on correct layers
• Check that polygonal areas are not too complex (based on the number of points)

Locations

• Check that for each Pokémon center tile a location has been created

Maps

• Map has been exported to .json after being edited

Meta

• Generate diff for textures images on PR
• Implement the usage of branched map.json (instead of the master one) with colored diff to detect what has been changed

What should be revised ?
It would be cool to support the alternate form spawn one day :

• Male/Female Pokémons spawn
• Alternate forms (minior, etc.)
• Castform based on meteo
• Procedural spinda (https://msikma.github.io/spinda-spots/ )

Is your feature request related to a problem ?
Currently, only coordinates are displayed but it would be cool to display the city/road/chenal we're seeing.

Describe the solution you'd like
Maybe we'll create a new polygon layers which indicates in which area we're currently located.

Describe alternatives you've considered
Additionally, we could use it in integrity checks to identify chunks in botlighter's report

Additional context

Describe the bug
The map is very lagy to move around, especialy when you still have water turned on.

To Reproduce
Steps to reproduce the behavior:
Just open the map and move around a bit.

Expected behavior
Have the map run a bit smoother/ faster, preferably also when water is turned on

Screenshots
uhm, dont know what to show

Platforms impacted

• OS: Windows
• Browser brave browser, chrome and chrome beta
• Version current version, don't know wich one that then is
• Device: Windows Lenovo laptop

Currently the teleportation occurs at map origin, rather than a designated point such as a pkmn center or entrance

Suggested solution:

• Define a "teleportation point" via tiled through a special tile
• Extract it and update teleportation location

Something like this:

{
  try {
    const {data:{search:{nodes:[{number:pr}]}}} = await fetch("https://api.github.com/graphql", {
      method:"POST",
      headers:{
        Authorization: `bearer ${Deno.env.get("GITHUB_TOKEN")}`
      },
      body:JSON.stringify({
        query:`query {
          search(query: "repo:lowlighter/gracidea is:pr is:open hash:${Deno.env.get("VERCEL_GIT_COMMIT_SHA")}", type: ISSUE, first: 10) {
            nodes {
              ... on PullRequest {
                number
              }
            }
          }
        }`
      })
    }).then(response => response.json())
  }
  catch (error) {
    log.warn(`failed to get pull request: ${error.message}`)
  }
}

Game locations

• Sootopolis City
• Ever Grande City
• Sky pillar

Game locations (others)

• Gnarled Den
• Nameless Cavern
• Pathless Plain
• Trackless Forest
• Southern island
• Birth Island
• Faraway Island
• Navel Rock
• Battle Frontier
• Battle Resort
• Mirage spots (ref.)

Manga locations

• Meteor village

Anime locations (mainland)

• Banana Slakoth Garden
• Forina
• LaRousse City
• North Petalburg
• Rubello Town
• South City
• Volley Town (+ Camerupt point)

Anime locations (islands)

• A-B-C Islands
• Bomba Island (+ Pokémon Battle Judge Training Institute)
• Donto Island
• Giban Island
• Izabe Island
  • Cerosi Town
  • Purika City (+ Purika Contest Hall)
  • Riyado Town (+ Square Top)
  • Izabe Lake, Trapinch underground labyrinth, Valley of destruction
• Monsu Island
• Muscle Island
• Maisie Island
• Wailmer Island
• Wales Island
• Wazoo Island
• S.S. St. Flower

With how the diff preview was reworked, the areas diff has been removed
Reintroduce it and test changes

Is your feature request related to a problem ?
Currently, the whole map is parsed client-side which makes scalability a huge problem.

Describe the solution you'd like
The map should be parsed server-side, and client only ask for required chunk to reduce initial loading.

• Switch to denoland/setup-deno
• Switch to jurassiscript/setup-velociraptor

Is your feature request related to a problem ?
In some areas (like hoenn), there are random locations which does not always appear (mirage tower/isles, etc.) and this is currently not represented.

Describe the solution you'd like
Maybe we can make it random based on the seed (with a special seed to always display them)

Describe alternatives you've considered

Additional context

Summary

Following #64, the menu and the mini-map were removed but needs to be implemented again

Impacted components

📀 app: client

Impacted regions

No response

Community guidelines

• I am not duplicating an existing issue, pull request or discussion
• I have read contribution guidelines
• I agree to follow the Code of Conduct

• World map isn't bound by scrolling, so if user "lost the map" there's no way to recover it
• World map should be centered around current location (+ adding an icon to tell "you're here" would be nice) rather than 0;0
• World map should "grey out" unmapped locations

What should be revised ?
Anime-exclusive locations integration

Source your revision
https://bulbapedia.bulbagarden.net/wiki/List_of_anime-exclusive_locations#Hoenn

• A-B-C Islands
• Anthony's Gym
• Baltoy civilization ruins
• Banana Slakoth Garden
• Bomba Island
• Crossgate Town
• Donto Island
• Foothill Town
• Forbidden Forest
• Forina
• Giban Island
• Izabe Island
• Izabe Lake
• Kirikiri Mountain
• Lake May
• LaRousse City
• Maisie Island
• Mirage Kingdom
• Misty Village
• Monsu Island
• Mountain Lighthouse
• Muscle Island
• North Petalburg
• Oldale Ruins
• Pokémon Battle Judge Training Institute
• Purika City
• Rinshin Town
• Riyado Town
• Rubello Town
• S.S. St. Flower
• Shroomish Forest
• South City
• Square Top
• The Green Lodge
• The Greenhouse
• Togepi Paradise
• Trapinch underground labyrinth
• Valley of Steel
• Volley Town
• Wailmer Island
• Wales Island
• Wazoo Island

hello @lowlighter ,

Is your feature request related to a problem ?
yes, I cannot enjoy my freedom.

Describe the solution you'd like

• I want to have roucool because with bulbizzare, dracofeu, tortank and pikachu. It's the only ones I want and know btw
• tell me where it is

Describe alternatives you've considered

• Have multiples roucool
• Finish Half Life alyx
• come play vr at my home

Additional context
I was just about to give a star and say gr8 proj8ct m8 8/8 but I breathed out and said to my self something is missing. So I opened up my laptop, closed it, opened up my phone, called a friend which know pokemon better than me, said it was not right that roucool was missing. I said "I know dude right ?".

Pseudo code

if(cell.notSea && cell.isEmpty) {
    const rand = Math.random()
    if(rand > 0.9999999999999)
        spawnRoucool()
}

goodbye