lostpebble / koa-mobx-react-starter Goto Github PK

Thanks for working on this. I'd like to see how the design might change as you add tests.

Hi! Can you please reason this line? It is not obvious for server-side rendering newbies like me. A comment in the file would be great!

require('babel-runtime/core-js/promise').default = require('bluebird');

https://github.com/lostpebble/koa-mobx-react-starter/blob/master/src/server/babel-server.js#L6

Hey, so I was going through your code and stumbled upon this comment in store-utils.js w/r/t to linkStores fn().

// This function takes care of helping stores communicate with
// each other. If there is an array defined on any store named
// "linkedStores", the array elements (containing exact names of other stores)
// are used here to "inject" the actual store objects into that store
// so it can be access directly

Not being having a programming background whatsoever, this is exactly the thing I've been struggling with when working with mobx: how to access actions in two or more stores in the same code block. My question:

Is linking in this way performant?

I've never truly seen anything like this. It makes sense somewhat if the stores are quite small, which is in fact how I have mine structured. But it doesnt seem quite right at the same time. Again, i apologize if this is common knowledge is programming, but I had to ask this question.

cheers,
ap

react-tap-event-plugin dependency should be updated in package.json to ^2.0.0 otherwise the below errors are thrown during 'npm run dev' and click events are not registered on the page.

ERROR in ./\~/react-tap-event-plugin/src/injectTapEventPlugin.js
Module not found: Error: Cannot resolve module 'react/lib/EventPluginHub' in ./node_modules/react-tap-event-plugin/src
 @ ./\~/react-tap-event-plugin/src/injectTapEventPlugin.js 23:2-37

ERROR in ./\~/react-tap-event-plugin/src/TapEventPlugin.js
Module not found: Error: Cannot resolve module 'react/lib/EventConstants' in ./node_modules/react-tap-event-plugin/src
 @ ./\~/react-tap-event-plugin/src/TapEventPlugin.js 22:21-56

ERROR in ./\~/react-tap-event-plugin/src/TapEventPlugin.js
Module not found: Error: Cannot resolve module 'react/lib/EventPluginUtils' in ./node_modules/react-tap-event-plugin/src
 @ ./\~/react-tap-event-plugin/src/TapEventPlugin.js 23:23-60

ERROR in ./\~/react-tap-event-plugin/src/TapEventPlugin.js
Module not found: Error: Cannot resolve module 'react/lib/EventPropagators' in ./node_modules/react-tap-event-plugin/src
 @ ./~/react-tap-event-plugin/src/TapEventPlugin.js 24:23-60

ERROR in ./\~/react-tap-event-plugin/src/TapEventPlugin.js
Module not found: Error: Cannot resolve module 'react/lib/SyntheticUIEvent' in ./node_modules/react-tap-event-plugin/src
 @ ./~/react-tap-event-plugin/src/TapEventPlugin.js 25:23-60

ERROR in ./\~/react-tap-event-plugin/src/TapEventPlugin.js
Module not found: Error: Cannot resolve module 'react/lib/ViewportMetrics' in ./node_modules/react-tap-event-plugin/src
 @ ./\~/react-tap-event-plugin/src/TapEventPlugin.js 27:22-58

Hello @lostpebble! Thank you so much for the project; it looks like fitting well for what I have been looking for.

Can you please add the license terms so that I (and other developers of course) can use the project as a starter for my web app without having to worry about any issues in future?