lorentzben / lts Goto Github PK

• Migrate Function
• Generalize variables
• Write Test cases
• x get_time_budget_prop.R:9: @examples requires a value.
• x time_to_intervals.R:5: @return requires a value.
• x time_to_intervals.R:8: @examples requires a value.

• test

Tasklist:

• Migrate Function
• Generalize variables
• Write Test cases

The issue originated with the interval1 in the x axis, this is the updated one, but there are 2-3 calls per room so that is a couple blocks to update, a function that obfuscates this and saves a .png would be easier with the option to pass a room, filename, and dataframe/tibble in.

room_11_sb_night_plot <- ggplot(data = night_flat, aes(x = as.Date(ymd_hms(as.POSIXct.numeric(as.numeric(interval1),origin="1970-01-01"))), y=values, fill=ind)) + 
geom_bar(stat="identity") +
theme_bw() +  
xlab("Day of Study") + 
ylab("Prop. of Time Spent in Zone") +
scale_x_date(breaks= datebreaks, minor_breaks=all_datebreak) + 
theme(axis.text.x = element_text(angle = 45, hjust = 1)) + 
ggtitle("Daily Time Budget for Each Night for Room 8") + 
labs(fill = "Zone") +
scale_y_continuous(limits=c(0, y_lim))

Tasklist:

• Migrate Function
• Generalize variables
• Write Test cases

Currently the package is developed under R 4.1.0, but a more recent version of R 4.3.3 exists and the package should be migrated if possible.

Dependencies seem like they will be the most difficult part to migrate.

I have pulled in one example test dataset but I have generated 3 previously. I want to bring them in to ensure code coverage.

Tasklist:

• Migrate Function
• Generalize variables
• Write Test cases

The current get_time_budget_prop expects a column "Subzone" with the value of c("bottom","middle","top") and I want to extend functionality to use any named column and any number of zones, we just need to develop the logic that calculates each zone.

In two functions (identify_duplicates, slice_tsibble) I reference columns like datetime, etc.
To fix this and make the package more useable I want to add two arguments:

identify_duplicates(record_table,datetime,value)
slice_tsibble(data,start,stop,datetime,value)

This should hopefully be a fairly straightforward refactor

Refactor get_datebreaks to be a function and to standardize the use of as.date and as.POSIXct as opposed to YMD HMS because of the: data.frame(matrix(unlist(current_day_tb), nrow=length(current_day_tb), byrow=T)) which messes up the datetime

Tasklist:

• Migrate Function
• Generalize variables
• Write Test cases

Tasklist:

• Migrate Function
• Generalize variables
• Write Test cases