lordrex34 / commons-annotation-config Goto Github PK

Yeah, I should make one day something like that.

Here is a line of reference: https://github.com/lordrex34/commons-annotation-config/blob/master/src/main/java/com/github/lordrex34/config/ConfigManager.java#L108

All config annotations allow you to change the path of the config, pointing to a folder other than "config", also you can change the file type as well, from ".properties" to something else. The case here is that no matter what you do with those annotations there, this engine will ALWAYS search for ./config/override.properties even if you are using some other folder and extensions for the default configs. This is a huge design flaw which is binding you to use the default settings - place everything in ./config/*.properties.

I suggest 2 ways to fix this issue:

• Allow individual override files for every config class, for example: @ConfigClass(fileName = "general", pathNames="settings", fileExtension="") to @ConfigClass(fileName = "general", pathNames="settings", overridePathNames={ "settings", "override.properties" })
• Instead of the boolean: ConfigManager#isOverrideSystemAllowed(), allow it to be a path, if set to non-null, the override system will be allowed and it will take the overriding properties file from the spefied path.

Hello,

As title says, i need support for providing default value that has to be computed first, in my case random generated base64 text.

I can suggest small interface like

public interface IConfigDefaultValueSupplier<T>
{
       Supplier<T> supply();
}

Added onto the ConfigField annotation used instead of value variable if not null

When reloading configuration, the override.properties file is not read.

[20:37:15]  INFO Loaded 0 overridden properti(es).

Compared to when config is initially loaded:

[20:28:30]  INFO Loaded 17 overridden properti(es).

It appears that since override.properties is passed as InputStream, once the stream is read on the first pass, its no longer valid on consecutive passes. Maybe a supplier of the InputStream should be passed instead?