longor1996 / orlytalk Goto Github PK

Hi Lars,

first, this is a great App 👍

Although I have a problem. I have deployed this App on my server orlytalk.sharknoon.de and can't log in because the connection with the websocket fails.

I am on Port 443 (HTTPS) and because this is the default port, location.port returns "" (empty String).

And here is the problem, in your index.ts you are checking if the Port is 6991, but in this case it isnt:

I suggest changing this line to

 const HOST = location.host + ":" + location.port;

or some other mecanics to avoid the localhost host to be selected for standard HTTP and HTTPS ports.

Thanks in advance

Your fan

Josua frank

The Docker Description for the README is missing.

Maybe add something along the lines of:

To build and run O'Rly Talk, run the following commands:

docker build . -t orlytalk
docker run -p 6991:6991 orlytalk

And visit localhost:6991

https://github.com/http-rs/tide

Problem:

When specifying an environment variable like ./data/sqlite.db a folder named data needs to be created.

The problem is, that docker volume mounts can only mount directories, not individual files. Therefore a custom directory would be needed.

While you could use a directory from the underlying linux distribution, this would introduce new dependencies to the os.

This is the current implementation:

I would suggest creating all parent directories of the sqlite.db file is they doesnt already exist.

Another Problem with this solution

when specifying an absolute path like /etc/orlytalk/sqlite.db this path gets appended to the working directory. If the path starts at root, the exapth path should be used.