lonedev6 / bungeepackfix Goto Github PK

Avoid sending resourcepacks again if it's the same resourcepack (useful for ItemsAdder).

Home Page: https://www.spigotmc.org/resources/96794/

License: Other

Java 100.00%

bungeecord itemsadder minecraft resourcepack

bungeepackfix's Introduction

This project is currently discountinued. You're free to work on it and update it for recent versions of the game, I will accept pull requests as soon as they work correctly.

bungeepackfix's People

Contributors

Stargazers

Forkers

andre601 daracci swartzcoding amitexing flowergunn nhanledev yosoyvillaa felson999 micalhl tqqn suprexde itstyrion petulikan1 panrein-dev radiation-pi

bungeepackfix's Issues

Pack loading multiple times on 1.20.4

Velocity: 3.3.0-SNAPSHOT 363
itemsadder: ItemsAdder_3.6.3-beta-13
lonelibs: 1.0.45

When being on 1.20.4 the pack reloads even when having bungeepackfix on the proxy but on 1.20.1 I don't have that issue.

Console debug logs of bungeepackfix:

[12:55:07 INFO]: [server connection] xdLulux -> spawn has connected
[12:55:07 INFO]: [server connection] xdLulux -> hub has disconnected
[12:55:08 WARN] [bungeepackfix]: ServerResourcePackSendEvent: xdLulux ResourcePackInfo{url='https://dl.mineberry.fr/pack.zip#1707926405000', hash=8132ebdb59616be5632a2fc1d080fdeb489589c5, forced=false, promptMessage=TextComponentImpl{content="", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=not_set, color=null, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[TextComponentImpl{content="Bienvenue xdLulux, veuillez accepter le pack de ressources pour jouer sur notre serveur.\n", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=TextColorImpl{value="#ffab2e"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="Vous n'avez besoin de le télécharger qu'une seule fois.", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=TextColorImpl{value="#00d93a"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}]}}
[12:55:08 WARN] [bungeepackfix]: Sending pack: xdLulux ResourcePackInfo{url='https://dl.mineberry.fr/pack.zip#1707926405000', hash=8132ebdb59616be5632a2fc1d080fdeb489589c5, forced=false, promptMessage=TextComponentImpl{content="", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=not_set, color=null, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[TextComponentImpl{content="Bienvenue xdLulux, veuillez accepter le pack de ressources pour jouer sur notre serveur.\n", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=TextColorImpl{value="#ffab2e"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="Vous n'avez besoin de le télécharger qu'une seule fois.", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=TextColorImpl{value="#00d93a"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}]}}
[12:55:09 INFO]: [server connection] LuluxosTacos -> spawn has connected
[12:55:09 INFO]: [server connection] LuluxosTacos -> hub has disconnected
[12:55:10 WARN] [bungeepackfix]: ServerResourcePackSendEvent: LuluxosTacos ResourcePackInfo{url='https://dl.mineberry.fr/pack.zip#1707926405000', hash=8132ebdb59616be5632a2fc1d080fdeb489589c5, forced=false, promptMessage=TextComponentImpl{content="", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=not_set, color=null, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[TextComponentImpl{content="Bienvenue LuluxosTacos, veuillez accepter le pack de ressources pour jouer sur notre serveur.\n", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=TextColorImpl{value="#ffab2e"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="Vous n'avez besoin de le télécharger qu'une seule fois.", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=TextColorImpl{value="#00d93a"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}]}}
[12:55:10 WARN] [bungeepackfix]: Sending pack: LuluxosTacos ResourcePackInfo{url='https://dl.mineberry.fr/pack.zip#1707926405000', hash=8132ebdb59616be5632a2fc1d080fdeb489589c5, forced=false, promptMessage=TextComponentImpl{content="", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=not_set, color=null, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[TextComponentImpl{content="Bienvenue LuluxosTacos, veuillez accepter le pack de ressources pour jouer sur notre serveur.\n", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=TextColorImpl{value="#ffab2e"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="Vous n'avez besoin de le télécharger qu'une seule fois.", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=TextColorImpl{value="#00d93a"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}]}}
[12:55:21 INFO]: [server connection] xdLulux -> island has connected
[12:55:21 INFO]: [server connection] xdLulux -> spawn has disconnected
[12:55:22 WARN] [bungeepackfix]: ServerResourcePackSendEvent: xdLulux ResourcePackInfo{url='https://dl.mineberry.fr/pack.zip#1707926405000', hash=8132ebdb59616be5632a2fc1d080fdeb489589c5, forced=false, promptMessage=TextComponentImpl{content="", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=not_set, color=null, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[TextComponentImpl{content="Bienvenue xdLulux, veuillez accepter le pack de ressources pour jouer sur notre serveur.\n", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=TextColorImpl{value="#ffab2e"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="Vous n'avez besoin de le télécharger qu'une seule fois.", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=TextColorImpl{value="#00d93a"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}]}}
[12:55:22 WARN] [bungeepackfix]: Sending pack: xdLulux ResourcePackInfo{url='https://dl.mineberry.fr/pack.zip#1707926405000', hash=8132ebdb59616be5632a2fc1d080fdeb489589c5, forced=false, promptMessage=TextComponentImpl{content="", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=not_set, color=null, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[TextComponentImpl{content="Bienvenue xdLulux, veuillez accepter le pack de ressources pour jouer sur notre serveur.\n", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=TextColorImpl{value="#ffab2e"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="Vous n'avez besoin de le télécharger qu'une seule fois.", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=TextColorImpl{value="#00d93a"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}]}}

Itemsadder host config:

  hosting:
    no-host:
      enabled: false
    auto-external-host:
      enabled: false
    self-host:
      enabled: false
      server-ip: aaaa
      pack-port: aaa
    external-host:
      enabled: true
      url: 'https://redacted/pack.zip'
      skip-url-file-type-check___DONT_ASK_HELP_IF_SET_TRUE: false

BungeePackfix config:

messages:
  minimessage_support: false
  ignored_pack:
    enabled: true
    message: "DEBUG"
equal_pack_attributes:
  hash: false
  forced: true
  prompt_message: true
  modern_uuid: true
ignore_hash_in_url: false
main_spigot_server_name: spawn
ignored_servers:
  enabled: false
  invert_check: false
  list:
    - spawn
    - spawn01
    - spawn02
    - spawn03
    - spawn04
    - spawn05
    - spawn06
    - spawn07
    - spawn08
    - island
    - island01
    - island02
    - island03
    - island04
    - island05
    - island06
    - island07
log:
  ignored_respack: true
  sent_respack: true
  debug: true
cancel_modern_resourcepack_remove_packet: true

[Feature Request] Add option for urls of packs that should be skipped

Basicly this will make the plugin more legacy for more plugins that are doing something with resurcepacks..

I mean by that that there should be new option in config where user can specify what urls of resourcepack should be skipped too
even if they are different.

*Im sorry if something like this already exists but there is not any documentation..

The plugin still loads the texturepack agai neven tho they are same.

Here is the logs with debug https://pastebin.com/K6j4sY8i

Velocity Url Comparison

In ServerResourcePackSendListener.java when comparing pack urls after the ==, the logic there will not work if you follow the wiki (tested and fixed myself).

(The wiki says sub servers should use external host and the link without the # or part after it.)

The self-host server URL (serverPack) will return as http://host:port/pack.zip while the new sub-server pack (playerPack) using that same URL, will send a pack with a hash like http://host:port/pack.zip#...

I suggest you parse out the #... hash part, or simply use (playerPack.getUrl().startsWith(serverPack.getUrl()) which will also work.

Not working in 1.20.5

in 1.20.5 pack are getting resend

Will a reload command be added?

/bungeepackfix reload

Velocity

Please add velocity support <3

bad packet, are mods in use!? Couldn't read all bytes from a packet

this happens when I log into version 1.8, and then log into the 1.20.1 server

error 1: https://prnt.sc/SaWnZY-p6c7M

então ativei a opção Dwaterfall.packet-decode-logging=true

error 2: https://prnt.sc/_y7zw9d15RIU

BungeePackFix_1.1.5-beta-1
waterfall-1.20-562

removing bungeepackfix solves the problem and they are not kicked

1.19.3

Please update 1.19.3!
ViaVersion is not compatible with this.
This was also the error with version 1.19.2, so the server keeps quiting with: server_went_down (proxy_message)

BungeePackFix 1.1.3 When using Minecraft 1.20.2, switching servers does not skip resource pack loading, it always reloads

When using Minecraft 1.20.2, switching servers does not skip resource pack loading, it always reloads

Everything works fine when using 1.20.1.

This server is running Paper version git-Paper-169 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: b4e3b3d)
This server is running Waterfall version git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:0e657ed:545 by md_5

Update for 1.20.2?

Hi, I am currently using Itemsadder, it works perfect for 1.12.2 but I am waiting for the BungeePackFix update. thanks.

[Velocity + Paper] Kicked for Not accepting resource pack when BungeePackFix skips it.

I'm using ItemsAdder for the resource packs if it matters.

I'm getting kicked from the server whenever the resource pack loading is skipped by this mod. using the following software versons:
paper: 1.20.1-84
velocity: Velocity 3.2.0-SNAPSHOT
BungeePackFix: 1.1.1 (although this reports in logging as 1.1.0-r3, i double checked and redownloaded 1.1.1 from this GH and it still does this)
ItemsAdder: 3.5.0c-r2
LoneLibs: 1.0.25

edit More info:
The Lobby Server has been set to force the resource pack the skyblock server does not kick if its not accepted, only the lobby, which is why I don't get kicked form the skyblock server when changing. it also does this kick when i turn the skyblock server to kick if the pack is not applied.

Config:

messages:
  minimessage_support: false
  ignored_pack:
    enabled: true
    message: "&6Skipped resourcepack installation (you already loaded it)."
equal_pack_attributes:
  hash: true
  forced: false
  prompt_message: false
ignore_hash_in_url: true
main_spigot_server_name: lobby
ignored_servers:
  enabled: true
  invert_check: false
  list:
    - ignored_1
    - ignored_2
log:
  ignored_respack: true
  sent_respack: true
  debug: true

Log of console with all logging turned on:

[17:56:49 INFO]: Done (2.72s)!
[17:56:54 INFO]: [connected player] KonoTyran (/127.0.0.1:65388) has connected
[17:56:54 INFO]: [server connection] KonoTyran -> lobby has connected
[17:56:54 INFO]: [+] KonoTyran connected!
[17:56:54 WARN] [bungeepackfix]: ServerResourcePackSendEvent: KonoTyran ResourcePackInfo{url='http://home.kono-technologies.com:25555/generated.zip#97fed7e33cf9247bfff3b01b4e6889836afb08c1', hash=null, forced=true, promptMessage=TextComponentImpl{content="", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=not_set, color=null, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[TextComponentImpl{content="Welcome ", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=NamedTextColor{name="gold", value="#ffaa00"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="KonoTyran, ", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="aqua", value="#55ffff"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="please accept the resourcepack to enjoy all the amazing features of our server.\n ", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="gold", value="#ffaa00"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="You need to download it only once.", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="green", value="#55ff55"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}]}}
[17:56:54 WARN] [bungeepackfix]: Sending pack: KonoTyran ResourcePackInfo{url='http://home.kono-technologies.com:25555/generated.zip#97fed7e33cf9247bfff3b01b4e6889836afb08c1', hash=null, forced=true, promptMessage=TextComponentImpl{content="", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=not_set, color=null, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[TextComponentImpl{content="Welcome ", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=NamedTextColor{name="gold", value="#ffaa00"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="KonoTyran, ", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="aqua", value="#55ffff"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="please accept the resourcepack to enjoy all the amazing features of our server.\n ", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="gold", value="#ffaa00"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="You need to download it only once.", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="green", value="#55ff55"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}]}}
[17:57:06 INFO]: [server connection] KonoTyran -> skyblock has connected
[17:57:06 INFO]: [server connection] KonoTyran -> lobby has disconnected
[17:57:06 INFO]: [?] KonoTyran moved to skyblock!
[17:57:06 WARN] [bungeepackfix]: ServerResourcePackSendEvent: KonoTyran ResourcePackInfo{url='http://home.kono-technologies.com:25555/generated.zip', hash=null, forced=false, promptMessage=TextComponentImpl{content="", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=not_set, color=null, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[TextComponentImpl{content="Welcome ", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=NamedTextColor{name="gold", value="#ffaa00"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="KonoTyran, ", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="aqua", value="#55ffff"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="please accept the resourcepack to enjoy all the amazing features of our server.\n ", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="gold", value="#ffaa00"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="You need to download it only once.", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="green", value="#55ff55"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}]}}
[17:57:06 WARN] [bungeepackfix]: Ignored already sent pack: KonoTyran ResourcePackInfo{url='http://home.kono-technologies.com:25555/generated.zip', hash=null, forced=false, promptMessage=TextComponentImpl{content="", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=not_set, color=null, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[TextComponentImpl{content="Welcome ", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=NamedTextColor{name="gold", value="#ffaa00"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="KonoTyran, ", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="aqua", value="#55ffff"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="please accept the resourcepack to enjoy all the amazing features of our server.\n ", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="gold", value="#ffaa00"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="You need to download it only once.", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="green", value="#55ff55"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}]}}
[17:57:10 INFO]: [server connection] KonoTyran -> lobby has connected
[17:57:10 INFO]: [server connection] KonoTyran -> skyblock has disconnected
[17:57:10 INFO]: [?] KonoTyran moved to lobby!
[17:57:10 WARN] [bungeepackfix]: ServerResourcePackSendEvent: KonoTyran ResourcePackInfo{url='http://home.kono-technologies.com:25555/generated.zip#97fed7e33cf9247bfff3b01b4e6889836afb08c1', hash=null, forced=true, promptMessage=TextComponentImpl{content="", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=not_set, color=null, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[TextComponentImpl{content="Welcome ", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=NamedTextColor{name="gold", value="#ffaa00"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="KonoTyran, ", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="aqua", value="#55ffff"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="please accept the resourcepack to enjoy all the amazing features of our server.\n ", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="gold", value="#ffaa00"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="You need to download it only once.", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="green", value="#55ff55"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}]}}
[17:57:10 WARN] [bungeepackfix]: Ignored already sent pack: KonoTyran ResourcePackInfo{url='http://home.kono-technologies.com:25555/generated.zip#97fed7e33cf9247bfff3b01b4e6889836afb08c1', hash=null, forced=true, promptMessage=TextComponentImpl{content="", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=not_set, color=null, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[TextComponentImpl{content="Welcome ", style=StyleImpl{obfuscated=false, bold=false, strikethrough=false, underlined=false, italic=false, color=NamedTextColor{name="gold", value="#ffaa00"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="KonoTyran, ", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="aqua", value="#55ffff"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="please accept the resourcepack to enjoy all the amazing features of our server.\n ", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="gold", value="#ffaa00"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}, TextComponentImpl{content="You need to download it only once.", style=StyleImpl{obfuscated=not_set, bold=not_set, strikethrough=not_set, underlined=not_set, italic=false, color=NamedTextColor{name="green", value="#55ff55"}, clickEvent=null, hoverEvent=null, insertion=null, font=null}, children=[]}]}}
[17:57:10 INFO]: [connected player] KonoTyran (/127.0.0.1:65388): kicked from server lobby: You must accept the resourcepack! Also make sure you set them to 'Prompt' or 'Enabled' in server properties.
[17:57:10 INFO]: [server connection] KonoTyran -> lobby has disconnected
[17:57:10 INFO]: [connected player] KonoTyran (/127.0.0.1:65388) has disconnected: You were kicked from lobby: You must accept the resourcepack! Also make sure you set them to 'Prompt' or 'Enabled' in server properties.

BungeePackFix LAST PR didn't work

After some seconds log on, we are kick for nothing.

I search atm why ...

Velocity support

Yes. support for velocity!

Default ignore resource pack behavior causes resource pack not reload when do /iazip

Given this config in Waterfall

log:
  ignored_respack: true
  sent_respack: true
  debug: true
equal_pack_attributes:
  hash: true
  forced: true
  prompt_message: true
ignore_hash_in_url: true
main_spigot_server_name: server_1
ignored_servers:
  enabled: false
  invert_check: false
  list:
    - ignored_1
    - ignored_2

When I do /iazip the resource pack reload is cancelled.
Log:

[22:07:25 WARN] [BungeePackFix]: Sending pack: HibaraMamoru ClientboundResourcePackPacket{url='http://10.200.0.31:8163/generated.zip#e44ecf9719c311653dfe0cf713c790d6e2cca402', hash=null, forced=true, promptMessage={"extra":[{"text":"\n"},{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"white","text":"REACTED TEXT"},{"bold":true,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"white","text":"REACTED TEXT"},{"bold":true,"italic":false,"color":"blue","text":"MC\n\n"},{"bold":false,"italic":false,"color":"white","text":"REACTED TEXT"}],"text":""}}
[22:07:25 WARN] [BungeePackFix]: RespackStatusPacketIn: HibaraMamoru ACCEPTED
[22:07:26 WARN] [BungeePackFix]: RespackStatusPacketIn: HibaraMamoru SUCCESSFULLY_LOADED
[22:07:30 WARN] [BungeePackFix]: Ignored already sent pack: HibaraMamoru ClientboundResourcePackPacket{url='http://10.200.0.31:8163/generated.zip#e44ecf9719c311653dfe0cf713c790d6e2cca402', hash=null, forced=true, promptMessage={"extra":[{"text":"\n"},{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"white","text":"REACTED TEXT"},{"bold":true,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"white","text":"REACTED TEXT"},{"bold":true,"italic":false,"color":"blue","text":"MC\n\n"},{"bold":false,"italic":false,"color":"white","text":"REACTED TEXT"}],"text":""}

What to expected:

ignore_hash_in_url shoud be defaulted as false

[Bug] Can't connect server when using 1.19 client

I'm using Waterfall 1.19 Build 496

Tested with 1.18.2 client is work fine
but 1.19 client is can't connect to the server

Join Server Problem

[10:38:29 ERROR]: [/46.196.193.189:22021|witcharon] <-> DownstreamBridge <-> [lobby] - encountered exception
java.lang.NoSuchMethodError: 'void net.md_5.bungee.protocol.PacketWrapper.<init>(net.md_5.bungee.protocol.DefinedPacket, io.netty.buffer.ByteBuf)'
        at dev.lone.bungeepackfix.bungee.packets.impl.ClientboundResourcePackPacket.handle(ClientboundResourcePackPacket.java:82) ~[?:?]
        at net.md_5.bungee.netty.HandlerBoss.channelRead(HandlerBoss.java:124) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:346) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:333) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:454) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:290) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:800) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:509) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:407) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[server.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:a5bbdbe:543]
        at java.lang.Thread.run(Thread.java:833) [?:?]
[10:38:29 INFO]: [witcharon] disconnected with: The server you were previously on went down, you have been connected to a fallback server

I'm getting this error in the console after logging into the server, and I can't log in.

Repository should mention usage of internal code (And possible setup guidelines)

The plugin seems to utilize internal code from BungeeCord.

This should be mentioned within the README or somewhere else, so that potential contributors are aware of this and can setup the environment properly to avoid issues like below:

BungeePackFix doesn't allow 1.19.1 clients

Proxy will give out a bad packet when joining from a 1.19.1 client, but only when using bungeepackfix

Error:

Color characters & not working

BungeePackFix 1.0.4 error on load

After updating everything (bungee itemsadder etc...) I'm getting this error on load: https://pastebin.com/6UnN9swA

New logic

I think would be better to basically just provide the resourcepack links in the BungeepackFix configuration.
This allows you to easily configure your resourcepack links for each one of the servers without having to open the ItemsAdder configuration on each server.

Let me know what you think

equal_pack_attributes: hash: true | not working for velocity

Velocity 3.3.0-SNAPSHOT (git-59567512-b346)
BungeePackFix_1.1.6-beta1

this is my config:

messages:
  minimessage_support: false
  ignored_pack:
    enabled: true
    message: "&6Skipped resourcepack installation (you already loaded it)."
equal_pack_attributes:
  modern_uuid: true
  hash: false
  forced: true
  prompt_message: true
ignore_hash_in_url: true
cancel_modern_resourcepack_remove_packet: true
main_spigot_server_name: "gens-hub"
ignored_servers:
  enabled: false
  invert_check: false
  list:
    - ignored_1
    - ignored_2
log:
  ignored_respack: false
  sent_respack: false
  debug: false

main_spigot_server_name is the server that hosts the resource pack and all other subservers have a valid external host configuration like this:

    external-host:
      enabled: true
      url: http://**REDACTED IP**:8163/generated.zip#307aaf7e86d249c46eeba6fa67c353c22ac52344
      skip-url-file-type-check___DONT_ASK_HELP_IF_SET_TRUE: false

whenever i set equal_pack_attributes: hash: true the plugin stops working and the resourcepack will be applied on every server swtich, disabling the option will make it work again.

1.19.4 not support?

I went through several tests and found out that the problem was in the bungeepackfix.

bungeepackfix import - > 1.19.4 to 1.19.2 packet error

bungepacfix disable ->ok

The problem with pom

The core used by pom is local, but it seems to be idiosyncratic, I downloaded the core play to compile him, please can I not use the local path

implement "cancel_modern_resourcepack_remove_packet" functionality also for Velocity.

Hope to support disabling some servers

I hope to support whitelist system, some of my servers do not want to synchronize the server material package

1.20.2 resource pack disabled.

In version 1.20.1, even when downloading the resource pack on server1 and connecting to server2, the resource pack remains applied. However, when connecting to the server with version 1.20.2, there is an issue where the resource pack gets disabled.

BungeePackFix 1.1.4
git-Paper-62 (MC: 1.20.1)
ViaVersion 4.8.1

why velocity code cleanup? i need it

N/A

This plugin is great but it's not working on 1.20.1 can you fix it please ! :)

Kicked when setting perms in luck perms

/lp user NICK parent set Perms
And all players get his:

Implement whitelist for "not ignored" servers

#25

geyser problem

In the latest version Geyser proxy servers, mobile players are kicked out of the game when they open the work table or inventory. This needs to be fixed urgently.

https://mclo.gs/lVsflcO

Packs are identical however still reload

Hey! So last night I had some issues with my pack, and had to restore a backup and change the port for upload.
I went from 8322 to 8350 on the port, I run the pack on survival and lobby servers, same pack using bungeepackfix

Bungeepack fix used to work, But since i had to restore a backup and change port its no longer working,
Both on the same version of IA, (2.5.0-beta) And bungeepackfix is on bungeecord obviously,

Both use the exact same config file, its a complete clone of the IA folders on each server.
the first image shows the files are exactly identical down to the exact file count. (there is a slight difference in the bytes on one server could that be the issue?) Its a copy paste of the other folder so not sure why its done that)

What exactly tells bungeepack fix that 'these are the same packs' so skip download?

Thanks!

There is an issue where the connection to the server is terminated when using the latest version of Waterfall.

Geyser Support

please add geyser support it will ignore geyser players
because in this case geyser automatically kicks players out of the game

Whitelist Feature

Can you add a whitelist feature that only servers in this list, the plugin feature will be enabled.

proxy disconections

https://pastebin.com/1VXN2hba

"disconnected with: DecoderException: io.netty.util.IllegalReferenceCountException: refCnt: 0, decrement: 1 @ io.netty.handler.codec.MessageToMessageDecoder:98"

It does not work properly in version 1.20.4. it gives the error "disconnected with: DecoderException: io.netty.util.IllegalReferenceCountException: refCnt: 0, decrement: 1 @ io.netty.handler.codec.MessageToMessageDecoder:98" and throws it out of the game. It gets fixed when I delete bungeepackfix.

Players using 1.20.2 are kicked

[23:29:11] [Netty Worker IO Thread #14/WARN]: [/|PoyrazOglu] <-> DownstreamBridge <-> [Dunya5] - A decoder exception has been thrown:
io.netty.handler.codec.DecoderException: net.md_5.bungee.protocol.OverflowPacketException: Cannot receive string longer than 98301 (got 83457492 bytes)
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:98) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:346) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:318) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at java.lang.Thread.run(Thread.java:833) [?:?]
Caused by: net.md_5.bungee.protocol.OverflowPacketException: Cannot receive string longer than 98301 (got 83457492 bytes)
	at net.md_5.bungee.protocol.DefinedPacket.readString(DefinedPacket.java:63) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at net.md_5.bungee.protocol.DefinedPacket.readString(DefinedPacket.java:54) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at dev.lone.bungeepackfix.bungee.packets.impl.ClientboundResourcePackPacket.read(ClientboundResourcePackPacket.java:100) ~[?:?]
	at dev.lone.bungeepackfix.bungee.packets.impl.ClientboundResourcePackPacket.read(ClientboundResourcePackPacket.java:114) ~[?:?]
	at net.md_5.bungee.protocol.MinecraftDecoder.decode(MinecraftDecoder.java:62) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at net.md_5.bungee.protocol.MinecraftDecoder.decode(MinecraftDecoder.java:13) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:88) ~[bungee.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:c996222:548]
	... 24 more
[23:29:11] [Netty Worker IO Thread #14/INFO]: [PoyrazOglu] disconnected with: Sunucu çöktü
[23:29:11] [Netty Worker IO Thread #14/INFO]: [/|PoyrazOglu] -> UpstreamBridge has disconnected
[23:29:11] [Netty Worker IO Thread #14/INFO]: [/|PoyrazOglu] <-> DownstreamBridge <-> [Dunya5] has disconnected

Error on flamecord start

I'm using Flamecord v1.5.5, i got this error with latest version 1.1.2

[11:38:35] [main/ERROR]: java.lang.ClassCastException: class java.util.LinkedHashMap$Entry cannot be cast to class java.lang.Integer (java.util.LinkedHashMap$Entry and java.lang.Integer are in module java.base of loader 'bootstrap')
[11:38:35] [main/ERROR]: at dev.lone.bungeepackfix.bungee.packets.impl.ClientboundResourcePackPacket.tryInitializingNextReleases(ClientboundResourcePackPacket.java:71)
[11:38:35] [main/ERROR]: at dev.lone.bungeepackfix.bungee.packets.impl.ClientboundResourcePackPacket.(ClientboundResourcePackPacket.java:57)
[11:38:35] [main/ERROR]: at dev.lone.bungeepackfix.bungee.Main.registerPackets(Main.java:83)
[11:38:35] [main/ERROR]: at dev.lone.bungeepackfix.bungee.Main.onEnable(Main.java:45)
[11:38:35] [main/ERROR]: at net.md_5.bungee.api.plugin.PluginManager.enablePlugins(PluginManager.java:357)
[11:38:35] [main/ERROR]: at net.md_5.bungee.BungeeCord.start(BungeeCord.java:311)
[11:38:35] [main/ERROR]: at net.md_5.bungee.BungeeCordLauncher.main(BungeeCordLauncher.java:52)
[11:38:35] [main/ERROR]: at net.md_5.bungee.Bootstrap.main(Bootstrap.java:15)
[11:38:35] [main/ERROR]: java.lang.reflect.InvocationTargetException
[11:38:35] [main/ERROR]: at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[11:38:35] [main/ERROR]: at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[11:38:35] [main/ERROR]: at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[11:38:35] [main/ERROR]: at java.base/java.lang.reflect.Method.invoke(Method.java:568)
[11:38:35] [main/ERROR]: at dev.lone.bungeepackfix.bungee.packets.Packets.registerPacket(Packets.java:155)
[11:38:35] [main/ERROR]: at dev.lone.bungeepackfix.bungee.packets.impl.ClientboundResourcePackPacket.register(ClientboundResourcePackPacket.java:97)
[11:38:35] [main/ERROR]: at dev.lone.bungeepackfix.bungee.Main.registerPackets(Main.java:83)
[11:38:35] [main/ERROR]: at dev.lone.bungeepackfix.bungee.Main.onEnable(Main.java:45)
[11:38:35] [main/ERROR]: at net.md_5.bungee.api.plugin.PluginManager.enablePlugins(PluginManager.java:357)
[11:38:35] [main/ERROR]: at net.md_5.bungee.BungeeCord.start(BungeeCord.java:311)
[11:38:35] [main/ERROR]: at net.md_5.bungee.BungeeCordLauncher.main(BungeeCordLauncher.java:52)
[11:38:35] [main/ERROR]: at net.md_5.bungee.Bootstrap.main(Bootstrap.java:15)
[11:38:35] [main/ERROR]: Caused by: java.lang.IllegalStateException: Duplicate packet mapping (762, 763)
[11:38:35] [main/ERROR]: at com.google.common.base.Preconditions.checkState(Preconditions.java:675)
[11:38:35] [main/ERROR]: at net.md_5.bungee.protocol.Protocol$DirectionData.registerPacket(Protocol.java:704)
[11:38:35] [main/ERROR]: ... 12 more

problem with removing texture

I want to make sure that the texture shouldn't be removed in server1 and server2, in all others it should be removed. this is my setup but it doesn't do what i want

messages:
  ignored_pack:
    enabled: true
    message: "test"
  minimessage_support: false
equal_pack_attributes:
  hash: true
  forced: true
  prompt_message: true
log:
  ignored_respack: false
  sent_respack: false
  debug: false
ignore_hash_in_url: true
main_spigot_server_name: server1
ignored_servers:
  enabled: true
  invert_check: true
  list:
    - server1
    - server2

1.5.5-dev kicks player if item is inserted into anvil

Hey there, I've been testing this new dev version of BungeePackFix and I've found an interesting bug.

I've enabled the "debug" option in the BungeePackFix config - visible in both videos.

With the 1.1.5 - Dev version, if player inserts an item into anvil, they get kicked out without any error or any debug message.
Here's a link to video showing such behaviour: https://youtu.be/e8GpcC3mxLY

Fortunately with version 1.4.4, such behaviour isn't happening, as shown in the video, if player inserts an item into the anvil, nothing happens as supposed. https://youtu.be/Cj0poxsLWFk

Velocity issue related to ItemsAdder kick-player-on-decline setting

When switching to a server using ItemsAdder on Velocity, I get kicked from the server with the resourcepack-kick-declined message sent in chat. The BungeePackFix ignored_pack message does show in chat before this. This happens with the ItemsAdder kick-player-on-decline setting set to true. When the kick-player-on-decline setting is set to false and I can connect to the server, the resource pack gets resent. No errors in console.

This server is running Paper version git-Paper-196 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: 773dd72)
This server is running Velocity 3.2.0-SNAPSHOT (git-19abb909-b265)

Couldn't pass ServerResourcePackSendEvent to bungeepackfix

[20:41:02 ERROR]: Couldn't pass ServerResourcePackSendEvent to bungeepackfix
java.lang.NoSuchMethodError: 'dev.lone.shaded.bungeepackfix.net.kyori.adventure.text.Component com.velocitypowered.api.proxy.player.ResourcePackInfo.getPrompt()'
        at dev.lone.bungeepackfix.velocity.PlayersPackCache.isSamePack(PlayersPackCache.java:59) ~[?:?]
        at dev.lone.bungeepackfix.velocity.EventsListener.onServerResourcePackSend(EventsListener.java:49) ~[?:?]
        at dev.lone.bungeepackfix.velocity.Lmbda$21.execute(Unknown Source) ~[?:?]
        at com.velocitypowered.proxy.event.UntargetedEventHandler$VoidHandler.lambda$buildHandler$0(UntargetedEventHandler.java:56) ~[velocity.jar:3.2.0-SNAPSHOT (git-19abb909-b265)]
        at com.velocitypowered.proxy.event.VelocityEventManager.fire(VelocityEventManager.java:597) ~[velocity.jar:3.2.0-SNAPSHOT (git-19abb909-b265)]
        at com.velocitypowered.proxy.event.VelocityEventManager.lambda$fire$5(VelocityEventManager.java:478) ~[velocity.jar:3.2.0-SNAPSHOT (git-19abb909-b265)]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
        at java.lang.Thread.run(Thread.java:833) [?:?]

The plugin does not work properly on Velocity because of this (the resource pack gets resent).

I get this error when initially joining and switching to servers using ItemsAdder.

This server is running Paper version git-Paper-196 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: 773dd72)
This server is running Velocity 3.2.0-SNAPSHOT (git-19abb909-b265)

java.lang.ClassCastException: class java.util.LinkedHashMap$Entry cannot be cast to class java.lang.Integer (java.util.LinkedHashMap$Entry and java.lang.Integer are in module java.base of loader 'bootstrap')

Cause:

BungeePackFix/src/main/java/dev/lone/bungeepackfix/bungee/packets/impl/ClientboundResourcePackPacket.java

Line 71 in 8463228

    
           int lastSupportedVersionId = (Integer) PACKET_MAP.entrySet().toArray()[PACKET_MAP.size() - 1];

More info: https://forum.devs.beer/d/1803-error-with-bungeepackfix-and-itemsadder/3

BungeePackFix - pack unloading / BPF ignores reloading

Velocity 3.3.0 snap 334 (Velocity) running BungeePackFix 1.1.5-beta1
Paper-1.20.4 b391 - ItemsAdder 3.6.3-beta-9.jar (Market) - Self Hosted pack
Paper-1.20.4 b391 - ItemsAdder 3.6.3-beta-9.jar (Pink) - external host (Market)
Paper-1.20.4 b391 - ItemsAdder 3.6.3-beta-9.jar (Blue) - external host (Market)
Paper-1.20.4 b391 - ItemsAdder 3.6.3-beta-9.jar (Creative) - external host (Market)

The goal is to have the pack load once on initial join, and should never unload or reload regardless of which of the 4 servers they are connected to.

With the current setup, whenever a player joins, the pack loads once. They are free to swap between servers without extra pack loads/unloads until they go back to the server they originally joined on (I.e.: Joins on Blue, goes to Pink, then Market, then Pink, then Creative, then back to Blue). Once they go back to first server joined, the pack unloads for some reason and BPF ignores reloading (as it should). We can't figure out why rejoining initial server causes the pack to unload.

Our temporary fix: Force all players to join Market on initial connect. Pack will always load here because BPF is set to ignore Market. Players are free to swap between all servers, but when rejoining Market pack will always unload/redownload and reload.