lolmx / stripe Goto Github PK

Issue: breaking changes over major sdk releases

As stated in this and this comments through #4, Stripe v7 introduced two main BC:

• __toArray() became toArray()
• all exceptions have been renamed

We need to support both versions as far as possible.
At the moment i see two ways to supports both, we can add a new config parameter to ask for used sdk version which i'm not fan or add checks with class_exists and method_exists.
I need more inputs to see how we can properly supports both versions.

This also raise the question about supporting older versions ^3|^4|^5. Are they still needed? Anyone in need to use Strong Customer Authentication already must use Stripe ^6.9 to have access to newer api (PaymentIntent & SetupIntent for js gateway).
New Checkout Server Flow (#6) also requires new apis available in ^6.

Wouldn't be beneficial to drop support for ^3|^4|^5? And also maybe for versions >=6.0 <6.9?

Hello, I've used your last fix, but when I want to pay, somehow it get a 400 from stripe. In the logs from their console, I can see that "POST /v1/payment_methods" is being called, with weird parameters:

{
"0": {
"jQuery1111027840744389734773": "1"
},
"type": "card",
"context": {
"jQuery1111027840744389734773": "1"
},
"length": "1",
"guid": "081e87d0-97cb-497f-b7d0-882ab266c439",
"muid": "9bd6e6a1-b3bb-4c29-908b-e0e1a2b0c0e6",
"sid": "914682ec-7c70-4972-a0d7-1ae8815a0632",
"payment_user_agent": "stripe.js/854c6379; stripe-js-v3/854c6379",
"referrer": "http://127.0.0.1:8000/fr/payment/capture/q_c9wydB_4mvrRKGJ5eLo-7fOuwCNJ8n1L3fXJf8mFs",
"key": "pk_test_TV****************************GLUF"
}

And stripe doesn't know what to do with that.

Hi, just wanted to clarify few things.

Original Payum Stripe Checkout now offered by Stripe as Legacy Checkout (Charge API), new Stripe Checkout is a hosted solution (Session API), but at the same time they now offer PaymentIntent API with manual web flow, which is very similar to previous charge api in terms of user experience (Self hosted payment page).

What StripeDirectGatewayFactory and StripeJsGatewayFactory do -- I have no idea.

So what I think is StripeCheckoutGatewayFactory should become StripeLegacyCheckoutGatewayFactory with previous Charge API and stripe/stripe-php lock as in original.

New StripeCheckoutGatewayFactory should consist of Session API which will redirect to Stripe hosted page and your work should go into StripePaymentIntentGatewayFactory with sca and without.

I'm not sure about web (self hosted), android/ios differences, should they be in same GatewayFactory or not. Maybe that's what Direct and JS gateways are about.

What do you think?

By the way, I've tried out new implementation (Inside Sylius) and I'm having this issue.
A Card token may not be passed in as a PaymentMethod. Instead, use payment_method_data with type=card

My model is not constructed right, but I'm sure problem is either with my html template or related to Sylius.

Anyway, my company decided to go with Session API and hosted checkout page, therefore I'll be developing it now. I've saw https://github.com/Combodo/CombodoPayumStripe using Session API, but their code is not idiomatic to Payum and it doesn't look like they plan to return changes to Payum. So maybe we will be able to support both flows inside your fork and eventually PR in master.