lolleko / donkey Goto Github PK

Right now if you have the abilities file "npc_abilities_custom.txt" or "DOTAAbilities" open and change the tooltip data via the sidebar the tab will not reload.

Maybe add a file reload function to the FileManager.

On OpenFile onclick, if file not exists ask with dialog if file should be created. Instead of bailing directly.

OpenFileValue.js#L56

The KV Element Move UP/DOWN command is not triggered with the shrotcut, seems to be a windows only problem.

EDIT: Broken on all platforms.

They should be inserted in the parentkey's inner wrapper rather than directly into the root.

@lolleko seems like a missing feature which is easily implemented

Create interface, for editor elements.

Remove the s2hammer theme. Only support material themes for alpha stage.

Checkmark clipping and not scaling properly.

A "Add Comment" Menu Entry and Command should be added.

Currently name id is: DOTA_Tooltip_ability_example_name_
Should be: DOTA_Tooltip_ability_example_name

Rewrite the stock KVParser (make a custom one) that allows comments to be edited.

• Comments need to be marked somehow in a data map: key:!DonkeyInternal:Comment that could cause problems if someone creates a key with that name (should never happen but is a possibility).

• Display comments as big text input in Editor DOM.

• Parse multiline comments comment string with \n to fancy multiline comments:

  //-------------------------------------
  // Multi-Line Comment
  // Line2
  //-------------------------------------

As soon electron updates to Chrome 54 custom elements will use a new spec: https://developers.google.com/web/fundamentals/primers/customelements/

Upgrading existing elements requires the following:

• Changing document.registerElement() => customeElements.define()
• createdCallback() => constructor()
• window.customElements.get(name) to fetch constructor instead of using document.createElement()
• Using window.customElements.get(name) will also allow AutocompleteInput to extend HTMLInputElement (with <input is="autocomplete-input"> syntax)
• attached => connected
• detached => disconnected (Improve Detach & attach behaviour of KeyValue and ParentKey)
• Use static get observedAttributes() instead of data-xxx change-callbacks (especially data-key, data-value and data-path)

echo 'Installing app dependencies!' && npm --prefix ./app install ./app && node rebuild.js

Installing app dependencies!
Rebuilding natvie modules.
You are using the old API, please read the new docs and update to the new API
Building modules didn't work!
Error: Expected buildPath to be an absolute path

Auto updates for the editor.

• Release server (nuts)
• Implement electrons auto-updater module

Should save after deleting via file tree.

Add a Theme entry, so themes can be changed.

Replace the js-builtin Map data structure.

New data structure specs:

• should allow inserting and deleting via kvpaths
• insertBefore & insertAfter for kvpaths and single keys

The tree view should restore its previous state (expanded items) after it has ben modified and rebuild.

This doesn't seem to work on windows.

d2utils.getAddonContentDir & d2utils.getAddonGameDir should return null if path can't be assembled.

apparently my environment variable workaround on line 18 doesn't fix the issue on windows @lolleko
will try to find a solution

Rebuilding native modules.
You are using the old API, please read the new docs and update to the new API

Create a Menu Entry for packages, with a subentry for each Package that defines a Menu (Atom-Like).

Requirements #5 & #6

Add a Generate tooltip menuItem to the Dota2 package menu, that will generate tooltips. Similar to D2Modkit. But will also utilize the comments from #5. Taking comments into account when generation. AbilitySpecial support should also be builtin.

For example:

//---------------------------
//"Name" "Solar Strike"
//"Description" "Global nuke."
//"Lore" "It burns."
//---------------------------
"invoker_sun_strike"
{
--snip--
}

Result:

"DOTA_Tooltip_ability_sun_strike"             "Solar Stike"
"DOTA_Tooltip_ability_sun_strike_Description" "Global Nuke"
"DOTA_Tooltip_ability_sun_strike_Lore"        "It burns"

Note: If name not specified use Dota_Tooltip_ability__name1_name2_ -> Name1 Name2

This is important for copying multiple KeyValue entries at once.
This will also require some changes to the SpecialCopy, SpecialCut commands.