loilo / color-blend Goto Github PK

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

With TypeScript 3.1.3, importing any of the exported color-blend members, e.g.:

import {colorBurn} from "color-blend";

results in error:

Cannot find module './types'.

I have found getLuminosity/setLuminosity/getSaturation/setSaturation, but I want to change hue of a color.

If white with an alpha value is passed to multiply the non-white value is returned:

Multiply w\ white:

 {
  backdrop: { r: 255, g: 255, b: 255, a: 0.12 }, // White
  source: { r: 0, g: 107, b: 84, a: 1 }, // Non-White
  ret: { r: 0, g: 107, b: 84, a: 1 } // SAME Non-White Value
}

It works with a non-white source or backdrop value:

Multiply w\ non-white:

{
  backdrop: { r: 0, g: 107, b: 84, a: 0.12 },
  source: { r: 251, g: 253, b: 250, a: 1 },
  ret: { r: 221, g: 235, b: 230, a: 1 }
}

Is this the expected behavior? I'm getting accurate results when multiplying non-white values.

const { multiply } = require("color-blend");

const colorWhiteAlpha12 = { r: 255, g: 255, b: 255, a: 0.12 };
const colorPrimary = { r: 0, g: 107, b: 84, a: 1 };

const colorSurface = { r: 251, g: 253, b: 250, a: 1 };
const colorPrimaryAlpha12 = { r: 0, g: 107, b: 84, a: 0.12 };

const colorPrimaryTint = multiply(colorWhiteAlpha12, colorPrimary);
const colorSurfaceTint = multiply(colorPrimaryAlpha12, colorSurface);

console.log("colorPrimaryTint: ", colorPrimaryTint);
console.log("colorSurfaceTint: ", colorSurfaceTint);

/* OUTPUT
colorPrimaryTint:  { r: 0, g: 107, b: 84, a: 1 } - Same as `colorPrimary`
colorSurfaceTint:  { r: 221, g: 235, b: 230, a: 1 }
*/

I found this package in this comment: https://github.com/Qix-/color/issues/99#issuecomment-266601291

i thought that it would be directly compatible with color, but its not totally:

e.g. this leads to wrong results, because color-blends needs an alpha channel (property a):

import Color from 'color'
import blender from 'color-blend'


const color1 = Color("#B5E684")
const colorBlended = blender.normal(color1, Color("yellow")) // returns {r: NaN, g: NaN, b: NaN, a: NaN}

I'm new to color blending. If I have a pixel in the photo that represents true red, green and then blue, based on how much each of these is off can I use this library to correct the pixels in the rest of the image?

For example if red in the photo appears as 240,13,85 when it should be 255,0,0 I'd like to apply the correction to the rest of the pixels. Same for the green pixel and blue.

Hello! Thank you very much for time and efforts put into this library.
May i draw your attention to one nuance?

I'm trying to use your great library with polished npm-package, cause i work on design-system and i need to blend some colors, with blend-modes, but i need to put some extra time because of the following.

Issue
Function rgba from polished works as follows
rgba(255, 205, 100, 0.7) or rgba({ red: 255, green: 205, blue: 100, alpha: 0.7 })

But you package's output is { r: number, g: number, b: number, a: number }. so in order to use polished i need to write 2 functions
1st - to convert any polished result to entry format of your library
2nd - convert your library output to format, that polished understands

My proposal
Please, make color-blend output format either / or
a) an object { red: number, green: number, blue: number, alpha: number }
b) array of RGBA values as numbers [, , , ,] which then can be passed with ...spread syntax out of the box

This can be achieved either / or

1. With some optional parameters to functions, which will determine output format
2. Writing alternatively-named functions, similar to like you did in color-blend/unit

P.S.
With all the respect, it is just a proposal.
I dont have any problems writing such functions on my own in my project.
I just think this could help other people to use your library in more wide and flexible way, thats all.

Best wishes and kind regards,
Artemiy

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.