Code Monkey home page Code Monkey logo

logdna-cloudwatch's People

Contributors

dspv avatar gjanco avatar johnpadilla avatar leeliu avatar lextoumbourou avatar lyhuang avatar smusali avatar vilyapilya avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

logdna-cloudwatch's Issues

Add test coverage

After finishing #27, the unit and integration tests must be added to have, at least, 90%-95% coverage.

Minimum RAM? Timeout value?

This wasn't mentioned in the README but what do you recommend for these values?
This is a screenshot of the default values:
screenshot 2018-07-20 at 17 08 33

Node 14 end of support

Hi, are you please planning to upgrade this package to node 16 or later given that Node 14 will be at the end of their security support in about a month? Thanks

Issues with JSON formatted logs

Migrating from LogDNA-agent to the Lambda integration, our JSON logs are not properly formatted in the LogDNA web app. The JSON body gets converted to a string, and log lines displayed in the web app as a string.

In the interim, we made our own fork with a hacky fix that would break other use-cases. But we would like the upstream package to have better support for JSON formatted logs so that we do not have to maintain a patch.

Setup:
Follow these instructions (NOTE: The link to the zip file is an old version sitting in an S3 bucket, we downloaded the latest from github). We did port the instructions to Terraform, it is possible that something is different than what the manual instructions would produce, but I could not find a meaningful difference.

Steps to reproduce:

  • Run an application with JSON formatted logs, ingest logs using LogDNA agent
  • Run the same application, use the Cloudwatch->Lambda->LogDNA integration to ingest

Expected result:
The log lines look the same in the LogDNA web app

Actual result:
The logs lines look different, are not properly parsed as JSON data

Improve README

The README is not really clear and should be updated (https://docs.logdna.com/docs/cloudwatch too)

What wasn't clear is:

  • 1 - Create a new Lambda function and skip to the Configure function section I guess this was about an old interface? It's impossible to find the Configure Function section see screenshot below
    screenshot 2018-07-20 at 17 02 20
  • Before I could click on create, I had to create a role (this wasn't mentioned)
  • Only after that I was able to click on Upload .zip from the Code entry type select input, and edit the handler see screenshot
    screenshot 2018-07-20 at 17 04 56
  • And the environment vars below

Add this to AWS Serverless Application Repository

Hi there!

Thanks for the Lambda code, I think you should publish it on AWS Serverless Application Repository, it would be a lot easier to deploy and maintain ;-)

screenshot 2018-07-20 at 16 48 31

Is that something planned maybe?

Host the package in S3 Bucket

Can you host the file on S3? No need to download the file that way - just copy and paste the URL in Actions->Upload a File from Amazon S3

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.