locize / resx Goto Github PK

Some days ago a vulnerability has been reported for the referenced package xml2js.

Could you please update xml2js to the latest version?

🚀 Feature Proposal

remove <comment/>

Motivation

<comment> is removed instead of leaving blank at some resx files, making changes in file dff.

Example

don't preserve empty comment as default or making an option for it.

🐛 Bug Report

I am converting JSON to Resx XML, I am passing name, value, comment in the Json Object list. But when i get the resultant XML it does not map the name field value to name, Value and Comment field work properly but not the name.

To Reproduce

Pass the JSON object list to this function in Console the resultant XML will not map the name values to name in the XML
My JSON object list is like the below JSON list.

returned XML is like this name contain random number.

data = [{name: 'menuItemValue', value:'Weeks Per Year', comment:'Add DDI LM 19-09-2016'}]

js2resx(data, (err: any, res: any) => {
            // res is like xml
            console.log(res);
        })

result: 

<data name="816" xml:space="preserve">
    <value>Weeks Per Year</value>
    <comment>Add DDI LM 19-09-2016</comment>
  </data>

Expected behavior

I want to have name field value from my JSON object list to the resultant name in the XML. like this below.

<data name="menuItemValue" xml:space="preserve">
    <value>Weeks Per Year</value>
    <comment>Add DDI LM 19-09-2016</comment>
  </data>

Your Environment

node v16
angular v13
windows 10