Code Monkey home page Code Monkey logo

Comments (4)

pomadchin avatar pomadchin commented on July 22, 2024

@paulushub you're welcome to reopen your PR! The only thing you need to do is to submit an ECA and to sign off the commit https://github.com/locationtech/proj4j/blob/master/CONTRIBUTING.md#sign-off-on-commits-and-filing-a-cla

However, I think changes are minor, so in theory they don't require CLA (but it is still recommended).

from proj4j.

paulushub avatar paulushub commented on July 22, 2024

Just simple changes I made directly in the browser, please take it from there if possible.

from proj4j.

Neutius avatar Neutius commented on July 22, 2024

@paulushub I encountered the same problem this week when I tried to contribute for the first time. I forgot to add the -s flag to my commit (tbf, I didn't forget, I just didn't RTFM). So I made a new branch, re-committed my changes with the -s flag (signed-off-by), and made a new PR.

It was 10 minutes of work and a valuable lesson learned.

from proj4j.

paulushub avatar paulushub commented on July 22, 2024

@Neutius Thanks for the information. Unfortunately, I am not keeping a local repository of the proj4j or the local copy is not under git. The fork is just to track changes as I port the sources to .NET.
The changes I was submitting were simple; deleting all problematic lines from that class to get the tests to run without errors. Anyone could just add that to his/her own PR.

from proj4j.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.