Code Monkey home page Code Monkey logo

Comments (6)

dr-jts avatar dr-jts commented on July 22, 2024

Answer to the second question: I think it's acceptable to update the value to whatever value is returned by the new EPSG database (whether from proj4J itself, or some other source). Hopefully it is now correct! (Would be interesting to know why it has changed...)

Also, if the new value is simply less precise, perhaps the test precision should be reduced. (It's always a bit hard to figure out how values should be treated for the more obscure projections).

from proj4j.

dr-jts avatar dr-jts commented on July 22, 2024

For #1 - @lossyrob any ideas

from proj4j.

willcohen avatar willcohen commented on July 22, 2024

It seems like the epsg and world files in the nad folder are the two things that could use an update, and they come directly from proj.4. If the proj.4 project is, overall, MIT licensed, would it work to just put a reference in LICENSE to proj.4 and that it's MIT? If that sounds good, I can add that and update those two files.

from proj4j.

lossyrob avatar lossyrob commented on July 22, 2024

@willcohen yes, updating the database and changing any tests that had previous 'incorrect' values (according to the new DB params) makes a lot of sense. Thanks!

from proj4j.

willcohen avatar willcohen commented on July 22, 2024

Thanks, just submitted! Also -- for what's it worth, there did seem to be Eclipse IP validation hooks when I submitted PRs #2 and #3, though #7 didn't get one just now.

from proj4j.

lossyrob avatar lossyrob commented on July 22, 2024

Closed by #7

from proj4j.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.