lmfresneda / mention-hashtag Goto Github PK

hi . right now it does n`t support utf-8 characters in text . ( cant tokenize them ) .
for example :

let text = " یک متن #فارسی و یکمم #En برای #تست همه چی !";
let hashtags = mentionHashtag(text,{ symbol: false, type: '#' });
the result is : [ 'یکمتن#فارسیویکمم#ENG' ]

The currect result should be : ['فارسی','تست','Eng']

can you change the regex to support utf-8 texts ?
thanks.

They would be useful for those of us using TS.

Here's the current definition I'm using:

declare module 'mention-hashtag' {
  export enum ExtractionType {
    MENTION = '@',
    HASH_TAG = '#',
    ALL = 'all',
  }
  export type ExtractionOptions = { type: ExtractionType; unique: boolean; symbol: boolean };
  export type ExtractionResult = { mentions: string[]; hashtags: string[] };

  function extract(text: string, options: ExtractionType.ALL): ExtractionResult;
  function extract(
    text: string,
    options: ExtractionOptions | ExtractionType.MENTION | ExtractionType.HASH_TAG,
  ): string[];

  export default extract;
}

I'm not sure if its the best approach, but it does the work. Are you OK with a PR for this?

Is it possible to support combined hashtags, without spaces?

For example: #tag1#tag2#tag3
must return: [tag1 , tag2 , tag3]

Current version returns an empty array for this.

Thanks

Any plans to support emoticon hashtags? #😄