llsourcell / lstm_networks Goto Github PK

for i range(1, self.rl+1): should be for i in range(1, self.rl+1):

self.oa[i] self.sigmoid(np.dot(self.w, hs)) should be self.oa[i] = self.sigmoid(np.dot(self.w, hs))

def LoadText(): had a space before it that caused an error. The following lines in the function had

similar issues

Hi,

Current formulation of dphs is

dphs = np.dot(dc, self.c)[:self.ys] + np.dot(do, self.o)[:self.ys] + np.dot(di, self.i)[:self.ys] + np.dot(df, self.f)[:self.ys] 

I think it should be:

dphs = np.dot(dc * self.dtangent(c), self.c)[:self.ys] + np.dot(do * self.dtangent(o), self.o)[:self.ys] + \
                 np.dot(di * self.dtangent(i), self.i)[:self.ys] + np.dot(df * self.dtangent(f), self.f)[:self.ys]

dtangent is missing from the derivation. Is that correct?