lloyd / connect-etagify Goto Github PK

I don't know if my nginx config or CloudFlare is contributing to this, but I get a strange set of headers instead of an ETag header. Using node v0.8.21 and Express 3.1.0.

HTTP/1.1 200 OK
Server: cloudflare-nginx
Date: Mon, 04 Mar 2013 05:13:06 GMT
Content-Type: application/json; charset=utf-8
0: E
1: T
2: a
3: g
X-Powered-By: Express
Cache-Control: private
...

Hi!
I'm trying to use your package but when using with express 3.4.x it is throwing an error:

TypeError: Object #<ServerResponse> has no method 'etagify' // res.etagify();

doh! ETags can haz HTTP 1.1, and not HTTP 1.0 (that'd be Last-Modified).

Or does it grow indefinitely ?

I'm pretty sure you're supposed to build the lookup key from the request headers specified in the Vary response header. So if the response indicated Vary: Accept-Encoding, Accept-Language you wouldn't actually store [ 'Accept-Encoding', 'Accept-Language' ] in your data structure, I think you're supposed to store the tuple of [req.path, "gzip,deflate,sdch", "en-US,en;q=0.8"] (assuming Chrome user agent used in request). And you probably need to handle Vary: * specially.

Ideally though, as mentioned in issue #1, you'd just buffer the content and calculate the ETag directly, in which case the Vary header should be irrelevant since you're not actually acting as a cache. (i.e., if issue #1 is resolved by calculating ETag every single time, this issue becomes invalid.)