Code Monkey home page Code Monkey logo

color-toy's Introduction

Color picking app (test excersise)

Start

This app is bootstrapped with create-react-app. You can run it with npm run start and test with npm run test after npm i.

Few notes for reviewers

  • I changed a little autosuggest requirement to filtered list, because it seemed more visually interesting to me. However to change it to more classic autosuggest, it only requires to hide list if search query length <= 2.
  • I filter results with checking if either name and color hex contains string, not starting with it.
  • I used Rematch to reduce boilerplate of redux. I discovered it recently and can't wait to try it. I enjoy it but I see it's design flaw, based on singleton.
  • I'd use Typescript or Flowtype at least for services. React components may be typed enough with PropTypes, but I don't like limitation of IDE support. It also covers big part of testing and scalability.
  • I'd implement Storybook for visual testing and standalone development
  • About tests: I added some units for services and model logic. I also used snapshot testing for quick tests of HTML markup. I don't have much experience of e2e testing so I decided not to fake it ;) I also worked with manual QA teams. I don't have strong opinion about snapshots, but I think it can be developer-friendly improvement instead of manually check each class and node rendered.

color-toy's People

Contributors

lkostrowski avatar

Watchers

 avatar  avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.