liweiyap / narradir-android Goto Github PK

Phone model: Samsung Galaxy A3 (2016)
Phone API: 24 (Nougat)

Emulator model: Pixel XL
Emulator API: 30 (R)

Case 1:

• 5-player mode
• Uncheck Merlin, so the current characters are: Loyal0, Loyal1, Loyal2, Minion0, and Minion1.
• Check Mordred, so the current characters are: Merlin, Percival, Loyal0, Assassin, and Mordred.
• A double click sound is heard, because when checking Mordred, the function performClick() is called on Mordred (first click sound) and then on both Merlin and Percival (second and third click sounds overlap).
• This is simply due to how the selection rules are written in CharacterSelectionActivity.

It seems that the double click sound is heard only on the phone, but hardly on the emulator. This could be because the phone model/API is old, or because of lag issues?

Whatever the case, in my opinion, the double click sound has no real adverse effect on character selection. Hence, I won't be fixing this. Someone else is welcome to fix this if he/she is interested to help improve the user experience.

Exactly the same problem encountered here:

• https://stackoverflow.com/questions/31198923/preventing-android-navigation-and-action-bars-from-appearing-when-switching-acti
• https://stackoverflow.com/questions/34394916/why-navigation-bar-is-appearing-in-fullscreen-apps-when-clicked-on-popup-menu

This, despite update to FullScreenPortraitActivity in commit 014d119

Variables deprecated in API level 30:

• FLAG_FULLSCREEN: Use WindowInsetsController#hide(int) with Type#statusBars() instead.
• SYSTEM_UI_FLAG_IMMERSIVE_STICKY: Use WindowInsetsController#BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE instead.
• SYSTEM_UI_FLAG_LAYOUT_STABLE: Use WindowInsets#getInsetsIgnoringVisibility(int) instead to retrieve insets that don't change when system bars change visibility state.
• SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION: For floating windows, use LayoutParams#setFitInsetsTypes(int) with Type#navigationBars(). For non-floating windows that fill the screen, call Window#setDecorFitsSystemWindows(boolean) with false.
• SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN: For floating windows, use LayoutParams#setFitInsetsTypes(int) with Type#statusBars(). For non-floating windows that fill the screen, call Window#setDecorFitsSystemWindows(boolean) with false.
• SYSTEM_UI_FLAG_HIDE_NAVIGATION: Use WindowInsetsController#hide(int) with Type#navigationBars() instead.
• SYSTEM_UI_FLAG_FULLSCREEN: Use WindowInsetsController#hide(int) with Type#statusBars() instead.
• setSystemUiVisibility(int): Use WindowInsetsController instead.

I'm having problems with my emulator again, and my phone is below API level 30, so I can't work on this until I have access to a device/emulator that is at least API level 30.

Observed this on Samsung Galaxy A3 (2016), which is Android 7 (API 24), but not on Samsung Galaxy A32 5G, which is Android 11 (API 30).

Tried several things but none of them worked:

• Changed wrapper RelativeLayout to ConstraintLayout
• Removed wrapper RelativeLayout altogether
• Handle density configChanges in AndroidManifest

The problem can be remedied (temporarily) only if we quit the app completely and restart it.