livelykernel / lively.ast Goto Github PK

View Code? Open in Web Editor NEW

4.0 16.0 0.0 9.51 MB

Parsing JS code into ASTs and tools to query and transform these trees.

JavaScript 99.73% HTML 0.27%

parse-js javascript code-transformation ast

lively.ast's People

Contributors

Stargazers

Watchers

lively.ast's Issues

Errors when using `printAst` and other helper methods related to parsed ASTs

In versions 0.9.0 and up, I can't successfully call any of the AST helper methods.

> var ast = require('lively.ast')
undefined
> ast.printAst(ast.parse("1 + 2"))
TypeError: Cannot read property 'string' of undefined
    at Object.printAst (<yadda\yadda>\node_modules\lively.ast\dist\lively.ast.js:12910:23)
    at repl:1:5
    at sigintHandlersWrap (vm.js:32:31)
    at sigintHandlersWrap (vm.js:96:12)
    at ContextifyScript.Script.runInContext (vm.js:31:12)
    at REPLServer.defaultEval (repl.js:308:29)
    at bound (domain.js:280:14)
    at REPLServer.runBound [as eval] (domain.js:293:12)
    at REPLServer.<anonymous> (repl.js:489:10)
    at emitOne (events.js:101:20)
>

The code above works fine if I use 0.8.1.

lively.ast.parseFunction: Uncaught (in promise) TypeError: visitor[(override || node.type)] is not a function

when using livley.ast

lively.ast.parseFunction("function() { 3 + 4}")

We got an error:

lively.modules-with-lively.vm.js:9524 Uncaught (in promise) TypeError: visitor[(override || node.type)] is not a function
    at c (https://lively-kernel.org/lively4/lively4-jens/src/external/lively.modules-with-lively.vm.js:9524:35)
    at Object.recursive (https://lively-kernel.org/lively4/lively4-jens/src/external/lively.modules-with-lively.vm.js:9525:5)
    at forEachNode (https://lively-kernel.org/lively4/lively4-jens/src/external/lively.modules-with-lively.vm.js:18234:10)
    at addSource (https://lively-kernel.org/lively4/lively4-jens/src/external/lively.modules-with-lively.vm.js:18293:12)
    at Object.parseFunction (https://lively-kernel.org/lively4/lively4-jens/src/external/lively.modules-with-lively.vm.js:18832:32)

By not using "addSource" we got rid of the error... what does it do?

lively.ast.parseFunction =  function parseFunction(source, options) {
    var src = '(' + source + ')',
        ast = lively.ast.parse(src, options);
    // /*if (options.addSource) */addSource(ast, src);
    return ast.body[0].expression;
  }

endless loops

despite of cfb7db5 there are still endless loops that cause freezes and browser crashes. To reproduce:

lively.next -> open modules browser
open lively.ast/lib/query.js

@levjj

capturing definition wrapper

When using a definition wrapping function via lively.ast.capturing.rewriteToCaptureTopLevelVariables(..., {declarationWrapper: astForDeclFunc}) then simple assignments are correctly wrapped:

i = i+1 becomes _rec.i = _rec._define('i', 'assignment', _rec.i + 1, _rec);

However, expressions like i++ or i+=1 aren't correctly identified as modifications and not wrapped.

Fix that!

livelykernel / lively.ast Goto Github PK

lively.ast's People

Contributors

Stargazers

Watchers

lively.ast's Issues

Errors when using `printAst` and other helper methods related to parsed ASTs

lively.ast.parseFunction: Uncaught (in promise) TypeError: visitor[(override || node.type)] is not a function

endless loops

capturing definition wrapper

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent