livebg / smstools Goto Github PK

I can't find anywhere on the internet that suggests carriers support ascii encoding. It looks like it was added to this repo as a restricted form of the GSM-7 encoding, however with the ascii encoding we get slightly different behaviour. For example, in ascii, unlike GSM-7, we don't escape characters like [ and ] meaning we can end up with shorter messages.

I'm not sure what the original intention was behind adding ascii support. If it was to just define a restricted set of GSM-7 characters before switching to UCS-2, then I think we should still treat characters like [ as requiring an escape character regardless of whether we're in ascii or GSM-7 encoding. Otherwise I think we should allow opting out of ascii encoding. Happy to do the PR myself :)

I was using this to detect if twilio would break up the messages I was sending. However, this gem doesn't detect non-breaking spaces. It still identifies the message as gsm even if it has them.