Code Monkey home page Code Monkey logo

Comments (13)

github-actions avatar github-actions commented on July 21, 2024

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

from docker-code-server.

aptalca avatar aptalca commented on July 21, 2024

Why don't you use the mod for it?
https://github.com/linuxserver/docker-mods/tree/code-server-dotnet

from docker-code-server.

Nefcanto avatar Nefcanto commented on July 21, 2024

Really? You have a .NET SDK image and you have named it mod. I searched your repository to find .NET and I simply couldn't. Then I scanned all of your repositories and still didn't find anything, because mod is not a name that is familiar to a .NET developer.

That's great news. I'll test it right away.

from docker-code-server.

Nefcanto avatar Nefcanto commented on July 21, 2024

It's very difficult to understand.

However, I added this environment variable to my docker-compose.yml to test it:

- DOCKER_MODS=linuxserver/mods:code-server-dotnet

And after running docker-compose up it's now stuck in this phase:

Recreating code-server ... done
Attaching to code-server
code-server | [mod-init] Attempting to run Docker Modification Logic

But to be honest, your entire repo is very difficult to understand. I wish you could have a simple code snippet, like an installation script that we could use to add code-server to an existing image. Do you have that?

from docker-code-server.

Roxedus avatar Roxedus commented on July 21, 2024

Docker mods is our way to extend our images.

from docker-code-server.

Nefcanto avatar Nefcanto commented on July 21, 2024

@Roxedus that's awesome, however, I couldn't simply use it.

I found this which worked very easily.

My feedback is that you should simplify access to your images. Because your idea is awesome, but I'm one simple case of failure in being able to use them.

Thank you so much for your great work.

from docker-code-server.

Roxedus avatar Roxedus commented on July 21, 2024

We link to mods in all our readmes. Anything built on top of our images is not getting support by us.

from docker-code-server.

aptalca avatar aptalca commented on July 21, 2024

And after running docker-compose up it's now stuck in this phase:

It's not stuck, it's downloading the mod

Really? You have a .NET SDK image and you have named it mod

It's not an image and we didn't name it mod. It is a mod (short for modification), one of many we publish. They are all linked in the readmes

from docker-code-server.

Nefcanto avatar Nefcanto commented on July 21, 2024

@Roxedus your work is great. However, as a developer who knows little about all those fancy Linux commands, I was searching for something to be used in my FROM some_image_with_code_server_and_dotnet line in my Dockerfile.

Since you guys are gurus at this, I recommend that you deploy such images.

from docker-code-server.

tobbenb avatar tobbenb commented on July 21, 2024

Why is that a better way than what we are doing now?
The way it's now, you add an env variable for the mod and recreate the container and it's installed. You just have to be patient and wait for it to finish installing.
It can't be much easier than that.

from docker-code-server.

Nefcanto avatar Nefcanto commented on July 21, 2024

And each time a developer wants to create a container he has to wait a ton of time?
Containers are ephemeral by nature. We destroy them and recreate them frequently.
Containers should be up and running in seconds. Any initialization that takes a long time is a bad decision for a container.

You should embody that in an image, not at the start of the container. Of course, that's a bad decision. There is no arguing that.

Just download any image with over 100M downloads and run a container on top of it and measure the time it takes to load. You'll understand.

That being said, I understand that open-source means spending time free for others. And it's a valuable thing to do, and I'm doing it myself and I'm thankful to you for that. However, it does not mean that others can't help or criticize for improvement.

from docker-code-server.

tobbenb avatar tobbenb commented on July 21, 2024

Then you are free to do it as you want. You don't have to use our images of you don't like them.

from docker-code-server.

Nefcanto avatar Nefcanto commented on July 21, 2024

That's exactly what I'm doing now. But it's feedback from one person for you. I loved your image, yet I could not use it because of many design flaws in them. Root user support and hardcoded images are two of them. I just say you could support more developers if you only changed a couple of small things.

Anyway, thank you so much for your valuable works and time.

from docker-code-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.