linuxha / node-red-contrib-mytimeout Goto Github PK

View Code? Open in Web Editor NEW

10.0 4.0 10.0 232 KB

A dynamic count down timer for node-red

License: MIT License

HTML 4.21% JavaScript 83.07% Shell 12.72%

node-red-contrib node-red timer countdown

node-red-contrib-mytimeout's People

Contributors

Stargazers

Watchers

Forkers

readeral mmastria ontje brammh cwooldridge swipswaps rafterk wgoetz55 0nikola1

node-red-contrib-mytimeout's Issues

unwanted starting of countdown

Everytime I restart the node red server the countdown of mytimeout starts and puts a "1" on the output. I'm working with ubuntu 20.04.2 LTS, Node-RED 1.2.3 and mytimeout 3.2.0. Any help on this is appreciated. Thanks

Timer does not stop for FLOAT timeout values

Hi, I was experimenting a bit further with your timeout.

I have a calculated timeout which is a float value. When passing the float ast msg.timeout into your

The timer is accepting the float
The timer is counting down
->> The counter never stops as it does not reach 0

[{"id":"7dd3409d.0daae","type":"mytimeout","z":"b1d09add.6b04a8","name":"timer","outtopic":"","outsafe":"on","outwarning":"Warning","outunsafe":"off","warning":"5","timer":"20.001","debug":"0","repeat":false,"again":false,"x":510,"y":380,"wires":[["559dcc7d.65e6f4"],["559dcc7d.65e6f4"]]},{"id":"745c54b6.b9a71c","type":"inject","z":"b1d09add.6b04a8","name":"","topic":"","payload":"","payloadType":"date","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":120,"y":380,"wires":[["cd407dbc.6a09"]]},{"id":"cd407dbc.6a09","type":"change","z":"b1d09add.6b04a8","name":"timeout","rules":[{"t":"set","p":"timeout","pt":"msg","to":"6.1234567","tot":"str"},{"t":"set","p":"payload","pt":"msg","to":"ON","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":320,"y":380,"wires":[["7dd3409d.0daae"]]},{"id":"559dcc7d.65e6f4","type":"debug","z":"b1d09add.6b04a8","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","x":710,"y":380,"wires":[]}]

Warning output doesn't contain extra attributes like the on and off messages do.

L495: newMsg(inMsg): RangeError: Maximum call stack size exceeded

After updating to 3.0.1, I'm getting the following error: "L495: newMsg(inMsg): RangeError: Maximum call stack size exceeded <{"payload":

It doesn't prevent the node from running but the error pops up everytime it runs.

Pause?

What's your recommended method of pausing? The 'restarting' obviously can (essentially) become a new timer with the value of the timer when it stopped, but 'stop' setting payload to 0 seems a little counterintuitive to me.

Would you consider 'Stop' retain the payload for restarting, feeding that payload value back in to the node again upon a trigger? Alternatively, would you consider a "pause" action? Would be nicer than needing to maintain my own state of the timer external to the timeout node.

Otherwise Stop and Cancel are essentially the same, just one notifies you about it (on the first output), and the other doesn't.

Feature Request: Allow the Timer On Payload

Inject json to override default values. Odd behavior.

Hi. I'm not sure if I'm doing something wrong but I can't seem to pass the msg directly out of the function node from your example, into the mytimeout timer and have it read the override values correctly. It keeps using the default values.

However if I pass the output of the function through a JSON node and then into mytimeout node, it works.

I couldn't figure this out for a while as your example looks like its passing the function output directly to the mytimeout node.

Is this expected?

Thank you!

This is not working:
https://hastebin.com/nibefacore.json
I pass directly out of function to mytimeout

This is working:
https://hastebin.com/geciwoduka.json
I pass through json node and then to mytimeout

ps: There is a small typo on the info page inside NR.

Feature Request: Allow the "Timer On Payload" to work like the "Warning state payload"

In some cases, specifically connecting to non-MQTT nodes, the ability to not send the payload further down stream until the off event is triggered, would be very helpful. Right now, I'm filtering it with a switch node first.

Output Topic - not coming out

Hi ,
I'm using your timer for many flows. I had not used the "Output topic" before but in my current flow it does not come to the output and I have to set the "topic" manually. A debug-node was showing empty Topic content.
I'm using your latest version and the node node-red-contrib-simple-gate

[{"id":"49c07f1b.63b48","type":"gate","z":"ebaeea0a.a6df68","name":"","controlTopic":"control","defaultState":"open","openCmd":"open","closeCmd":"close","toggleCmd":"toggle","defaultCmd":"default","x":650,"y":240,"wires":[["3bccad86.0811b2","9d9fed9b.0875f"]]},{"id":"9d9fed9b.0875f","type":"mytimeout","z":"ebaeea0a.a6df68","name":"outage","outtopic":"control","outsafe":"close","outwarning":"","outunsafe":"Open","warning":"5","timer":"3600","debug":false,"ndebug":false,"ignoreCase":false,"repeat":false,"again":false,"x":630,"y":180,"wires":[["2864c9f4.bd6b66"],[]]},{"id":"2864c9f4.bd6b66","type":"change","z":"ebaeea0a.a6df68","name":"ctrl","rules":[{"t":"set","p":"topic","pt":"msg","to":"control","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":750,"y":180,"wires":[["49c07f1b.63b48"]]},{"id":"3bccad86.0811b2","type":"function","z":"ebaeea0a.a6df68","name":"Set temp","func":"var temp1 = parseInt(msg.payload.tempc);\nvar speed = parseInt((msg.payload.windspeed)*3.6);\nmsg.payload.tempc = temp1;\nmsg.payload.windspeed = speed;\nreturn (msg);","outputs":1,"noerr":0,"x":810,"y":240,"wires":[["791b24dd.eb735c"]]}]

Warning sent when setting countdown to low value eg. `3` and warning param to 0 in GUI

A msg.warning of 0 doesn't override the GUI setting to cancel sending a warning message

A msg.warning of 0 doesn't override the GUI setting to cancel sending a warning message
If I send a message like this:
{ "payload": "on", "timeout": 4, "warning": 0 }
I still get the warning message sent on first output
{ "payload":"warn" }
The problem is being investigated

mytimeout is still case sensitive

V2.1.1 is still case sensitive (oops). I'll work on that and get that out in a few days

Topic Using Mustache

Is it possible to allow mustache format in the setup of the node, such as setting the topic to be {{msg.topic}} and it would take the input topic and set the outgoing msg topic? Ideally this would apply to all input variables.

Should I pass in a JSON string or a javascript object?

The documentation says that we can pass in JSON containing attributes such as payload and timeout. Does this actually mean that I have to construct a JSON string containing the structure or should it be a javascript object containing the values?

stop or cancel not working

Version [email protected]
When I send the following payload when a timer is already started , the countdown freeze and does not send a cancel payload
{
"payload": "cancel"
}

Also your documentation is wrong its 'timer' instead of 'timeoute'

Thanks for your job

Timer stops at 13s when timer set to 1h (3600s)

When setting the timer to expire after one hour, the countdown stops always at 13 seconds.

Which make the time kind of unusable.

Please take a look at this.

Add topic to 2nd output

please, add topic to all outputs) it will help

The workspace contains some nodes that are not properly configured ...

I've noticed another minor issue with an error message that pops up on deploy of the new timers.

"The workspace contains some nodes that are not properly configured: ... are you sure you want to deploy."

You can deploy it's harmless and I have a manual fix but I need to figure out how to word it.

This has to do with my change from a text box to a checkbox. I'm trying to work on a solution so we don't need the manual steps.

How to set timeout value dynamically ?

Hi Neil,

In order to optimize and simplify my workflow drastically, I would like to put in the timeout value as part of the payload. I have tried multiple combinations, but I always get a NaN when I start the timer.

I fear the mytimer is unable to accept its timeoute/timeout/timer value from the incoming payload.

Given following example workflow, can you change the switch so the timer can be set to either input value ?

Thanks,
Tran

[{"id":"183764d3.7dc30b","type":"mytimeout","z":"fd7a7f8d.a9edc","name":"","outtopic":"","outsafe":"ON","outwarning":"OFF","outunsafe":"OFF","warning":"1","timer":"","limit":"","repeat":false,"again":false,"x":530,"y":200,"wires":[["a8a646f4.6becc8"]]},{"id":"f0ec29f6.98bf78","type":"inject","z":"fd7a7f8d.a9edc","name":"","topic":"","payload":"30","payloadType":"num","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":110,"y":180,"wires":[["cbdc8a80.4524d8"]]},{"id":"8c7644a0.242c38","type":"inject","z":"fd7a7f8d.a9edc","name":"","topic":"","payload":"60","payloadType":"num","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":110,"y":220,"wires":[["cbdc8a80.4524d8"]]},{"id":"cbdc8a80.4524d8","type":"change","z":"fd7a7f8d.a9edc","name":"","rules":[{"t":"set","p":"timeoute","pt":"msg","to":"payload","tot":"msg"},{"t":"set","p":"payload","pt":"msg","to":"ON","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":340,"y":200,"wires":[["183764d3.7dc30b","a532595b.a40a88"]]},{"id":"a8a646f4.6becc8","type":"debug","z":"fd7a7f8d.a9edc","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","x":730,"y":200,"wires":[]},{"id":"a532595b.a40a88","type":"debug","z":"fd7a7f8d.a9edc","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","x":530,"y":260,"wires":[]}]

Tick interval

I think it would be great if we can setup tick interval value in node settings?

First countdown msg is a string !

Hello,
I get a strange behavior, on second output for the countdown the first sent msg is a string then all next are number than expected. Below a debug log, for a timeout of 600s.
It’s not a big issue, just the first value are not displayed on the dashboard.
Thank you

18.07.2019 à 15:06:13node: MyTimeout
msg.payload : string[3]
"600"
18.07.2019 à 15:06:13node: MyTimeout
msg.payload : number
599
—-> all next output are number format

Timer stop counting down occasionally

Hi I have changed all my timers to your mytimeout timer, and it usually works perfectly.

Frequently , the countdown stops counting down (still showing Running: 45). I had established debug pointers before and after the timer but there was no event/trigger to halt the countdown... it just stopped

Below is a code component I use to trigger my lights and keep them running for period of time.

Time remaining (Output 2) is not in msg.payload

Output 2 contains:

msg = {
    "payload": {
        "payload":30,
        "state":1,
        "flag":"ticks > 0"
    }
}

should be:

msg = {
    "payload":30,
    "state":1,
    "flag":"ticks > 0"
}

"TypeError: node.warn is not a function"

Receiving the following error after upgrading to 2.2.2
"TypeError: node.warn is not a function"

Running node-red 0.19.1

Run different instances of timer based on msg.topic

I would like to have a functionality which the original delay node in node-red has, variable delay per message topic which allows us to run multiple instances of the timer based on the msg.topic value passed to the node. I tried doing the same with the mytimeout and new invocations always reset the timer. Would be really nice to keep multiple timers running.

Sample Flow:

[
    {
        "id": "e9c0e6e2.b401f8",
        "type": "mytimeout",
        "z": "d24adb51.bd89f8",
        "name": "",
        "outtopic": "",
        "outsafe": "on",
        "outwarning": "",
        "outunsafe": "off",
        "warning": "5",
        "timer": "30",
        "debug": false,
        "ndebug": false,
        "ignoreCase": false,
        "repeat": false,
        "again": false,
        "x": 1330,
        "y": 220,
        "wires": [
            [
                "28a04c14.1e2fa4"
            ],
            []
        ]
    },
    {
        "id": "37366a80.05b1a6",
        "type": "inject",
        "z": "d24adb51.bd89f8",
        "name": "",
        "topic": "",
        "payload": "{\"payload\":\"on\",\"timeout\":50,\"warning\":30,\"topic\":\"foo\"}",
        "payloadType": "json",
        "repeat": "",
        "crontab": "",
        "once": false,
        "onceDelay": 0.1,
        "x": 950,
        "y": 200,
        "wires": [
            [
                "69883483.758bdc"
            ]
        ]
    },
    {
        "id": "28a04c14.1e2fa4",
        "type": "debug",
        "z": "d24adb51.bd89f8",
        "name": "",
        "active": true,
        "tosidebar": true,
        "console": false,
        "tostatus": false,
        "complete": "false",
        "x": 1540,
        "y": 220,
        "wires": []
    },
    {
        "id": "69f9a286.29315c",
        "type": "inject",
        "z": "d24adb51.bd89f8",
        "name": "",
        "topic": "",
        "payload": "stop",
        "payloadType": "str",
        "repeat": "",
        "crontab": "",
        "once": false,
        "onceDelay": 0.1,
        "x": 1050,
        "y": 320,
        "wires": [
            [
                "e9c0e6e2.b401f8"
            ]
        ]
    },
    {
        "id": "2685c496.bfdf3c",
        "type": "inject",
        "z": "d24adb51.bd89f8",
        "name": "",
        "topic": "",
        "payload": "pause",
        "payloadType": "str",
        "repeat": "",
        "crontab": "",
        "once": false,
        "onceDelay": 0.1,
        "x": 1050,
        "y": 400,
        "wires": [
            [
                "e9c0e6e2.b401f8"
            ]
        ]
    },
    {
        "id": "c665e6ad.370bb8",
        "type": "inject",
        "z": "d24adb51.bd89f8",
        "name": "",
        "topic": "",
        "payload": "{\"payload\":\"on\",\"timeout\":20,\"warning\":10,\"topic\":\"bar\"}",
        "payloadType": "json",
        "repeat": "",
        "crontab": "",
        "once": false,
        "onceDelay": 0.1,
        "x": 930,
        "y": 260,
        "wires": [
            [
                "69883483.758bdc"
            ]
        ]
    },
    {
        "id": "69883483.758bdc",
        "type": "change",
        "z": "d24adb51.bd89f8",
        "name": "",
        "rules": [
            {
                "t": "set",
                "p": "topic",
                "pt": "msg",
                "to": "payload.topic",
                "tot": "msg"
            }
        ],
        "action": "",
        "property": "",
        "from": "",
        "to": "",
        "reg": false,
        "x": 1120,
        "y": 200,
        "wires": [
            [
                "e9c0e6e2.b401f8"
            ]
        ]
    }
]

strange behaviour, does not turn off , or even turns on instead

I have this system with automatic lights, based on PIR with RF and wall switches with RF .
Timers reset while PIR activity , and when time runs almost out, a warning light starts blinking. Then the lights go off.
That should be the case.
However, the timers do not always send the OFF command.
Sometimes they even send the ON command and not start the timer... so the lights stay on all night.
I am switching to wall light switches with Tasmota and RF soon because of this unreliability.
timersflowexample.json.txt

... edit: I discovered a typo in one of the PIR-RF received data-switches.