Comments (3)
Bean-Li
commented on June 26, 2024
1
OK， I will send a PR later.
from nvme-cli.
igaw
commented on June 26, 2024
Indeed, it looks like I mixed up pract with prinfo. So your suggested changes looks good to me. Would you mind to send a proper PR for this?
@keithbusch do you agree?
from nvme-cli.
Bean-Li
commented on June 26, 2024
already fix in commit : f1fde3f .
so close this issue.
nvme: do not include meta data for PRACT=1 and MD=8 (version 2)
No meta data is transferred for PRACT=1 and MD=8:
5.2.2.1 Protection Information and Write Commands
5.2.2.2 Protection Informatio and Read Commands
commit https://github.com/linux-nvme/nvme-cli/commit/8dcac74470ec02870477e6881766fd74a24738fe (nvme: do not include meta data for PRACT=1 and MD=8)
the condition in if sentence is wrong, mixed up pract with prinfo.
Signed-off-by: Bean Li <[email protected]>
from nvme-cli.
Related Issues (20)
- Prometheus exporter for SMART and OCP C0 Log Page HOT 8
- set feature c5 fails on nvme-cli 1.13 HOT 4
- id-ctrl shows odd characters from tnvmcap HOT 1
- intel p4510 2TB namespaces that are allocated but not seen ? HOT 25
- Flush command with all namespace id 0xFFFFFFFF returns Invalid argument. HOT 4
- Consider disable NBFT when ACPI is not present HOT 1
- Fix code scanning alert - Potential use after free
- Fix code scanning alert - Comparison of narrow type with wide type in loop condition HOT 1
- Fix code scanning alert - Time-of-check time-of-use filesystem race condition HOT 1
- nvme set-feature quietly fails to set the power mode HOT 3
- Supported Log Pages crashed when using json output HOT 1
- Not a issue but a unexpected behaviour on different firmware on nvme ns size HOT 6
- [bug report]blktests nvme/029 failed from v2.7 on s390x HOT 5
- RFE: Perform actual discovery in discover_from_nbft() HOT 6
- nvme wdc cap-diag /dev/nvme0 - Decode HOT 3
- Fabrics connect for large number of connections too slow with v2.8 HOT 71
- Commands fail on nvme-cli 2.x when nvme_core module isn't loaded, regression from nvme-cli 1.x HOT 2
- nvme format fails HOT 6
- Wrong capacity for drive under usage with nvme-cli 2.8. HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nvme-cli.