linux-nvme / nvme-cli Goto Github PK

Hi, All

Maybe, there was a mistake to display Idle Power and Active Power.
In the NVMe Spec 1.2, Idle Power Scale is displayed with bit 151:150.
But in the source code, idle power scale argument is parsed with bitwise & 0x0.
I think idle power scale value is extracted with 0xC0.

Hi

Commit 15878d3 added a debian/changelog file. This breaks the Ubuntu PPA make flow since we auto-magically generate that file. I would rather not have this file in the repo. If you want you can have a changelog.debian file in the repo and copy it over when you build your package but a better option is to add echo commands to the Makefile like we did for deb-ppa.

Discuss ;-)

Stephen

I purchased Parted Magic to erase the drive in a new X1 Carbon 20FB-004QUS, however, although I can run Erase Disk - NVMe Secure Erase option and see the drive (Samsung MZVKV512HAJH-000L1), the erase process ends with "/dev/nvme0n1: Error! Disk is not erased". I then attempted a command line "nvme format /dev/nvme0n1 --ses=1", as well as "nvme format /dev/nvme0n1" (which a Parted Magic support forum admin confirmed is the command they use), but in both cases I get "Admin command error:INVALID_OPCODE(2001)" as the result. The Parted Magic forum admin requested that I contact you directly for assistance. Any feedback on how to correctly secure erase this drive is appreciated.

Thank you.

The packages being release, as 0.3, 0.4 do NOT contain the version file, and it is not also part of a git archive, which means that the version shows up as 0.1

This is one of the problem we have at Ubuntu and Debian at the moment.

I suggest that we generate a version file and update it before each release commit, and make the git tag on top of this commit.

regress issues read/write command with --data_size=4k,
however argconfig_type in submit_io()'s data_size is "CFG_POSITIVE".
I guess either

• replace CFG_POSITIVE as CFG_LONG_SUFFIX in nvme.c line 2608
  or
• replace RAND_SIZE=4k as RAND_SIZE=4096 in regress line 29
  may be applied.

c8aab96

Not sure if this is in the planned list already, but decoding of the hex codes (at least the non-vendor-specific ones) would be very helpful. As is, for those not familiar with the spec (myself included), decoding them manually is very difficult.

(When testing NVMe drives in an assembled system, it is desirable to understand why the error counter is incrementing, not just that it is.)

environment

1. nvme-cli version 1.0
2. ubuntu 14.04.5 kernel 4.1.10

steps to reproduce

1. make && make install
2. nvme list --output-format=json
3. returns "Segmentation fault"

dmesg
[ 2947.885599] nvme[26026]: segfault at 0 ip 00007f74d1274ebc sp 00007ffd8ffd6820 error 4 in libc-2.19.so[7f74d1206000+1ba000]
[ 2974.819305] nvme[27464]: segfault at 0 ip 00007f31ac4b9ebc sp 00007ffd5c36a410 error 4 in libc-2.19.so[7f31ac44b000+1ba000]
[ 3054.771953] nvme[29480]: segfault at 0 ip 00007f1df528debc sp 00007fff24d03850 error 4 in libc-2.19.so[7f1df521f000+1ba000]

Note other commands formatted w/ json output work w/o issue (only nvme list has the fault)

1. nvme id-ctrl /dev/nvme0 --output-format=json
2. nvme fw-log /dev/nvme0n1 -o json

Hi maintainers,

I found and fixed invalid opcode used in the nvme_resv_release() function. Please review and have it included in your project.

(https://github.com/DrYSOH/nvme-cli/tree/resv_release_fix)

Yongseok Oh

Hi

Right now the CLI compiles against a local copy of the uapi nvme.h file. This copy, of course, may differ, from the one the kernel (and nvme module if applicable) were compiled against. This can lead to all sorts of fun and games when we pass a structure we populated with the local header into the kernel IOCTL.

We need to find a better way of handling this. Usually the actually header the kernel was compiled with will be located at /lib/modules/$(uname -r)/build/include/uapi so maybe our Makefile should test for the existence of this file and use it when available and use the local file as a last resort. Or maybe we use a call to uname -r to bork if needed in the make process if we suspect the local header and kernel differ too much?

Stephen

Hi @sbates130272

Couple of observations in scripts/latency

*) Command in https://github.com/linux-nvme/nvme-cli/blob/master/scripts/latency#L89 will always fail, since the code greps for 'latency'
probably, should not call run_test for this command alone, which works perfectly fine.
*) Should we be giving some more latency analysis details, like average latency for the counts the test ran ?

When i issue get-feature for FID=3, I get a raw buffer out (nvme get-feature -f 3 -n 1)
But when I specify raw binary, I get a parsed output (nvme get-feature -f 3 -n 1 -b)

Hi Guys
i am facing problem in uses of the command mentioned in list:

i am able to use the first command but others i can not.i had done all the setup which required for using NVMe-Cli like compiling kernel version 3.19 and others done.just need the syntax to execute these command.can anyone help me.
Thanks
Rajnikant

Hi

Right now (as of 0x5dd4059...) the nvme list output is crude. Here is an example from one of my test machines:

/dev/nvme0n1 : NVM Express - 0x144d - SAMSUNG MZWEI800HAGM-00003 IPM0AB3Q8% - 0
/dev/nvme0n1p1 : NVM Express - 0x144d - SAMSUNG MZWEI800HAGM-00003 IPM0AB3Q8% - 0
/dev/nvme1n1 : NVM Express - 0x11f8 - MTR_SLC_8GB - 0
/dev/nvme2n1 : NVM Express - 0x111d - 89KTF1604G3MS1TL - 0

I propose we clean up the output. Add correct version handling and add a capacity/usage field. Other suggests welcome.

Stephen

Hi Guys,
I would like to add this patch to nvme-cli
add-fc-support.txt
tool to add support for a fibre-channel host address as well as a port address. If you are Ok with this change then I'll submit a pull request.:
nvme-cli: Add support for Fibre-channel host address

   Example:
    nvme connect-all --transport=fc --traddr=pn-0x200100110d9f4100:nn-0x200100110d9f4100 \
    --host_traddr=nn-0x20000024ff5ba062:pn-0x21000024ff5ba062

    nvme connect --transport=fc --nqn=nqn.2014-08.org.nvmexpress:nvm-subsystem \
    --traddr=pn-0x200100110d9f4100:nn-0x200100110d9f4100 --host_traddr=nn-0x20000024ff5ba062:pn-0x21000024ff5ba062

Thanks,
Duane

nvme error-log command has a default of 64 entries (--log-entries). This default value is causing errors on some devices that do not support 64 entries.

I would like the default value for log entries set to the maximum supported by the device. This is reported in "Error Log Page Entries (ELPE)" field in the ID controller data structure.

The the file nvme.c in the function static int nvme_passthru(int argc, char **argv, int ioctl_cmd) at line 2248 there is a typo assigning the cdw13 value to multiple fields. This makes many vendor specific commands unusable.

cmd.cdw2         = cfg.cdw13;
cmd.cdw3         = cfg.cdw13;
cmd.cdw10        = cfg.cdw13;
cmd.cdw11        = cfg.cdw13;
cmd.cdw12        = cfg.cdw13;
cmd.cdw13        = cfg.cdw13;
cmd.cdw14        = cfg.cdw14;
cmd.cdw15        = cfg.cdw15;
cmd.opcode       = cfg.opcode;
cmd.flags        = cfg.flags;
cmd.rsvd1        = cfg.rsvd;
cmd.nsid         = cfg.namespace_id;

I do have systemd-devel package installed, which contains udev headers. Udev itself is also obviously available since it's part of systemd.

Fedora 23 x86_64
Linux 4.4-rc4 from Fedora rawhide (doesn't seem relevant though)
systemd 222

Hi,

I am using the nvme-cli utility to read the smart-log off an NVME device. I was searching for descriptions of some of the parameters being reported. Here is my nvme smart-log output (below).

For example, I wanted to understand what data_units corresponds to (probably multiple kB from how much I wrote, but not sure what it is).

The context is that I am trying to write a monitoring script for NVMe cards that will invoke the smart-log command and report it for SSD wear/thresholds etc.

Apologies if this is not the right forum.

Thank you

-Sachin

user@node09:~$ sudo nvme smart-log /dev/nvme1n1
Smart Log for NVME device:/dev/nvme1n1 namespace-id:ffffffff
critical_warning : 0
temperature : 34 C
available_spare : 100%
available_spare_threshold : 10%
percentage_used : 0%
data_units_read : 203,913,228
data_units_written : 64,663,716
host_read_commands : 7,207,810,975
host_write_commands : 2,931,291,530
controller_busy_time : 399
power_cycles : 9
power_on_hours : 742
unsafe_shutdowns : 5
media_errors : 0
num_err_log_entries : 0
Critical Composite Temperature Time : 0
Temperature Sensor 1 : 0 C
Temperature Sensor 2 : 0 C
Temperature Sensor 3 : 0 C
Temperature Sensor 4 : 0 C
Temperature Sensor 5 : 0 C
Temperature Sensor 6 : 0 C
Temperature Sensor 7 : 0 C
Temperature Sensor 8 : 0 C

When running make on 32-bit ARM, the following compile errors are caused by casts from void* to __u64. This did not happen in v0.3, but does from v0.4 onwards, I assume due to the removal of the unsigned long casts that used to be present.

NVME_VERSION = 0.4.31.ge999
cc -I ./src -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.4.31.ge999"' -c ./src/argconfig.c
cc -I ./src -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.4.31.ge999"' -c ./src/suffix.c
cc -I ./src -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.4.31.ge999"' -c nvme-print.c
cc -I ./src -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.4.31.ge999"' -c nvme-ioctl.c
nvme-ioctl.c: In function ‘nvme_passthru’:
nvme-ioctl.c:68:15: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .metadata = (__u64) metadata,
               ^
nvme-ioctl.c:69:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .addr  = (__u64) data,
            ^
nvme-ioctl.c: In function ‘nvme_io’:
nvme-ioctl.c:99:15: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .metadata = (__u64) metadata,
               ^
nvme-ioctl.c:100:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .addr  = (__u64) data,
            ^
nvme-ioctl.c: In function ‘nvme_dsm’:
nvme-ioctl.c:191:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .addr  = (__u64) dsm,
            ^
nvme-ioctl.c: In function ‘nvme_resv_acquire’:
nvme-ioctl.c:225:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .addr  = (__u64) (payload),
            ^


nvme-ioctl.c: In function ‘nvme_resv_register’:
nvme-ioctl.c:242:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .addr  = (__u64) (payload),
            ^
nvme-ioctl.c: In function ‘nvme_resv_release’:
nvme-ioctl.c:259:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .addr  = (__u64) (payload),
            ^
nvme-ioctl.c: In function ‘nvme_resv_report’:
nvme-ioctl.c:271:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .addr  = (__u64) data,
            ^
nvme-ioctl.c: In function ‘nvme_identify’:
nvme-ioctl.c:295:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .addr  = (__u64) data,
            ^
nvme-ioctl.c: In function ‘nvme_get_log’:
nvme-ioctl.c:328:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .addr  = (__u64) data,
            ^
nvme-ioctl.c: In function ‘nvme_feature’:
nvme-ioctl.c:373:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .addr  = (__u64) data,
            ^
nvme-ioctl.c: In function ‘nvme_ns_create’:
nvme-ioctl.c:428:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .addr  = (__u64) ((void *)&ns),
            ^
nvme-ioctl.c: In function ‘nvme_ns_attachment’:
nvme-ioctl.c:460:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .addr  = (__u64) cntlist,
            ^
nvme-ioctl.c: In function ‘nvme_fw_download’:
nvme-ioctl.c:487:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .addr  = (__u64) data,
            ^
nvme-ioctl.c: In function ‘nvme_sec_send’:
nvme-ioctl.c:511:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .addr  = (__u64) data,
            ^
nvme-ioctl.c: In function ‘nvme_sec_recv’:
nvme-ioctl.c:532:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
   .addr  = (__u64) data,
            ^
cc1: all warnings being treated as errors
Makefile:37: recipe for target 'nvme-ioctl.o' failed
make: *** [nvme-ioctl.o] Error 1

We all loathe autotools for good reasons, but it is does provide some nice features that nvme-cli will want or already implements itself:

1. easy cross compilation
2. configurable locations for everything (prefix, destdir, sysconfdir)
3. detection of libraries (libudev), headers (nvme.h or nvme-ioctl.h), and struct members
4. handles version substitution in source files

Out of all these I think number three can provide us some real benefits: we can generate defines for certain fields in struct nvme_id_ctrl, and what ioctls are available (eg use for #57).

Is this something people are interested in? I can issue a PR if so.

Hi all maintainers and contributors,

My name is Yongseok Oh, working on developing firmware S/W for NVMe SSDs at SK telelecom in South Korea. I believe the end to end data protection feature is very important in enterprise class storage systems. However, it is hard to find a test methodology and script for this issue. As a result, I decided to develop a test script using the NVMe CLI tool. This is very helpful and useful to evaluate and test this feature when developing NVMe SSDs.

Please, review and have it included in your project.
(https://github.com/DrYSOH/nvme-cli)

Yongseok Oh

Using version 0.7 I can issue nvme fw-log command. but version 0.8 fails for same command.

[root@tom400 nvme-cli-0.7]# nvme fw-log /dev/nvme4
Firmware Log for device:nvme4
afi : 0x44
frs1 : 0x4b4d495050313037 (KMIPP107)
frs2 : 0x4b4d495050313037 (KMIPP107)
frs3 : 0x4b4d495050313037 (KMIPP107)
frs4 : 0x4b51495050313131 (KQIPP111)

[root@tom400 nvme-cli-master.8]# nvme fw-log /dev/nvme4
NVMe Status:INVALID_FIELD(4002)
[root@tom400 nvme-cli-master.8]#

System is IBM Power 8
Linux tom400 3.10.0-327.22.2.el7.ppc64 #1 SMP Thu Jun 9 10:31:21 EDT 2016 ppc64 ppc64 ppc64 GNU/Linux
[root@tom400 nvme-cli-master.8]# cat /etc/*release
NAME="Red Hat Enterprise Linux Server"
VERSION="7.2 (Maipo)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="7.2"
PRETTY_NAME="Red Hat Enterprise Linux"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:7.2:GA:server"
HOME_URL="https://www.redhat.com/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 7"
REDHAT_BUGZILLA_PRODUCT_VERSION=7.2
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="7.2"
Red Hat Enterprise Linux Server release 7.2 (Maipo)
Red Hat Enterprise Linux Server release 7.2 (Maipo)

Hi Keith,

I'm still working on the reservation commands. Regarding NVMe 1.2.1 spec. I've found improper use of codes in your master branch and made some changes as well. In addition, some functions (e.g., resv_*) related to the reservation do not return error code. Please refer to my branch (https://github.com/DrYSOH/nvme-cli/commits/resv_dev).

Thanks

Just adding this to the issues tracker so I don't forget it. There is a driver dependency on being able to do these as the IOCTLs and sysfs entries are fairly recent additions.

Is this behaviour expected ?

# nvme list
Node             SN                   Model                                    Namespace Usage                      Format           FW Rev  
---------------- -------------------- ---------------------------------------- --------- -------------------------- ---------------- --------
/dev/nvme0n1     STM0001A8A15         PCIe3 1.6TB NVMe Adapter                 1           1.60  TB /   1.60  TB      4 KiB +  0 B   KMIPP107

# nvme subsystem-reset /dev/nvme0; echo $?
0

# time nvme list; echo $?
Node             SN                   Model                                    Namespace Usage                      Format           FW Rev  
---------------- -------------------- ---------------------------------------- --------- -------------------------- ---------------- --------
/dev/nvme0n1                          �@                                       1           1.60  TB /   1.60  TB      4 KiB +  0 B   p;��

real    1m2.110s
user    0m0.001s
sys 0m0.003s
0

# time nvme list; echo $?
Node             SN                   Model                                    Namespace Usage                      Format           FW Rev  
---------------- -------------------- ---------------------------------------- --------- -------------------------- ---------------- --------
/dev/nvme0n1     STM0001A8A15         PCIe3 1.6TB NVMe Adapter                 1           1.60  TB /   1.60  TB      4 KiB +  0 B   KMIPP107

real    0m0.003s
user    0m0.000s
sys 0m0.002s
0

We're not using 32-bit right now, but here is the output from a build attempt:

cc -I -m64 -std=gnu99 -O2 -g -pthread -D_GNU_SOURCE -D_REENTRANT -Wall -Werror -DLIBUDEV_EXISTS nvme.c -lm -ludev -o nvme argconfig.o suffix.o
cc1: warnings being treated as errors
nvme.c: In function 'nvme_attach_ns':
nvme.c:1535: error: cast from pointer to integer of different size
nvme.c: In function 'nvme_feature':
nvme.c:2114: error: cast from pointer to integer of different size
nvme.c: In function 'fw_download':
nvme.c:2317: error: cast from pointer to integer of different size
nvme.c: In function 'sec_send':
nvme.c:2707: error: cast from pointer to integer of different size
nvme.c: In function 'resv_acquire':
nvme.c:2849: error: cast from pointer to integer of different size
nvme.c: In function 'resv_register':
nvme.c:2943: error: cast from pointer to integer of different size
nvme.c: In function 'resv_release':
nvme.c:3038: error: cast from pointer to integer of different size
nvme.c: In function 'resv_report':
nvme.c:3120: error: cast from pointer to integer of different size
nvme.c: In function 'submit_io':
nvme.c:3270: error: cast from pointer to integer of different size
nvme.c:3272: error: cast from pointer to integer of different size
nvme.c:3279: error: cast to pointer from integer of different size
nvme.c:3280: error: cast to pointer from integer of different size
nvme.c:3281: error: cast to pointer from integer of different size
nvme.c: In function 'sec_recv':
nvme.c:3401: error: cast from pointer to integer of different size
nvme.c: In function 'nvme_passthru':
nvme.c:3569: error: cast from pointer to integer of different size
nvme.c:3571: error: cast from pointer to integer of different size
nvme.c:3581: error: cast to pointer from integer of different size
nvme.c:3596: error: cast to pointer from integer of different size
nvme.c:3597: error: cast to pointer from integer of different size
nvme.c:3614: error: cast to pointer from integer of different size
nvme.c:3616: error: cast to pointer from integer of different size

It seems CFG_NONE and no_argument type argument may corrupt other parameters by get_opt_long().
nvme.c uses '__u8' for CFG_NONE&no_argument type, however getopt_long_only() in argconfig_parse() assume it as 'int'.
__u8 argument may be overwritten with 32bit value, and corrupts other parameter value.
These __u8 member should be modified with __u32. Checked on Ubuntu 15.04 x86_64.

For example, "--raw-binary" and "--read" are CFG_NONE&no_argument type arguments.
$ nvme io-passthru /dev/nvme0 --opcode=2 --namespace-id=1 --data-len=4096 --cdw10=0 --cdw11=0 --raw-binary --read
Pass: OK
$ nvme io-passthru /dev/nvme0 --opcode=2 --namespace-id=1 --data-len=4096 --cdw10=0 --cdw11=0 --read --raw-binary
Fail: "data direction not given" error

Could you please check changes in e14b613926e91e0105c97b8734f23bbc7169c1c3 ?

Hi, I have been able to do IO transaction for single sector i.e., 512B, but when I try to for 1024Bytes with Protection Information enabled, it does not seem to work and I couldn't find much information in the document. can you please send me the exact command to send data of 1024Bytes with End to End protection enabled ?, thanks.

-Ram.

There are currently three copies of each command documentation under Documentation: man page, html, and text.

The packages only need the man pages, do we need to keep the other formats in the tree? Can we just generate those as needed? What are the consumers of the .txt and html formats?

Guys

As CMBs become more popular we want a nvme cmb command to give a more verbose indication of the CMB functionality of a drive. Also, eventually we may have the ability to alter things about the CMB and this function will be a placeholder for doing that through the nvme-cli tool.

I'll work on a PR that (initially) just displays the CMBLOC and CMBSZ values in human consumable form. This is an improvement on nvme show-regs. Comments?

Stephen

Trying to issue dsm command on Ubuntu, and it fails with error code ffffffff, works on red hat however..

Latest nvme-cli fails with make errors (Ubuntu 14.04 Kernel 3.19)

make output
NVME_VERSION = 0.8.35.g8aa3
cc -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.8.35.g8aa3"' -c argconfig.c
cc -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.8.35.g8aa3"' -c suffix.c
cc -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.8.35.g8aa3"' -c parser.c
cc -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.8.35.g8aa3"' -c nvme-print.c
cc -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.8.35.g8aa3"' -c nvme-ioctl.c
cc -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.8.35.g8aa3"' -c nvme-lightnvm.c
cc -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.8.35.g8aa3"' -c fabrics.c
cc -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.8.35.g8aa3"' -c json.c
cc -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.8.35.g8aa3"' -c plugin.c
cc -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.8.35.g8aa3"' -c intel-nvme.c
cc -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.8.35.g8aa3"' -c lnvm-nvme.c
cc -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.8.35.g8aa3"' -c memblaze-nvme.c
cc -D_GNU_SOURCE -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.8.35.g8aa3"' nvme.c -ludev -o nvme argconfig.o suffix.o parser.o nvme-print.o nvme-ioctl.o nvme-lightnvm.o fabrics.o json.o plugin.o intel-nvme.o lnvm-nvme.o memblaze-nvme.o
fabrics.o: In function disconnect_by_nqn': /tmp/nvme-cli/fabrics.c:779: undefined reference toudev_new'
/tmp/nvme-cli/fabrics.c:786: undefined reference to udev_enumerate_new' /tmp/nvme-cli/fabrics.c:792: undefined reference toudev_enumerate_add_match_subsystem'
/tmp/nvme-cli/fabrics.c:793: undefined reference to udev_enumerate_scan_devices' fabrics.o: In functiondisconnect_subsys':
/tmp/nvme-cli/fabrics.c:742: undefined reference to udev_enumerate_get_list_entry' /tmp/nvme-cli/fabrics.c:745: undefined reference toudev_list_entry_get_name'
/tmp/nvme-cli/fabrics.c:745: undefined reference to udev_enumerate_get_udev' /tmp/nvme-cli/fabrics.c:745: undefined reference toudev_device_new_from_syspath'
/tmp/nvme-cli/fabrics.c:748: undefined reference to udev_device_get_sysattr_value' /tmp/nvme-cli/fabrics.c:761: undefined reference toudev_device_unref'
/tmp/nvme-cli/fabrics.c:742: undefined reference to udev_list_entry_get_next' fabrics.o: In functiondisconnect_by_nqn':
/tmp/nvme-cli/fabrics.c:795: undefined reference to udev_enumerate_unref' /tmp/nvme-cli/fabrics.c:798: undefined reference toudev_unref'
/tmp/nvme-cli/fabrics.c:798: undefined reference to udev_unref' /tmp/nvme-cli/fabrics.c:750: undefined reference toudev_device_get_syspath'
/tmp/nvme-cli/fabrics.c:756: undefined reference to udev_device_unref' /tmp/nvme-cli/fabrics.c:795: undefined reference toudev_enumerate_unref'
/tmp/nvme-cli/fabrics.c:798: undefined reference to udev_unref' /tmp/nvme-cli/fabrics.c:753: undefined reference toudev_device_unref'
collect2: error: ld returned 1 exit status
make: *** [nvme] Error 1

root@kirby /h/sonny# nvme list
nvme0 failed to map

Linux 4.5.0
nvme-cli 0.6
Samsung SM951-NVMe 256GB

I am trying to build nvme-cli on latest Ubuntu 14.04 trusty, but it fails with:
nvme-cli$ make
cc -c -I -m64 -std=gnu99 -O2 -g -pthread -D_GNU_SOURCE -D_REENTRANT -Wall -Werror ./src/argconfig.c
./src/argconfig.c: In function ‘argconfig_print_help’:
./src/argconfig.c:161:5: error: format not a string literal and no format arguments [-Werror=format-security]
printf(buf);
^
cc1: all warnings being treated as errors
make: *** [argconfig.o] Error 1

I replaced the printf with
*fputs(buf, stderr);
and the make runs through. Maybe you can take a look at that!

All the best, Georg

Is the shorthand for --nsze supposed to be -n or -s?

Synopsis
'nvme create-ns' [--nsze= | -n ]

Options
-s::
--nsze::
https://guides.github.com/features/mastering-markdown/
The namespace size.

It appears -s is the correct one, when looking at nvme.c:
https://github.com/linux-nvme/nvme-cli/blob/master/nvme.c :
{"nsze", 's', "NUM", CFG_LONG_SUFFIX, &cfg.nsze, required_argument, nsze},

The ledctl/ledmon package doesn't seem to have support for NVMe drives yet. Any chance nvme-cli will be getting that since that project doesn't seem to be moving very quickly?

(I gave the patch here by @keithbusch a try, but it didn't seem to work on my system. (Could be because I have a PLX PCIe switch in between the motherboard and drives?)

i dont see any options in makefile to make standalone static executable. If I am wrong please help me out in creating a standalone static executable.

Neither RPM or debian package include them. I think they can be included unconditionally, but I have not looked up where.

I know it's crazy, but I hear some people don't use x86. I don't want those folks to feel dejected, so I'll post the issue so they know the little people are looking out for the big people (pun intended).

I notice that 3fdbf12 changed the LICENSE file to GPL 2.0.

Should the source headers of these 7 files have been updated too?

https://github.com/linux-nvme/nvme-cli/search?utf8=%E2%9C%93&q=%22Apache+License%22

I think these packages would complement each other: lsnvme provides a user friendly display of the attached disks/controllers with libudev/hwdb, nvme covers the ioctl interfaces.

lsnvme can share "nvme-print.*" and the autotools build system.

Hi

In order to reduce code volume we propose migrating command line processing to argconfig. This also allows for scientific suffix support in command line arguments (e.g. 4k, 1M etc).

Stephen

It would be very helpful if you could add separate commands for Identify data structures for above CNS values, I think what is supported right now is 00h (id-ns), 01h (id-ctrl), 10h (list-ns) and 13h (list-ctrl) as per NVMe spec 1.2. !!

Could you please fix:

nvme-print.c

There does not appear to be any documentation of the format of file /etc/nvme/discovery.conf, which a new user is apparently required to create.

Details: I installed nvme-cli v0.9 from a ZIP file on a CentOS 7.2 initiator/host machine. I ran "nvme discover" and got back "No discover params given and no /etc/nvme/discovery.conf conf". Doing "fgrep -r discovery.conf nvme-cli-0.9" yielded one '#define' line in fabrics.c and notice that binary files fabrics.o and nvme match. It would be helpful for a new user to have some documentation about the file format. Reverse engineering the file format from the source code is rather inefficient.

(I'm a new would-be user of the tool. If somebody could drop me a quick message with a hint or two about the file format, it would be appreciated.)

For Fedora packages, the rules say that we have to set Fedora's preferred CFLAGS and LDFLAGS. This breaks the Makefile: udev detection blows up.

An easy fix would be to do:

    override LDFLAGS += -ludev
    override CFLAGS  += -DLIBUDEV_EXISTS
    override LIB_DEPENDS += udev

The "override" makes "make CFLAGS=whatever" not skip these assignments.

A nicer approach might be to use a different variable for the udev stuff or to support EXTRA_CFLAGS and EXTRA_LDFLAGS as alternatives to CFLAGS and LDFLAGS.

(It might also be nice to drop build-time udev detection entirely and just require udev.)

Hi

In linux kernel upstream commit 90a545e98 a new CONFIG was added to the kernel that prevents userspace programs (even root) from accesses MMIO regions that are already claimed by a driver. This breaks certain things in NVMe and was found and discussed in another issue.

The issue tracks an effort to document the issue and provide a better user experience when it happens. I plan to try and add a trap for this and a section to the README.md to educate users.

In time we might fix all the broken commands and then this issue becomes moot.

Cheers

Stephen

list-ns returns a lot of garbage data, probably for the unused buffer space...is this correct? Or am I interpreting the returned data structure wrong.?

src/argconfig.c:243]: (style) Checking if unsigned variable 'tmp' is less than zero.

Source code is

        uint8_t tmp = strtol(optarg, &endptr, 0);
        if (errno || tmp < 0 || optarg == endptr) {

Was strtoul intended ?

src/argconfig.c:252]: (style) Checking if unsigned variable 'tmp' is less than zero.
src/argconfig.c:261]: (style) Checking if unsigned variable 'tmp' is less than zero.

Duplicates.

Any plans for official packages for nvme-cli?

In the mean time I've built a Debian package which is available here: https://packagecloud.io/mrmondo/storage - feel free to use it if you wish.