linkurious / angular-performance Goto Github PK

Angular performance, ng-app and data-ng-app are not defined. At least one need to be defined.

for example:

angular.bootstrap($('body'), ['MyNGapp'], {});

The link between the tab and the devtools breaks after refresh. The connection should be brought back manually

Temporary Fix
Close and open back the devtools should fix it.

I get this when loading chrome, and the extension reports 0's on all three values

inspector.js:83
_angularInjector = angular.element(document.querySelector('[ng-app],[data-ng-app]')).injector().get;

if I change it to this:
_angularInjector = angular.element(document).injector().get;

It works

I'm bootstraping angular:
function onReady() {
angular.bootstrap(document, ['blockchess']);
}

if (Meteor.isCordova)
angular.element(document).on("deviceready", onReady);
else
angular.element(document).ready(onReady);

we can cover both cases like this:
_angularInjector = (angular.element(document.querySelector('[ng-app],[data-ng-app]')).injector() || angular.element(document).injector()).get;

Or a bit cleaner like so:
var injector = angular.element(document.querySelector('[ng-app],[data-ng-app]')).injector() || angular.element(document).injector()
_angularInjector = (injector).get;

Let me know if this make sense, I'll create a pull request

and please hurry this extension seems cool I wanna use it! :)

Currently the XPath of targeted elements of events are displayed as is. It would be nice to be able to click on them.

Extension is broken on Chrome OSX Version 44.0.2403.130 (64-bit). The background.html shows:

Unchecked runtime.lastError while running tabs.executeScript: Cannot access contents of url "chrome-devtools://devtools/bundled/devtools.html?&remoteBase=https://chrome-devtools-frontend.appspot.com/serve_file/@199588/&dockSide=undocked&toolbarColor=rgba(230,230,230,1)&textColor=rgba(0,0,0,1)". Extension manifest must request permission to access this host.
at devToolsListener (chrome-extension://hejbpbhdhhchmmcgmccpnngfedalkmkm/src/background.js:34:21)

Weird bug, need to find out why.

In Function Timing, no module name is found when JS code is minified.

A reset button would be great to force reset all data captured.

Looks like the chrome webstore build does not recognize modules when the script are minified

Adding growls could be used to provide feedback to the user.

As of now the inspector was injected in all the pages whether or not the devtools were opened.

Would be nice to have it injected only if the devtools are opened.

No error in console. All metrics show zero.

Looks like the event loading complete is also fired with angular 1.3 on route change.

To help comparison, it would be great to export charts as images.

A a scope inspector tab like the one available in batarang or angular inspector so that only one angular inspecting extension is needed.

Currently the event bubbles are not adapting to the XPath of the target element.

Hi,

This project is still Maintained ?
Regards

Right now the FPS areas in the extension are placeholders, they should be implemented.

Once the devtools are closed, the inspector keeps inspecting the webpage.

The proper behavior would be that all inspector trace should be removed once the devtools are closed.

• have the inspector back everything up
• clean up everything on devtool closing